You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "suyanhanx (via GitHub)" <gi...@apache.org> on 2026/05/19 08:39:59 UTC
[PR] test(bindings/nodejs): upgrade vitest for behavior stability [opendal]
suyanhanx opened a new pull request, #7559:
URL: https://github.com/apache/opendal/pull/7559
# Which issue does this PR close?
Closes #7557.
# Rationale for this change
The current Node.js binding pins Vitest `3.2.4`, and that version can surface `Error: [vitest-worker]: Timeout calling "onTaskUpdate"` even when the test itself passes.
I reproduced this locally with a minimal 61-second synchronous worker-blocking test. The same repro passes cleanly on the latest stable Vitest `4.1.6` with no unhandled RPC timeout. Because of that, this PR takes the upgrade-first path instead of restructuring the behavior harness.
# What changes are included in this PR?
- Upgrade `bindings/nodejs` from Vitest `^3.2.3` to `^4.1.6`
- Bump `@types/node` to `^20.19.41` to satisfy current Vitest/Vite peer expectations
- Remove the temporary `dangerouslyIgnoreUnhandledErrors` workaround from `bindings/nodejs/vitest.config.mjs`
- Keep the existing single-file Node.js behavior harness unchanged
Local validation:
- `cd bindings/nodejs && pnpm build:debug`
- `cd bindings/nodejs && OPENDAL_TEST=memory pnpm test`
- Temporary repro test with a 61-second `Atomics.wait(...)` block passes cleanly on Vitest `4.1.6`
- `cd bindings/nodejs && cargo test --no-fail-fast`
I could not replay the real TOS-backed slow-service path locally because the current local `.env` does not include TOS credentials.
# Are there any user-facing changes?
No user-facing API changes. This only updates Node.js test/dev dependencies and removes the temporary test-run workaround.
# AI Usage Statement
Prepared with OpenAI Codex (GPT-5-based coding agent).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(bindings/nodejs): upgrade vitest for behavior stability [opendal]
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx closed pull request #7559: test(bindings/nodejs): upgrade vitest for behavior stability
URL: https://github.com/apache/opendal/pull/7559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org