You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/09/07 01:13:17 UTC
[GitHub] [doris] stalary opened a new pull request, #12401: [Enhancement](DOE): Doe support object/nested use string
stalary opened a new pull request, #12401:
URL: https://github.com/apache/doris/pull/12401
# Proposed changes
Issue Number: close https://github.com/apache/doris/issues/12387
## Problem summary
Doe support object/nested use string
1. doc_value logic modify, ignore object/nested
2. auto create table mapping object/nested to string type.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
3. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
5. Does it need to update dependencies:
- [ ] Yes
- [ ] No
6. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] stalary merged pull request #12401: [Enhancement](DOE): Doe support object/nested use string
Posted by GitBox <gi...@apache.org>.
stalary merged PR #12401:
URL: https://github.com/apache/doris/pull/12401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #12401: [Enhancement](DOE): Doe support object/nested use string
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12401:
URL: https://github.com/apache/doris/pull/12401#issuecomment-1244799796
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #12401: [Enhancement](DOE): Doe support object/nested use string
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12401:
URL: https://github.com/apache/doris/pull/12401#issuecomment-1241683953
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] stalary closed pull request #12401: [Enhancement](DOE): Doe support object/nested use string
Posted by GitBox <gi...@apache.org>.
stalary closed pull request #12401: [Enhancement](DOE): Doe support object/nested use string
URL: https://github.com/apache/doris/pull/12401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] stalary commented on pull request #12401: [Enhancement](DOE): Doe support object/nested use string
Posted by GitBox <gi...@apache.org>.
stalary commented on PR #12401:
URL: https://github.com/apache/doris/pull/12401#issuecomment-1241607765
@qidaye @Gabriel39 done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] qidaye commented on a diff in pull request #12401: [Enhancement](DOE): Doe support object/nested use string
Posted by GitBox <gi...@apache.org>.
qidaye commented on code in PR #12401:
URL: https://github.com/apache/doris/pull/12401#discussion_r965604625
##########
fe/fe-core/src/main/java/org/apache/doris/external/elasticsearch/EsUtil.java:
##########
@@ -358,22 +358,23 @@ public static List<Column> genColumnsFromEs(EsRestClient client, String indexNam
List<Column> columns = new ArrayList<>();
for (String key : keys) {
JSONObject field = (JSONObject) mappingProps.get(key);
+ Type type;
// Complex types are not currently supported.
Review Comment:
```suggestion
// Complex types are treating as STRING types for now.
```
##########
fe/fe-core/src/main/java/org/apache/doris/external/elasticsearch/MappingPhase.java:
##########
@@ -119,6 +119,8 @@ private static void resolveDocValuesFields(SearchContext searchContext, JSONObje
if (!docValue) {
return;
}
+ } else if (fieldType == null) {
Review Comment:
Add some comments to explain why we need this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] lide-reed commented on a diff in pull request #12401: [Enhancement](DOE): Doe support object/nested use string
Posted by GitBox <gi...@apache.org>.
lide-reed commented on code in PR #12401:
URL: https://github.com/apache/doris/pull/12401#discussion_r966741900
##########
be/src/http/http_client.cpp:
##########
@@ -162,7 +163,8 @@ Status HttpClient::execute(const std::function<bool(const void* data, size_t len
_callback = &callback;
auto code = curl_easy_perform(_curl);
if (code != CURLE_OK) {
- LOG(WARNING) << "fail to execute HTTP client, errmsg=" << _to_errmsg(code);
+ LOG(WARNING) << "fail to execute HTTP client, errmsg=" << _to_errmsg(code)
+ << " trace=" << get_stack_trace();
Review Comment:
trace --> ,trace ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] stalary commented on a diff in pull request #12401: [Enhancement](DOE): Doe support object/nested use string
Posted by GitBox <gi...@apache.org>.
stalary commented on code in PR #12401:
URL: https://github.com/apache/doris/pull/12401#discussion_r969052909
##########
be/src/http/http_client.cpp:
##########
@@ -162,7 +163,8 @@ Status HttpClient::execute(const std::function<bool(const void* data, size_t len
_callback = &callback;
auto code = curl_easy_perform(_curl);
if (code != CURLE_OK) {
- LOG(WARNING) << "fail to execute HTTP client, errmsg=" << _to_errmsg(code);
+ LOG(WARNING) << "fail to execute HTTP client, errmsg=" << _to_errmsg(code)
+ << " trace=" << get_stack_trace();
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #12401: [Enhancement](DOE): Doe support object/nested use string
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12401:
URL: https://github.com/apache/doris/pull/12401#issuecomment-1241683890
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 commented on a diff in pull request #12401: [Enhancement](DOE): Doe support object/nested use string
Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on code in PR #12401:
URL: https://github.com/apache/doris/pull/12401#discussion_r965456320
##########
fe/fe-core/src/main/java/org/apache/doris/external/elasticsearch/EsUtil.java:
##########
@@ -403,16 +404,15 @@ public static Type toDorisType(String esType) {
case "double":
case "scaled_float":
return Type.DOUBLE;
+ case "date":
Review Comment:
I think you should use ScalarType.getDefaultDateType(Type.DATE) to enable users to read date as datev2 type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org