You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by mosermw <gi...@git.apache.org> on 2018/03/27 21:12:15 UTC

[GitHub] nifi issue #2559: NIFI-4658 set Maximum Number of Entries to required with d...

Github user mosermw commented on the issue:

    https://github.com/apache/nifi/pull/2559
  
    Hi @markobean, I reviewed this and I have a couple of questions.  I'm not sure I understand why the `throw e;` statements were removed from MergeContent.  Can you explain or put them back in?  Also, in TestMergeContent, I'm not sure why the `testDefragmentOldStyleAttributes()` test was removed.  The test still passes with the rest of your PR applied.  Was this perhaps part of the changes made before you modified the PR and force pushed?  Thanks for looking into this.


---