[jira] [Commented] (AMBARI-21182) Agent Host Disk Usage Alert Hardcodes the Stack Directory

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-21182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16038598#comment-16038598 ] 

Hadoop QA commented on AMBARI-21182:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12871562/AMBARI-21182.patch
  against trunk revision .

    {color:red}-1 patch{color}.  Top-level [trunk compilation|https://builds.apache.org/job/Ambari-trunk-test-patch/11631//artifact/patch-work/trunkJavacWarnings.txt] may be broken.

Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/11631//console

This message is automatically generated.

> Agent Host Disk Usage Alert Hardcodes the Stack Directory
> ---------------------------------------------------------
>
>                 Key: AMBARI-21182
>                 URL: https://issues.apache.org/jira/browse/AMBARI-21182
>             Project: Ambari
>          Issue Type: Bug
>            Reporter: Andrew Onischuk
>            Assignee: Andrew Onischuk
>             Fix For: 2.5.2
>
>         Attachments: AMBARI-21182.patch
>
>
> The Host Disk Usage alert currently hard codes the stack location directly
> into the script:
>     
>     
>     
>     # the location where HDP installs components when using HDP 2.2+
>     STACK_HOME_DIR = "/usr/hdp"
>     # the location where HDP installs components when using HDP 2.0 to 2.1
>     STACK_HOME_LEGACY_DIR = "/usr/lib"
>     # determine the location of HDP home
>       stack_home = None
>       if os.path.isdir(STACK_HOME_DIR):
>         stack_home = STACK_HOME_DIR
>       elif os.path.isdir(STACK_HOME_LEGACY_DIR):
>         stack_home = STACK_HOME_LEGACY_DIR
>     
> On clusters where a different stack is installed (such as `/usr/hdf`, the
> above logic incorrectly checks the `STACK_HOME_LEGACY_DIR`.
>   * The 2.0 and 2.1 code paths should be removed since they are not supported anymore.
>   * We should parameterize STACK_HOME_DIR (or even better, use the stack features JSON structure) to determine the home location to check.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)