[GitHub] stevedlawrence commented on a change in pull request #151: Add tunables for textBidi and floating properties

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #151: Add tunables for textBidi and floating properties
URL: https://github.com/apache/incubator-daffodil/pull/151#discussion_r241101643
 
 

 ##########
 File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ElementBase.scala
 ##########
 @@ -1233,4 +1234,12 @@ trait ElementBase
     }
   }
 
+  private lazy val optionFloating = findPropertyOption("floating")
+
+  private def checkFloating = (optionFloating.isDefined, tunable.requireFloatingProperty) match {
+    case (false, false) => SDW(WarnID.FloatingError, "Property 'dfdl:floating' is required but not defined.")
+    case (false, true) => SDE("Property 'dfdl:floating' is required but not defined.")
 
 Review comment:
   Might be worth replacing this SDE with a call to "floating". That call would require the floating property and output the standard property missing SDE, which also shows some context like where it looked for the property. Same with textBidi below.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services