You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org> on 2011/08/29 20:02:38 UTC
[jira] [Created] (HBASE-4280) [replication] ReplicationSink can
deadlock itself via handlers
[replication] ReplicationSink can deadlock itself via handlers
--------------------------------------------------------------
Key: HBASE-4280
URL: https://issues.apache.org/jira/browse/HBASE-4280
Project: HBase
Issue Type: Improvement
Affects Versions: 0.90.4
Reporter: Jean-Daniel Cryans
Assignee: Jean-Daniel Cryans
Fix For: 0.90.5
I've experienced this problem a few times, ReplicationSink calls are received through the normal handlers and potentially can call itself which, in certain situations, call fill up all the handlers. For example, 10 handlers that are all replication calls are all trying to talk to the local server at the same time.
HRS.replicateLogEntries should have @QosPriority(priority=HIGH_QOS) to use the other set of handlers.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4280) [replication] ReplicationSink can
deadlock itself via handlers
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113905#comment-13113905 ]
Hudson commented on HBASE-4280:
-------------------------------
Integrated in HBase-TRUNK #2247 (See [https://builds.apache.org/job/HBase-TRUNK/2247/])
HBASE-4280 [replication] ReplicationSink can deadlock itself via handlers
jdcryans :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
> [replication] ReplicationSink can deadlock itself via handlers
> --------------------------------------------------------------
>
> Key: HBASE-4280
> URL: https://issues.apache.org/jira/browse/HBASE-4280
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.90.5
>
> Attachments: HBASE-4280-0.90.patch
>
>
> I've experienced this problem a few times, ReplicationSink calls are received through the normal handlers and potentially can call itself which, in certain situations, call fill up all the handlers. For example, 10 handlers that are all replication calls are all trying to talk to the local server at the same time.
> HRS.replicateLogEntries should have @QosPriority(priority=HIGH_QOS) to use the other set of handlers.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4280) [replication] ReplicationSink can
deadlock itself via handlers
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Daniel Cryans resolved HBASE-4280.
---------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Committed to 0.90, 0.92, trunk. Thanks for your comments Stack!
> [replication] ReplicationSink can deadlock itself via handlers
> --------------------------------------------------------------
>
> Key: HBASE-4280
> URL: https://issues.apache.org/jira/browse/HBASE-4280
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.90.5
>
> Attachments: HBASE-4280-0.90.patch
>
>
> I've experienced this problem a few times, ReplicationSink calls are received through the normal handlers and potentially can call itself which, in certain situations, call fill up all the handlers. For example, 10 handlers that are all replication calls are all trying to talk to the local server at the same time.
> HRS.replicateLogEntries should have @QosPriority(priority=HIGH_QOS) to use the other set of handlers.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4280) [replication] ReplicationSink can
deadlock itself via handlers
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104753#comment-13104753 ]
Jean-Daniel Cryans commented on HBASE-4280:
-------------------------------------------
It seems like we shouldn't be the ones deciding that... but currently the user has no control over QOS since it's hard-coded.
> [replication] ReplicationSink can deadlock itself via handlers
> --------------------------------------------------------------
>
> Key: HBASE-4280
> URL: https://issues.apache.org/jira/browse/HBASE-4280
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.90.5
>
> Attachments: HBASE-4280-0.90.patch
>
>
> I've experienced this problem a few times, ReplicationSink calls are received through the normal handlers and potentially can call itself which, in certain situations, call fill up all the handlers. For example, 10 handlers that are all replication calls are all trying to talk to the local server at the same time.
> HRS.replicateLogEntries should have @QosPriority(priority=HIGH_QOS) to use the other set of handlers.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4280) [replication] ReplicationSink can
deadlock itself via handlers
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113540#comment-13113540 ]
stack commented on HBASE-4280:
------------------------------
Ok. +1 on this patch for 0.90 (and for 0.92 till we do hbase-4441)
> [replication] ReplicationSink can deadlock itself via handlers
> --------------------------------------------------------------
>
> Key: HBASE-4280
> URL: https://issues.apache.org/jira/browse/HBASE-4280
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.90.5
>
> Attachments: HBASE-4280-0.90.patch
>
>
> I've experienced this problem a few times, ReplicationSink calls are received through the normal handlers and potentially can call itself which, in certain situations, call fill up all the handlers. For example, 10 handlers that are all replication calls are all trying to talk to the local server at the same time.
> HRS.replicateLogEntries should have @QosPriority(priority=HIGH_QOS) to use the other set of handlers.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4280) [replication] ReplicationSink can
deadlock itself via handlers
Posted by "Jonathan Hsieh (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-4280:
----------------------------------
Fix Version/s: 0.94.0
0.92.0
> [replication] ReplicationSink can deadlock itself via handlers
> --------------------------------------------------------------
>
> Key: HBASE-4280
> URL: https://issues.apache.org/jira/browse/HBASE-4280
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.92.0, 0.94.0, 0.90.5
>
> Attachments: HBASE-4280-0.90.patch
>
>
> I've experienced this problem a few times, ReplicationSink calls are received through the normal handlers and potentially can call itself which, in certain situations, call fill up all the handlers. For example, 10 handlers that are all replication calls are all trying to talk to the local server at the same time.
> HRS.replicateLogEntries should have @QosPriority(priority=HIGH_QOS) to use the other set of handlers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4280) [replication] ReplicationSink can
deadlock itself via handlers
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113879#comment-13113879 ]
Hudson commented on HBASE-4280:
-------------------------------
Integrated in HBase-0.92 #18 (See [https://builds.apache.org/job/HBase-0.92/18/])
HBASE-4280 [replication] ReplicationSink can deadlock itself via handlers
jdcryans :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
> [replication] ReplicationSink can deadlock itself via handlers
> --------------------------------------------------------------
>
> Key: HBASE-4280
> URL: https://issues.apache.org/jira/browse/HBASE-4280
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.90.5
>
> Attachments: HBASE-4280-0.90.patch
>
>
> I've experienced this problem a few times, ReplicationSink calls are received through the normal handlers and potentially can call itself which, in certain situations, call fill up all the handlers. For example, 10 handlers that are all replication calls are all trying to talk to the local server at the same time.
> HRS.replicateLogEntries should have @QosPriority(priority=HIGH_QOS) to use the other set of handlers.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4280) [replication] ReplicationSink can
deadlock itself via handlers
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104265#comment-13104265 ]
stack commented on HBASE-4280:
------------------------------
Should replication traffic be preferred to server's main load? Should there be a lower-priority than handler-set that the replication traffic uses?
> [replication] ReplicationSink can deadlock itself via handlers
> --------------------------------------------------------------
>
> Key: HBASE-4280
> URL: https://issues.apache.org/jira/browse/HBASE-4280
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.90.5
>
> Attachments: HBASE-4280-0.90.patch
>
>
> I've experienced this problem a few times, ReplicationSink calls are received through the normal handlers and potentially can call itself which, in certain situations, call fill up all the handlers. For example, 10 handlers that are all replication calls are all trying to talk to the local server at the same time.
> HRS.replicateLogEntries should have @QosPriority(priority=HIGH_QOS) to use the other set of handlers.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4280) [replication] ReplicationSink can
deadlock itself via handlers
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Daniel Cryans updated HBASE-4280:
--------------------------------------
Attachment: HBASE-4280-0.90.patch
Puts HRS.replicateLogEntries in the high priority bucket. Maybe we need another bucket? Maybe for those RS -> RS communications.
> [replication] ReplicationSink can deadlock itself via handlers
> --------------------------------------------------------------
>
> Key: HBASE-4280
> URL: https://issues.apache.org/jira/browse/HBASE-4280
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.90.5
>
> Attachments: HBASE-4280-0.90.patch
>
>
> I've experienced this problem a few times, ReplicationSink calls are received through the normal handlers and potentially can call itself which, in certain situations, call fill up all the handlers. For example, 10 handlers that are all replication calls are all trying to talk to the local server at the same time.
> HRS.replicateLogEntries should have @QosPriority(priority=HIGH_QOS) to use the other set of handlers.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4280) [replication] ReplicationSink can
deadlock itself via handlers
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113543#comment-13113543 ]
Jean-Daniel Cryans commented on HBASE-4280:
-------------------------------------------
I've been testing it under heavy an heavy upload workload that used to fail before that for 12 hours and it's still working, going to commit. Thanks for the +1 Stack.
> [replication] ReplicationSink can deadlock itself via handlers
> --------------------------------------------------------------
>
> Key: HBASE-4280
> URL: https://issues.apache.org/jira/browse/HBASE-4280
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.90.5
>
> Attachments: HBASE-4280-0.90.patch
>
>
> I've experienced this problem a few times, ReplicationSink calls are received through the normal handlers and potentially can call itself which, in certain situations, call fill up all the handlers. For example, 10 handlers that are all replication calls are all trying to talk to the local server at the same time.
> HRS.replicateLogEntries should have @QosPriority(priority=HIGH_QOS) to use the other set of handlers.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4280) [replication] ReplicationSink can
deadlock itself via handlers
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108053#comment-13108053 ]
Jean-Daniel Cryans commented on HBASE-4280:
-------------------------------------------
I opened HBASE-4441.
> [replication] ReplicationSink can deadlock itself via handlers
> --------------------------------------------------------------
>
> Key: HBASE-4280
> URL: https://issues.apache.org/jira/browse/HBASE-4280
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.90.5
>
> Attachments: HBASE-4280-0.90.patch
>
>
> I've experienced this problem a few times, ReplicationSink calls are received through the normal handlers and potentially can call itself which, in certain situations, call fill up all the handlers. For example, 10 handlers that are all replication calls are all trying to talk to the local server at the same time.
> HRS.replicateLogEntries should have @QosPriority(priority=HIGH_QOS) to use the other set of handlers.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira