You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "kgabryje (via GitHub)" <gi...@apache.org> on 2025/08/05 19:21:16 UTC

[PR] feat: Tiled screenshots in Playwright reports [superset]

kgabryje opened a new pull request, #34561:
URL: https://github.com/apache/superset/pull/34561

   
   ### SUMMARY
   Playwright reports used to return a blank screenshots when run on large dashboards.
   
   After some experiments I found out that the problem appears to actually come from Chromium itself, not Playwright. After enabling CPU 4x throttling and taking a screenshot using Chrome's dev tools, I noticed that before taking the screenshot, it unmounts and redraws a lot of UI elements, leaving just the dashboard's background, and it doesn't finish redrawing until after the screenshot is taken, resulting in blank image (see video).
   The solution that this PR implements was to take multiple small screenshots/tiles and glue them together into the final report before sending it to the user.
   I tested the solution on a large dashboard (~50 charts, deck.gl and Echarts) which failed consistently before. After my changes, it consistently sends expected screenshot.
   
   There are also some config flags for fine tuning the tiling feature:
   - `SCREENSHOT_TILED_ENABLED` (True by default, disabling not recommended)
   - `SCREENSHOT_TILED_CHART_THRESHOLD` (threshold of dashboard height at which tiling gets triggered)
   - `SCREENSHOT_TILED_HEIGHT_THRESHOLD` (number of charts at which tiling gets triggered)
   - `SCREENSHOT_TILED_VIEWPORT_HEIGHT` (single tile viewport height)
   If the blank screenshot problem persists, you can try decreasing the value of each of those flags
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   
   <img width="2800" height="15484" alt="image" src="https://github.com/user-attachments/assets/e4671dca-57c1-4afb-84fb-38a708efc50e" />
   
   After:
   
   <img width="2800" height="15484" alt="image" src="https://github.com/user-attachments/assets/2733722b-8f7e-44b2-bf0f-c29401fecdfa" />
   
   
   ### TESTING INSTRUCTIONS
   1. Enable `PLAYWRIGHT_REPORTS_AND_THUMBNAILS`, install playwright, run `playwright install`.
   2. Create a very large dashboard (~50 charts should be enough)
   3. Set up a report with this dashboard
   4. Verify that the screenshot is generated correctly
   5. Also test on smaller dashboards were the tiling effect should not trigger
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Tiled screenshots in Playwright reports [superset]

Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on code in PR #34561:
URL: https://github.com/apache/superset/pull/34561#discussion_r2257956826


##########
pyproject.toml:
##########
@@ -79,6 +79,7 @@ dependencies = [
     "parsedatetime",
     "paramiko>=3.4.0",
     "pgsanity",
+    "Pillow==11.3.0",

Review Comment:
   I think `>=11, <12` sounds good. I think there was some discussion a while back to try to avoid having upper bounds, as it restricts dependabot. So maybe just `>=11.3.0` is ok (people should be using lock files in prod anyway..)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Tiled screenshots in Playwright reports [superset]

Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on code in PR #34561:
URL: https://github.com/apache/superset/pull/34561#discussion_r2260910845


##########
pyproject.toml:
##########
@@ -181,7 +182,6 @@ tdengine = [
     "taos-ws-py>=0.3.8"
 ]
 teradata = ["teradatasql>=16.20.0.23"]
-thumbnails = ["Pillow>=10.0.1, <11"]

Review Comment:
   @kgabryje one last request: can we add a deprecation notice here so we can remove this in the next breaking window? I assume the removal will happen for 7.0.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Tiled screenshots in Playwright reports [superset]

Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on code in PR #34561:
URL: https://github.com/apache/superset/pull/34561#discussion_r2257938255


##########
pyproject.toml:
##########
@@ -181,7 +182,7 @@ tdengine = [
     "taos-ws-py>=0.3.8"
 ]
 teradata = ["teradatasql>=16.20.0.23"]
-thumbnails = ["Pillow>=10.0.1, <11"]
+thumbnails = ["Pillow>=10.0.1, <12"]

Review Comment:
   Good point, I'll delete it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Tiled screenshots in Playwright reports [superset]

Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on PR #34561:
URL: https://github.com/apache/superset/pull/34561#issuecomment-3177842353

   > LGTM, thanks for the fix, and happy for you to finally get closure on this issue πŸ˜†
   
   Now I won’t go bald from scratching my head about this πŸ˜„ 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Tiled screenshots in Playwright reports [superset]

Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #34561:
URL: https://github.com/apache/superset/pull/34561#discussion_r2255323098


##########
pyproject.toml:
##########
@@ -71,6 +71,7 @@ dependencies = [
     "nh3>=0.2.11, <0.3",
     "numpy>1.23.5, <2.3",
     "packaging",
+    "Pillow==10.3.0",

Review Comment:
   nit: it's not alphabetical, but should this be sorted alphabetically?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Tiled screenshots in Playwright reports [superset]

Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on code in PR #34561:
URL: https://github.com/apache/superset/pull/34561#discussion_r2257972253


##########
pyproject.toml:
##########
@@ -181,7 +182,6 @@ tdengine = [
     "taos-ws-py>=0.3.8"
 ]
 teradata = ["teradatasql>=16.20.0.23"]
-thumbnails = ["Pillow>=10.0.1, <11"]

Review Comment:
   I think it is a breaking change but we're kind of are in a breaking window based on @rusackas' [email](https://lists.apache.org/thread/pmb6z6lspt4322nonm8vrc1h8gxfdpb1)?. I'm not the release manager for 6.0 so @sadpandajoe @rusackas will probably know if we still are in a breaking window or not.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Tiled screenshots in Playwright reports [superset]

Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on code in PR #34561:
URL: https://github.com/apache/superset/pull/34561#discussion_r2257963717


##########
pyproject.toml:
##########
@@ -181,7 +182,6 @@ tdengine = [
     "taos-ws-py>=0.3.8"
 ]
 teradata = ["teradatasql>=16.20.0.23"]
-thumbnails = ["Pillow>=10.0.1, <11"]

Review Comment:
   @michael-s-molina is the removal of an optional dependency considered a breaking change? As `Pillow` is hereby promoted to a hard dependency, do we need to leave the `thumbnails` optional dependency empty until the breaking window?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Tiled screenshots in Playwright reports [superset]

Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on code in PR #34561:
URL: https://github.com/apache/superset/pull/34561#discussion_r2257937521


##########
pyproject.toml:
##########
@@ -79,6 +79,7 @@ dependencies = [
     "parsedatetime",
     "paramiko>=3.4.0",
     "pgsanity",
+    "Pillow==11.3.0",

Review Comment:
   We can use range >=11, <12. We should use at least 11, as in versions <=10 they used a different license



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Tiled screenshots in Playwright reports [superset]

Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on code in PR #34561:
URL: https://github.com/apache/superset/pull/34561#discussion_r2255147109


##########
superset/utils/screenshot_utils.py:
##########
@@ -0,0 +1,179 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from __future__ import annotations
+
+import io
+import logging
+from typing import TYPE_CHECKING
+
+from PIL import Image
+
+logger = logging.getLogger(__name__)
+
+if TYPE_CHECKING:
+    try:
+        from playwright.sync_api import Page
+    except ImportError:
+        Page = None
+
+
+def combine_screenshot_tiles(screenshot_tiles: list[bytes]) -> bytes:
+    """
+    Combine multiple screenshot tiles into a single vertical image.
+
+    Args:
+        screenshot_tiles: List of screenshot bytes in PNG format
+
+    Returns:
+        Combined screenshot as bytes
+    """
+    if not screenshot_tiles:
+        return b""
+
+    if len(screenshot_tiles) == 1:
+        return screenshot_tiles[0]
+
+    try:
+        # Open all images
+        images = [Image.open(io.BytesIO(tile)) for tile in screenshot_tiles]
+
+        # Calculate total dimensions
+        total_width = max(img.width for img in images)
+        total_height = sum(img.height for img in images)
+
+        # Create combined image
+        combined = Image.new("RGB", (total_width, total_height), "white")
+
+        # Paste each tile
+        y_offset = 0
+        for img in images:
+            combined.paste(img, (0, y_offset))
+            y_offset += img.height
+
+        # Convert back to bytes
+        output = io.BytesIO()
+        combined.save(output, format="PNG")
+        return output.getvalue()
+
+    except Exception as e:
+        logger.exception(f"Failed to combine screenshot tiles: {e}")
+        # Return the first tile as fallback
+        return screenshot_tiles[0]
+
+
+def take_tiled_screenshot(
+    page: "Page", element_name: str, viewport_height: int = 2000
+) -> bytes | None:
+    """
+    Take a tiled screenshot of a large dashboard by scrolling and capturing sections.
+
+    Args:
+        page: Playwright page object
+        element_name: CSS class name of the element to screenshot
+        viewport_height: Height of each tile in pixels
+
+    Returns:
+        Combined screenshot bytes or None if failed
+    """
+    try:
+        # Get the target element
+        element = page.locator(f".{element_name}")
+        element.wait_for(timeout=30000)  # 30 second timeout
+
+        # Get dashboard dimensions and position
+        element_info = page.evaluate(f"""() => {{
+            const el = document.querySelector(".{element_name}");
+            const rect = el.getBoundingClientRect();
+            return {{
+                height: el.scrollHeight,
+                top: rect.top + window.scrollY,
+                left: rect.left + window.scrollX,
+                width: el.scrollWidth
+            }};
+        }}""")

Review Comment:
   ### Redundant JavaScript evaluations <sub>![category Performance](https://img.shields.io/badge/Performance-4f46e5)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   Multiple separate JavaScript evaluations are performed for similar DOM queries, causing unnecessary browser-Python communication overhead.
   
   
   ###### Why this matters
   Each evaluation requires a context switch between Python and the browser's JavaScript engine, adding latency to the screenshot process.
   
   ###### Suggested change βˆ™ *Feature Preview*
   Combine related JavaScript operations into a single evaluation call:
   ```python
   element_info = page.evaluate(f"""() => {{
       const el = document.querySelector(".{element_name}");
       const initialRect = el.getBoundingClientRect();
       const dimensions = {{
           height: el.scrollHeight,
           width: el.scrollWidth,
           positions: []
       }};
       // Calculate all positions in one go
       for(let i = 0; i < numTiles; i++) {{
           // Add position calculations here
       }}
       return dimensions;
   }}""")
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice Catch](https://img.shields.io/badge/πŸ‘%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/aab3a102-fced-4767-99ba-b3676caf871e/upvote) [![Incorrect](https://img.shields.io/badge/πŸ‘Ž%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/aab3a102-fced-4767-99ba-b3676caf871e?what_not_true=true)  [![Not in Scope](https://img.shields.io/badge/πŸ‘Ž%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/aab3a102-fced-4767-99ba-b3676caf871e?what_out_of_scope=true) [![Not in coding standard](https://img.shields.io/badge/πŸ‘Ž%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/aab3a102-fced-4767-99ba-b3676caf871e?what_not_in_standard=true) [![Other](https://img.shields.io/badge/πŸ‘Ž%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/aab3a102-fced-4767-99ba-b3676caf871e)
   </details>
   
   <sub>
   
   πŸ’¬ Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:1ee10e21-f9a3-4cff-bbae-e63b96d65b11 -->
   
   
   [](1ee10e21-f9a3-4cff-bbae-e63b96d65b11)



##########
superset/utils/screenshot_utils.py:
##########
@@ -0,0 +1,179 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from __future__ import annotations
+
+import io
+import logging
+from typing import TYPE_CHECKING
+
+from PIL import Image
+
+logger = logging.getLogger(__name__)
+
+if TYPE_CHECKING:
+    try:
+        from playwright.sync_api import Page
+    except ImportError:
+        Page = None
+
+
+def combine_screenshot_tiles(screenshot_tiles: list[bytes]) -> bytes:
+    """
+    Combine multiple screenshot tiles into a single vertical image.
+
+    Args:
+        screenshot_tiles: List of screenshot bytes in PNG format
+
+    Returns:
+        Combined screenshot as bytes
+    """
+    if not screenshot_tiles:
+        return b""
+
+    if len(screenshot_tiles) == 1:
+        return screenshot_tiles[0]
+
+    try:
+        # Open all images
+        images = [Image.open(io.BytesIO(tile)) for tile in screenshot_tiles]

Review Comment:
   ### Memory-intensive batch image loading <sub>![category Performance](https://img.shields.io/badge/Performance-4f46e5)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   Loading all image tiles into memory simultaneously using a list comprehension could consume significant memory for large dashboards with many tiles.
   
   
   ###### Why this matters
   For dashboards with many tiles, this approach could lead to memory spikes and potential out-of-memory errors on systems with limited resources.
   
   ###### Suggested change βˆ™ *Feature Preview*
   Process images sequentially or in smaller batches. Consider using a generator pattern:
   ```python
   def process_tiles(tiles):
       for tile in tiles:
           yield Image.open(io.BytesIO(tile))
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice Catch](https://img.shields.io/badge/πŸ‘%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/01ab87c1-4822-44d8-9bf0-aa61280d437e/upvote) [![Incorrect](https://img.shields.io/badge/πŸ‘Ž%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/01ab87c1-4822-44d8-9bf0-aa61280d437e?what_not_true=true)  [![Not in Scope](https://img.shields.io/badge/πŸ‘Ž%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/01ab87c1-4822-44d8-9bf0-aa61280d437e?what_out_of_scope=true) [![Not in coding standard](https://img.shields.io/badge/πŸ‘Ž%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/01ab87c1-4822-44d8-9bf0-aa61280d437e?what_not_in_standard=true) [![Other](https://img.shields.io/badge/πŸ‘Ž%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/01ab87c1-4822-44d8-9bf0-aa61280d437e)
   </details>
   
   <sub>
   
   πŸ’¬ Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:d99f1898-5814-4296-8bb0-ce100568353d -->
   
   
   [](d99f1898-5814-4296-8bb0-ce100568353d)



##########
superset/utils/screenshot_utils.py:
##########
@@ -0,0 +1,179 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+from __future__ import annotations
+
+import io
+import logging
+from typing import TYPE_CHECKING
+
+from PIL import Image
+
+logger = logging.getLogger(__name__)
+
+if TYPE_CHECKING:
+    try:
+        from playwright.sync_api import Page
+    except ImportError:
+        Page = None
+
+
+def combine_screenshot_tiles(screenshot_tiles: list[bytes]) -> bytes:
+    """
+    Combine multiple screenshot tiles into a single vertical image.
+
+    Args:
+        screenshot_tiles: List of screenshot bytes in PNG format
+
+    Returns:
+        Combined screenshot as bytes
+    """
+    if not screenshot_tiles:
+        return b""
+
+    if len(screenshot_tiles) == 1:
+        return screenshot_tiles[0]
+
+    try:
+        # Open all images
+        images = [Image.open(io.BytesIO(tile)) for tile in screenshot_tiles]
+
+        # Calculate total dimensions
+        total_width = max(img.width for img in images)
+        total_height = sum(img.height for img in images)
+
+        # Create combined image
+        combined = Image.new("RGB", (total_width, total_height), "white")
+
+        # Paste each tile
+        y_offset = 0
+        for img in images:
+            combined.paste(img, (0, y_offset))
+            y_offset += img.height
+
+        # Convert back to bytes
+        output = io.BytesIO()
+        combined.save(output, format="PNG")
+        return output.getvalue()
+
+    except Exception as e:
+        logger.exception(f"Failed to combine screenshot tiles: {e}")
+        # Return the first tile as fallback
+        return screenshot_tiles[0]
+
+
+def take_tiled_screenshot(
+    page: "Page", element_name: str, viewport_height: int = 2000
+) -> bytes | None:
+    """
+    Take a tiled screenshot of a large dashboard by scrolling and capturing sections.
+
+    Args:
+        page: Playwright page object
+        element_name: CSS class name of the element to screenshot
+        viewport_height: Height of each tile in pixels
+
+    Returns:
+        Combined screenshot bytes or None if failed
+    """
+    try:
+        # Get the target element
+        element = page.locator(f".{element_name}")
+        element.wait_for(timeout=30000)  # 30 second timeout
+
+        # Get dashboard dimensions and position
+        element_info = page.evaluate(f"""() => {{
+            const el = document.querySelector(".{element_name}");

Review Comment:
   ### JavaScript injection vulnerability in element selector <sub>![category Security](https://img.shields.io/badge/Security-e11d48)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   Direct interpolation of user input (element_name) into JavaScript code which could allow for XSS attacks if element_name is not properly validated.
   
   
   ###### Why this matters
   An attacker could inject malicious JavaScript code through the element_name parameter that would be executed in the browser context, potentially compromising the application or user data.
   
   ###### Suggested change βˆ™ *Feature Preview*
   Use Playwright's built-in selector escaping mechanisms or validate element_name to ensure it only contains valid CSS class characters:
   ```python
   # Add validation before use
   if not re.match(r'^[a-zA-Z0-9_-]+$', element_name):
       raise ValueError('Invalid element_name')
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice Catch](https://img.shields.io/badge/πŸ‘%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/43395f2f-79b6-4f48-858e-f50810436b13/upvote) [![Incorrect](https://img.shields.io/badge/πŸ‘Ž%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/43395f2f-79b6-4f48-858e-f50810436b13?what_not_true=true)  [![Not in Scope](https://img.shields.io/badge/πŸ‘Ž%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/43395f2f-79b6-4f48-858e-f50810436b13?what_out_of_scope=true) [![Not in coding standard](https://img.shields.io/badge/πŸ‘Ž%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/43395f2f-79b6-4f48-858e-f50810436b13?what_not_in_standard=true) [![Other](https://img.shields.io/badge/πŸ‘Ž%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/43395f2f-79b6-4f48-858e-f50810436b13)
   </details>
   
   <sub>
   
   πŸ’¬ Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:6fdffe6e-27d0-4867-9426-928ab7fcc2ea -->
   
   
   [](6fdffe6e-27d0-4867-9426-928ab7fcc2ea)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Tiled screenshots in Playwright reports [superset]

Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on code in PR #34561:
URL: https://github.com/apache/superset/pull/34561#discussion_r2257972253


##########
pyproject.toml:
##########
@@ -181,7 +182,6 @@ tdengine = [
     "taos-ws-py>=0.3.8"
 ]
 teradata = ["teradatasql>=16.20.0.23"]
-thumbnails = ["Pillow>=10.0.1, <11"]

Review Comment:
   I think it is a breaking change but we kind of are in a breaking window based on @rusackas' [email](https://lists.apache.org/thread/pmb6z6lspt4322nonm8vrc1h8gxfdpb1)?. I'm not the release manager for 6.0 so @sadpandajoe @rusackas will probably know if we still are in a breaking window or not.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Tiled screenshots in Playwright reports [superset]

Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on code in PR #34561:
URL: https://github.com/apache/superset/pull/34561#discussion_r2262640027


##########
pyproject.toml:
##########
@@ -181,7 +182,6 @@ tdengine = [
     "taos-ws-py>=0.3.8"
 ]
 teradata = ["teradatasql>=16.20.0.23"]
-thumbnails = ["Pillow>=10.0.1, <11"]

Review Comment:
   @villebro Done πŸ™‚ 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Tiled screenshots in Playwright reports [superset]

Posted by "Syam9290 (via GitHub)" <gi...@apache.org>.
Syam9290 commented on PR #34561:
URL: https://github.com/apache/superset/pull/34561#issuecomment-4074519998

   
   Hi @kgabryje ,
    thanks for the update on this PR β€” I’m now able to schedule reports without any issues.
   However, I’m facing a problem with the tiling screenshot method. In the generated reports, the tab titles are not showing up in the screenshots.
   Could you please let me know if this is a known issue or if there’s a way to fix or configure this?
   For context, I’m currently using Superset 6.
   Thanks in advance for your help!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Tiled screenshots in Playwright reports [superset]

Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #34561:
URL: https://github.com/apache/superset/pull/34561#discussion_r2255320350


##########
superset/config.py:
##########
@@ -865,6 +865,14 @@ class D3TimeFormat(TypedDict, total=False):
     timedelta(seconds=60).total_seconds() * 1000
 )
 
+# Tiled screenshot configuration for large dashboards
+SCREENSHOT_TILED_ENABLED = True  # Enable tiled screenshots for large dashboards
+SCREENSHOT_TILED_CHART_THRESHOLD = 20  # Minimum charts to trigger tiled screenshots
+SCREENSHOT_TILED_HEIGHT_THRESHOLD = (

Review Comment:
   does this affect the screenshots for alerts/reports? I believe there is a way to trigger a min/max height and width.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Tiled screenshots in Playwright reports [superset]

Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on code in PR #34561:
URL: https://github.com/apache/superset/pull/34561#discussion_r2256348171


##########
superset/config.py:
##########
@@ -865,6 +865,14 @@ class D3TimeFormat(TypedDict, total=False):
     timedelta(seconds=60).total_seconds() * 1000
 )
 
+# Tiled screenshot configuration for large dashboards
+SCREENSHOT_TILED_ENABLED = True  # Enable tiled screenshots for large dashboards
+SCREENSHOT_TILED_CHART_THRESHOLD = 20  # Minimum charts to trigger tiled screenshots
+SCREENSHOT_TILED_HEIGHT_THRESHOLD = (

Review Comment:
   Yes it's for alerts/reports. We can set viewport width in report creation modal, and height can be set in config.py.
   This however is an optimization for large dashboards - if dashboard is longer than `SCREENSHOT_TILED_HEIGHT_THRESHOLD`, then we use tiled screenshots. Tiled screenshots mean that instead of screenshotting the entire dashboard (i.e. the `.standalone` element), we screenshot only a fragment (`SCREENSHOT_TILED_VIEWPORT_HEIGHT`) multiple times.
   For example, if the dashboard has height 10000px, and `SCREENSHOT_TILED_VIEWPORT_HEIGHT` is 3000, we take 3 3000px screenshots and 1 1000px screenshot and glue them together into 1 10000px image.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Tiled screenshots in Playwright reports [superset]

Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on code in PR #34561:
URL: https://github.com/apache/superset/pull/34561#discussion_r2259771480


##########
pyproject.toml:
##########
@@ -181,7 +182,6 @@ tdengine = [
     "taos-ws-py>=0.3.8"
 ]
 teradata = ["teradatasql>=16.20.0.23"]
-thumbnails = ["Pillow>=10.0.1, <11"]

Review Comment:
   @michael-s-molina @villebro According to @rusackas email we're not accepting new breaking changes now, so I set `thumbnails = []` in `pyproject.toml`.
   Also added an entry in `UPDATING.md`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Tiled screenshots in Playwright reports [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #34561:
URL: https://github.com/apache/superset/pull/34561#issuecomment-3156346527

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/34561?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `15.18987%` with `67 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 72.22%. Comparing base ([`407fb67`](https://app.codecov.io/gh/apache/superset/commit/407fb67f1e17507bc5eac808ba704892ad062e5c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0acda42`](https://app.codecov.io/gh/apache/superset/commit/0acda425201c620ccd6d15bb20a5855b905e8189?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 2 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/34561?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [superset/utils/screenshot\_utils.py](https://app.codecov.io/gh/apache/superset/pull/34561?src=pr&el=tree&filepath=superset%2Futils%2Fscreenshot_utils.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdXRpbHMvc2NyZWVuc2hvdF91dGlscy5weQ==) | 13.55% | [51 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/34561?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [superset/utils/webdriver.py](https://app.codecov.io/gh/apache/superset/pull/34561?src=pr&el=tree&filepath=superset%2Futils%2Fwebdriver.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdXRpbHMvd2ViZHJpdmVyLnB5) | 5.88% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/34561?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #34561       +/-   ##
   ===========================================
   + Coverage        0   72.22%   +72.22%     
   ===========================================
     Files           0      573      +573     
     Lines           0    41478    +41478     
     Branches        0     4369     +4369     
   ===========================================
   + Hits            0    29958    +29958     
   - Misses          0    10353    +10353     
   - Partials        0     1167     +1167     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/34561/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ” | |
   |---|---|---|
   | [hive](https://app.codecov.io/gh/apache/superset/pull/34561/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.08% <15.18%> (?)` | |
   | [postgres](https://app.codecov.io/gh/apache/superset/pull/34561/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `71.84% <15.18%> (?)` | |
   | [presto](https://app.codecov.io/gh/apache/superset/pull/34561/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `50.78% <15.18%> (?)` | |
   | [python](https://app.codecov.io/gh/apache/superset/pull/34561/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.19% <15.18%> (?)` | |
   | [sqlite](https://app.codecov.io/gh/apache/superset/pull/34561/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `71.40% <15.18%> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/34561?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Tiled screenshots in Playwright reports [superset]

Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje merged PR #34561:
URL: https://github.com/apache/superset/pull/34561


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Tiled screenshots in Playwright reports [superset]

Posted by "udayv2000 (via GitHub)" <gi...@apache.org>.
udayv2000 commented on PR #34561:
URL: https://github.com/apache/superset/pull/34561#issuecomment-3907591543

   is this feature  available in the latest docker image 6.0.0 or 6.0.1rc 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Tiled screenshots in Playwright reports [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #34561:
URL: https://github.com/apache/superset/pull/34561#issuecomment-3164885802

   > Side note - the "After" screenshot looks normal on my email, Github must have squished it for some reason πŸ™‚
   
   Yep... there's some max height. It's annoying.
   
   Thanks for this PR, this is a very important one, and closes quite a few issues!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Tiled screenshots in Playwright reports [superset]

Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on code in PR #34561:
URL: https://github.com/apache/superset/pull/34561#discussion_r2256322650


##########
pyproject.toml:
##########
@@ -71,6 +71,7 @@ dependencies = [
     "nh3>=0.2.11, <0.3",
     "numpy>1.23.5, <2.3",
     "packaging",
+    "Pillow==10.3.0",

Review Comment:
   Oh well spotted



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Tiled screenshots in Playwright reports [superset]

Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on code in PR #34561:
URL: https://github.com/apache/superset/pull/34561#discussion_r2257973779


##########
pyproject.toml:
##########
@@ -181,7 +182,6 @@ tdengine = [
     "taos-ws-py>=0.3.8"
 ]
 teradata = ["teradatasql>=16.20.0.23"]
-thumbnails = ["Pillow>=10.0.1, <11"]

Review Comment:
   By the way, this PR might need something in `UPDATING.md`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Tiled screenshots in Playwright reports [superset]

Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on PR #34561:
URL: https://github.com/apache/superset/pull/34561#issuecomment-3156315756

   Side note - the "After" screenshot looks normal on my email, Github must have squished it for some reason πŸ™‚ 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Tiled screenshots in Playwright reports [superset]

Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #34561:
URL: https://github.com/apache/superset/pull/34561#issuecomment-3160625727

   Outstanding! This will close #29326


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Tiled screenshots in Playwright reports [superset]

Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on code in PR #34561:
URL: https://github.com/apache/superset/pull/34561#discussion_r2257884370


##########
pyproject.toml:
##########
@@ -181,7 +182,7 @@ tdengine = [
     "taos-ws-py>=0.3.8"
 ]
 teradata = ["teradatasql>=16.20.0.23"]
-thumbnails = ["Pillow>=10.0.1, <11"]
+thumbnails = ["Pillow>=10.0.1, <12"]

Review Comment:
   If `Pillow` is already a hard dependency as defined above, do we really need this option any more?



##########
pyproject.toml:
##########
@@ -79,6 +79,7 @@ dependencies = [
     "parsedatetime",
     "paramiko>=3.4.0",
     "pgsanity",
+    "Pillow==11.3.0",

Review Comment:
   Is there some reason we're pinning to 11.3.0, and not a range/lower bound?



##########
pyproject.toml:
##########
@@ -399,6 +400,7 @@ authorized_licenses = [
     "isc license (iscl)",
     "isc license",
     "mit",
+    "mit-cmu",

Review Comment:
   Did we check that this license is ok by ASF?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat: Tiled screenshots in Playwright reports [superset]

Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje commented on code in PR #34561:
URL: https://github.com/apache/superset/pull/34561#discussion_r2257934751


##########
pyproject.toml:
##########
@@ -399,6 +400,7 @@ authorized_licenses = [
     "isc license (iscl)",
     "isc license",
     "mit",
+    "mit-cmu",

Review Comment:
   Yes, according to Claude it's basically an MIT license:
   
   <img width="1255" height="811" alt="image" src="https://github.com/user-attachments/assets/dec1499d-e7fb-4c84-a840-9935280d3309" />
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org