You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/21 02:34:06 UTC

[GitHub] [apisix-dashboard] jwrookie commented on pull request #2330: fix(import routes): merge route when route have the same name

jwrookie commented on pull request #2330:
URL: https://github.com/apache/apisix-dashboard/pull/2330#issuecomment-1046413633


   > If we merge based on id, the bug described in issue cannot be fixed, the route with same name and different path value already assigned different id unless we cache id with route name, and if we meet same route name, we use the same id. but what's the different between this and merge directly with name ?
   
   I think both import and export should be done through `ID`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org