You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ca...@apache.org on 2020/09/10 17:03:05 UTC
[royale-asjs] branch develop updated: todomvc: better a
DataContainer than a List since we don't have selection or keyboard
handling, also don't need to change styles
This is an automated email from the ASF dual-hosted git repository.
carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new 3e018ce todomvc: better a DataContainer than a List since we don't have selection or keyboard handling, also don't need to change styles
3e018ce is described below
commit 3e018ce8c4b3e2533003d86f6e70ecc978c3f553
Author: Carlos Rovira <ca...@apache.org>
AuthorDate: Thu Sep 10 19:02:55 2020 +0200
todomvc: better a DataContainer than a List since we don't have selection or keyboard handling, also don't need to change styles
---
.../src/main/resources/todomvc-styles.css | 14 +-------------
.../main/royale/jewel/todomvc/views/TodoListSection.mxml | 2 +-
.../jewel/todomvc/src/main/resources/todomvc-styles.css | 14 +-------------
.../main/royale/jewel/todomvc/views/TodoListSection.mxml | 2 +-
4 files changed, 4 insertions(+), 28 deletions(-)
diff --git a/examples/crux/todomvc-jewel-crux/src/main/resources/todomvc-styles.css b/examples/crux/todomvc-jewel-crux/src/main/resources/todomvc-styles.css
index 3c1560c..69eec29 100644
--- a/examples/crux/todomvc-jewel-crux/src/main/resources/todomvc-styles.css
+++ b/examples/crux/todomvc-jewel-crux/src/main/resources/todomvc-styles.css
@@ -196,21 +196,9 @@
border: 1px solid darkgrey;
}
-/* List */
+/* Data Container */
.todo-list {
IItemRenderer: ClassReference("jewel.todomvc.renderers.TodoItemRenderer");
- /* disables selection visuals on renderers */
- IItemRendererClassFactory: ClassReference("org.apache.royale.core.ItemRendererClassFactory");
-}
-
-.jewel.list {
- border-radius: 0px;
- border: none;
- background: none;
-}
-
-.jewel.list:focus {
- border: 0px solid transparent;
}
/* ItemRenderer */
diff --git a/examples/crux/todomvc-jewel-crux/src/main/royale/jewel/todomvc/views/TodoListSection.mxml b/examples/crux/todomvc-jewel-crux/src/main/royale/jewel/todomvc/views/TodoListSection.mxml
index 3b39d49..28fa641 100644
--- a/examples/crux/todomvc-jewel-crux/src/main/royale/jewel/todomvc/views/TodoListSection.mxml
+++ b/examples/crux/todomvc-jewel-crux/src/main/royale/jewel/todomvc/views/TodoListSection.mxml
@@ -66,7 +66,7 @@ limitations under the License.
</html:Header>
<html:Section localId="main">
- <j:List localId="todolist" width="100%"
+ <j:DataContainer localId="todolist" width="100%"
labelField="label" className="todo-list"
dataProvider="{todoModel.listItems}"/>
</html:Section>
diff --git a/examples/jewel/todomvc/src/main/resources/todomvc-styles.css b/examples/jewel/todomvc/src/main/resources/todomvc-styles.css
index 5c2ef23..37d3887 100644
--- a/examples/jewel/todomvc/src/main/resources/todomvc-styles.css
+++ b/examples/jewel/todomvc/src/main/resources/todomvc-styles.css
@@ -207,21 +207,9 @@ todomvc|TodoListSection
border: 1px solid darkgrey;
}
-/* List */
+/* Data Container */
.todo-list {
IItemRenderer: ClassReference("jewel.todomvc.renderers.TodoItemRenderer");
- /* disables selection visuals on renderers */
- IItemRendererClassFactory: ClassReference("org.apache.royale.core.ItemRendererClassFactory");
-}
-
-.jewel.list {
- border-radius: 0px;
- border: none;
- background: none;
-}
-
-.jewel.list:focus {
- border: 0px solid transparent;
}
/* ItemRenderer */
diff --git a/examples/jewel/todomvc/src/main/royale/jewel/todomvc/views/TodoListSection.mxml b/examples/jewel/todomvc/src/main/royale/jewel/todomvc/views/TodoListSection.mxml
index 7fa5e62..d039f55 100644
--- a/examples/jewel/todomvc/src/main/royale/jewel/todomvc/views/TodoListSection.mxml
+++ b/examples/jewel/todomvc/src/main/royale/jewel/todomvc/views/TodoListSection.mxml
@@ -77,7 +77,7 @@ limitations under the License.
</html:Header>
<html:Section localId="main">
- <j:List localId="todolist" width="100%"
+ <j:DataContainer localId="todolist" width="100%"
labelField="label" className="todo-list"
dataProvider="{todoModel.listItems}"/>
</html:Section>