You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/04/29 15:57:41 UTC

[GitHub] [kafka] dajac commented on a diff in pull request #12056: MINOR:Fix typo in ReplicaManagerTest.scala

dajac commented on code in PR #12056:
URL: https://github.com/apache/kafka/pull/12056#discussion_r861938768


##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -2352,7 +2352,7 @@ class ReplicaManagerTest {
     val (rm0, rm1) = prepareDifferentReplicaManagers(mock(classOf[BrokerTopicStats]), mockTopicStats1)
 
     try {
-      // make broker 0 the leader of partition 0 and
+      // make broker 1 the leader of partition 0 and
       // make broker 1 the leader of partition 1

Review Comment:
   The original [commit](https://github.com/apache/kafka/commit/aa8e850afb7baa447882b493eae29f99a39e35a0) suggests that the comment is actually correct but we changed the leader by mistake afterwards. I suppose that we missed this while [refactoring](https://github.com/apache/kafka/commit/66183f730feaa7dca7b4088053f44015a626a6e8) this code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org