You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/08 10:52:43 UTC
[GitHub] [shardingsphere] lovepoem opened a new pull request #7711: add checkstyle for IDEA
lovepoem opened a new pull request #7711:
URL: https://github.com/apache/shardingsphere/pull/7711
fix https://github.com/apache/shardingsphere/issues/7694 to
add checkstyle for IDEA
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #7711: add checkstyle for IDEA
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #7711:
URL: https://github.com/apache/shardingsphere/pull/7711#issuecomment-705944511
@lovepoem Thanks, it looks like @terrymanu has the context of this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] lovepoem commented on pull request #7711: add checkstyle for IDEA
Posted by GitBox <gi...@apache.org>.
lovepoem commented on pull request #7711:
URL: https://github.com/apache/shardingsphere/pull/7711#issuecomment-705981541
> @lovepoem Thanks, it looks like @terrymanu has the context of this one.
Now I use the latest version of IDEA, It no longer supports [jar version style](https://shardingsphere.apache.org/community/en/contribute/code-conduct/)
But the file `checkstyle_for_IDEA.xml` ，It doesn't seem to work ：`Line breaks will be generated automatically`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #7711: add checkstyle for IDEA
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #7711:
URL: https://github.com/apache/shardingsphere/pull/7711#issuecomment-705944511
@lovepoem Thanks, it looks like @terrymanu has the context of this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #7711: add checkstyle for IDEA
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #7711:
URL: https://github.com/apache/shardingsphere/pull/7711#issuecomment-705535501
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7711?src=pr&el=h1) Report
> Merging [#7711](https://codecov.io/gh/apache/shardingsphere/pull/7711?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/042cd9444484e546a36510a4a059e2300a39d688?el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/7711?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7711 +/- ##
=========================================
Coverage 32.82% 32.83%
Complexity 2378 2378
=========================================
Files 1411 1412 +1
Lines 104672 104693 +21
Branches 9464 9477 +13
=========================================
+ Hits 34358 34375 +17
- Misses 67632 67636 +4
Partials 2682 2682
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/7711?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...re/scaling/core/schedule/ScalingTaskScheduler.java](https://codecov.io/gh/apache/shardingsphere/pull/7711/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9zY2hlZHVsZS9TY2FsaW5nVGFza1NjaGVkdWxlci5qYXZh) | `78.00% <0.00%> (-2.00%)` | `0.00% <0.00%> (ø%)` | |
| [...re/sharding/route/datatime/TimeServiceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/7711/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2RhdGF0aW1lL1RpbWVTZXJ2aWNlRmFjdG9yeS5qYXZh) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...erator/impl/ConditionValueInOperatorGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/7711/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS9jb25kaXRpb24vZ2VuZXJhdG9yL2ltcGwvQ29uZGl0aW9uVmFsdWVJbk9wZXJhdG9yR2VuZXJhdG9yLmphdmE=) | `87.50% <0.00%> (+4.16%)` | `0.00% <0.00%> (ø%)` | |
| [...gine/impl/InsertClauseShardingConditionEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/7711/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS9jb25kaXRpb24vZW5naW5lL2ltcGwvSW5zZXJ0Q2xhdXNlU2hhcmRpbmdDb25kaXRpb25FbmdpbmUuamF2YQ==) | `57.81% <0.00%> (+5.81%)` | `9.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7711?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7711?src=pr&el=footer). Last update [042cd94...4dc848c](https://codecov.io/gh/apache/shardingsphere/pull/7711?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-io commented on pull request #7711: add checkstyle for IDEA
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #7711:
URL: https://github.com/apache/shardingsphere/pull/7711#issuecomment-705535501
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7711?src=pr&el=h1) Report
> Merging [#7711](https://codecov.io/gh/apache/shardingsphere/pull/7711?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/042cd9444484e546a36510a4a059e2300a39d688?el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/7711?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7711 +/- ##
=========================================
Coverage 32.82% 32.83%
Complexity 2378 2378
=========================================
Files 1411 1412 +1
Lines 104672 104693 +21
Branches 9464 9477 +13
=========================================
+ Hits 34358 34375 +17
- Misses 67632 67636 +4
Partials 2682 2682
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/7711?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...re/scaling/core/schedule/ScalingTaskScheduler.java](https://codecov.io/gh/apache/shardingsphere/pull/7711/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9zY2hlZHVsZS9TY2FsaW5nVGFza1NjaGVkdWxlci5qYXZh) | `78.00% <0.00%> (-2.00%)` | `0.00% <0.00%> (ø%)` | |
| [...re/sharding/route/datatime/TimeServiceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/7711/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2RhdGF0aW1lL1RpbWVTZXJ2aWNlRmFjdG9yeS5qYXZh) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...erator/impl/ConditionValueInOperatorGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/7711/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS9jb25kaXRpb24vZ2VuZXJhdG9yL2ltcGwvQ29uZGl0aW9uVmFsdWVJbk9wZXJhdG9yR2VuZXJhdG9yLmphdmE=) | `87.50% <0.00%> (+4.16%)` | `0.00% <0.00%> (ø%)` | |
| [...gine/impl/InsertClauseShardingConditionEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/7711/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS9jb25kaXRpb24vZW5naW5lL2ltcGwvSW5zZXJ0Q2xhdXNlU2hhcmRpbmdDb25kaXRpb25FbmdpbmUuamF2YQ==) | `57.81% <0.00%> (+5.81%)` | `9.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7711?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7711?src=pr&el=footer). Last update [042cd94...4dc848c](https://codecov.io/gh/apache/shardingsphere/pull/7711?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] lovepoem closed pull request #7711: add checkstyle for IDEA
Posted by GitBox <gi...@apache.org>.
lovepoem closed pull request #7711:
URL: https://github.com/apache/shardingsphere/pull/7711
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] lovepoem commented on pull request #7711: add checkstyle for IDEA
Posted by GitBox <gi...@apache.org>.
lovepoem commented on pull request #7711:
URL: https://github.com/apache/shardingsphere/pull/7711#issuecomment-706490270
It's better to use https://shardingsphere.apache.org/community/en/contribute/code-conduct/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] lovepoem edited a comment on pull request #7711: add checkstyle for IDEA
Posted by GitBox <gi...@apache.org>.
lovepoem edited a comment on pull request #7711:
URL: https://github.com/apache/shardingsphere/pull/7711#issuecomment-705981541
> @lovepoem Thanks, it looks like @terrymanu has the context of this one.
Now I use the latest version of IDEA, It no longer supports [jar version style](https://shardingsphere.apache.org/community/en/contribute/code-conduct/)
The cxontent of file `checkstyle_for_IDEA.xml` is the same as `Default _1_.xml`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] lovepoem edited a comment on pull request #7711: add checkstyle for IDEA
Posted by GitBox <gi...@apache.org>.
lovepoem edited a comment on pull request #7711:
URL: https://github.com/apache/shardingsphere/pull/7711#issuecomment-705981541
> @lovepoem Thanks, it looks like @terrymanu has the context of this one.
Now I use the latest version of IDEA, It no longer supports [jar version style](https://shardingsphere.apache.org/community/en/contribute/code-conduct/)
The cxontent of file `checkstyle_for_IDEA.xml` is the same as `Default _1_.xml`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] lovepoem commented on pull request #7711: add checkstyle for IDEA
Posted by GitBox <gi...@apache.org>.
lovepoem commented on pull request #7711:
URL: https://github.com/apache/shardingsphere/pull/7711#issuecomment-705981541
> @lovepoem Thanks, it looks like @terrymanu has the context of this one.
Now I use the latest version of IDEA, It no longer supports [jar version style](https://shardingsphere.apache.org/community/en/contribute/code-conduct/)
But the file `checkstyle_for_IDEA.xml` ，It doesn't seem to work ：`Line breaks will be generated automatically`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org