You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Mike Percy (Code Review)" <ge...@ip-10-146-233-104.ec2.internal> on 2016/02/11 19:00:47 UTC

[kudu-CR] Specify full RUNPATH for thirdparty libs for compat with GNU gold

Hello Adar Dembo, Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/2123

to review the following change.

Change subject: Specify full RUNPATH for thirdparty libs for compat with GNU gold
......................................................................

Specify full RUNPATH for thirdparty libs for compat with GNU gold

Make sure that thirdparty shared libs are built with a RUNPATH that
includes thirdparty/installed-deps* because the GNU gold linker
specifies RUNPATH by default, instead of RPATH. Unfortunately, glibc
does not search an executable's RUNPATH for transitive dependencies [1],
like it does for RPATH. This results in symbol not found errors for full
builds done using gold as the linker unless we apply this change.

[1] https://sourceware.org/bugzilla/show_bug.cgi?id=13945

Change-Id: Ic50b3667f96cec73497248751e9afc785e3f7979
---
M thirdparty/build-thirdparty.sh
1 file changed, 12 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/2123/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic50b3667f96cec73497248751e9afc785e3f7979
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>