You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2015/09/18 19:19:04 UTC
Review Request 38499: Tests for executor endpoint on agent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38499/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
Bugs: MESOS-2907
https://issues.apache.org/jira/browse/MESOS-2907
Repository: mesos
Description
-------
This change introduces basic validation tests for the Executor HTTP endpoint on Agent.
Diffs
-----
src/Makefile.am 834f69afe87a093c6d275916f7781d470535a728
src/tests/executor_http_api_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/38499/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 38499: Tests for executor endpoint on agent
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38499/#review99584
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38496, 38497, 38499]
All tests passed.
- Mesos ReviewBot
On Sept. 18, 2015, 5:19 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38499/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 5:19 p.m.)
>
>
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
>
>
> Bugs: MESOS-2907
> https://issues.apache.org/jira/browse/MESOS-2907
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change introduces basic validation tests for the Executor HTTP endpoint on Agent.
>
>
> Diffs
> -----
>
> src/Makefile.am 834f69afe87a093c6d275916f7781d470535a728
> src/tests/executor_http_api_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38499/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 38499: Tests for executor endpoint on agent
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38499/#review99833
-----------------------------------------------------------
Ship it!
src/tests/executor_http_api_tests.cpp (line 79)
<https://reviews.apache.org/r/38499/#comment156813>
s/then/than/
src/tests/executor_http_api_tests.cpp (line 295)
<https://reviews.apache.org/r/38499/#comment156815>
s/json/JSON/
src/tests/executor_http_api_tests.cpp (line 340)
<https://reviews.apache.org/r/38499/#comment156816>
s/json/JSON/
src/tests/executor_http_api_tests.cpp (line 361)
<https://reviews.apache.org/r/38499/#comment156817>
s/a non-supported/an un-supported/
- Vinod Kone
On Sept. 18, 2015, 5:19 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38499/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 5:19 p.m.)
>
>
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
>
>
> Bugs: MESOS-2907
> https://issues.apache.org/jira/browse/MESOS-2907
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change introduces basic validation tests for the Executor HTTP endpoint on Agent.
>
>
> Diffs
> -----
>
> src/Makefile.am 834f69afe87a093c6d275916f7781d470535a728
> src/tests/executor_http_api_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38499/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 38499: Added tests for executor endpoint on agent
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38499/
-----------------------------------------------------------
(Updated Sept. 21, 2015, 9:54 p.m.)
Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
Changes
-------
Changed summary
Summary (updated)
-----------------
Added tests for executor endpoint on agent
Bugs: MESOS-2907
https://issues.apache.org/jira/browse/MESOS-2907
Repository: mesos
Description
-------
This change introduces basic validation tests for the Executor HTTP endpoint on Agent.
Diffs
-----
src/Makefile.am 834f69afe87a093c6d275916f7781d470535a728
src/tests/executor_http_api_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/38499/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 38499: Tests for executor endpoint on agent
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38499/
-----------------------------------------------------------
(Updated Sept. 21, 2015, 9:53 p.m.)
Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
Changes
-------
Review comments from Vinod
Bugs: MESOS-2907
https://issues.apache.org/jira/browse/MESOS-2907
Repository: mesos
Description
-------
This change introduces basic validation tests for the Executor HTTP endpoint on Agent.
Diffs (updated)
-----
src/Makefile.am 834f69afe87a093c6d275916f7781d470535a728
src/tests/executor_http_api_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/38499/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 38499: Tests for executor endpoint on agent
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38499/#review99789
-----------------------------------------------------------
Ship it!
Ship It!
- Isabel Jimenez
On Sept. 18, 2015, 5:19 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38499/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 5:19 p.m.)
>
>
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
>
>
> Bugs: MESOS-2907
> https://issues.apache.org/jira/browse/MESOS-2907
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change introduces basic validation tests for the Executor HTTP endpoint on Agent.
>
>
> Diffs
> -----
>
> src/Makefile.am 834f69afe87a093c6d275916f7781d470535a728
> src/tests/executor_http_api_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38499/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>