You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2022/07/22 04:10:17 UTC
[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1181: Remove unuseful toString method
dongjoon-hyun commented on code in PR #1181:
URL: https://github.com/apache/orc/pull/1181#discussion_r927271847
##########
java/tools/src/java/org/apache/orc/tools/FileDump.java:
##########
@@ -103,7 +103,7 @@ public static void main(Configuration conf, String[] args) throws Exception {
rowIndexCols = null; // All the columns
} else {
String[] colStrs = cli.getOptionValue("r").split(",");
- rowIndexCols = new ArrayList<Integer>(colStrs.length);
Review Comment:
The same mistake like https://github.com/apache/orc/pull/1181#discussion_r924633593
##########
java/tools/src/java/org/apache/orc/tools/FileDump.java:
##########
@@ -119,7 +119,7 @@ public static void main(Configuration conf, String[] args) throws Exception {
}
// if the specified path is directory, iterate through all files and print the file dump
- List<String> filesInPath = new ArrayList<>();
Review Comment:
The same mistake like https://github.com/apache/orc/pull/1181#discussion_r924633593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org