You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@yunikorn.apache.org by "Peter Bacsko (Jira)" <ji...@apache.org> on 2023/07/18 11:02:00 UTC

[jira] [Created] (YUNIKORN-1872) Fix depguard configuration in core

Peter Bacsko created YUNIKORN-1872:
--------------------------------------

             Summary: Fix depguard configuration in core
                 Key: YUNIKORN-1872
                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1872
             Project: Apache YuniKorn
          Issue Type: Bug
          Components: core - scheduler
            Reporter: Peter Bacsko
            Assignee: Peter Bacsko


The latest golangcli-lint uses depguard v1.4.0 (based on the latest [https://golangci-lint.run/usage/linters/).]

The configuration of depguard seems to have changed. Now it complains about using "github.com/google/btree":
{noformat}
~/repos/yunikorn-core$ make lint
running golangci-lint
refs/heads/YUNIKORN-1716-BtreeWalk
checking against commit sha 06d4089638e6
WARN [runner/nolint] Found unknown linters in //nolint directives: todo assess impact of partition metrics (this never hit the partition), todo test cases for different applications each with different group linkage 
pkg/scheduler/objects/node_iterator.go:22:2: import 'github.com/google/btree' is not allowed from list 'main' (depguard)
    "github.com/google/btree"
    ^
pkg/scheduler/objects/common_test.go:20:2: import 'github.com/google/btree' is not allowed from list 'main' (depguard)
    "github.com/google/btree"
    ^
pkg/scheduler/objects/node_iterator_test.go:25:2: import 'github.com/google/btree' is not allowed from list 'main' (depguard)
    "github.com/google/btree"
    ^
make: *** [Makefile:131: lint] Error 1
 {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org