You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Vladimir Kravets (JIRA)" <ji...@codehaus.org> on 2012/08/28 11:31:21 UTC

[jira] (MNG-5337) Maven activation profile feature cannot differ jdk version with build number

Vladimir Kravets created MNG-5337:
-------------------------------------

             Summary: Maven activation profile feature cannot differ jdk version with build number
                 Key: MNG-5337
                 URL: https://jira.codehaus.org/browse/MNG-5337
             Project: Maven 2 & 3
          Issue Type: Bug
    Affects Versions: 3.0.5, 3.1
            Reporter: Vladimir Kravets
            Priority: Minor
         Attachments: fix_jdk_build_version_activator.diff

Since Oracle can apply some major changes between builds we need to have ability to detect build number from profile -> activation -> jdk tag
By now using only first three components of jdk version. I propose to use first 4 components of the version to be able to process it further.

E.g. from ~1.6.0-30 classpath separator is ";" instead of ":". In 1.7.x also using ";".



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] (MNG-5337) Maven activation profile feature cannot differ jdk version with build number

Posted by "Paul Benedict (JIRA)" <ji...@codehaus.org>.
    [ https://jira.codehaus.org/browse/MNG-5337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=307282#comment-307282 ] 

Paul Benedict commented on MNG-5337:
------------------------------------

Makes sense to me. The code is already correctly parsing the the build number (after the dash) but it's being ignored because the proceeding code stops at the third component.
                
> Maven activation profile feature cannot differ jdk version with build number
> ----------------------------------------------------------------------------
>
>                 Key: MNG-5337
>                 URL: https://jira.codehaus.org/browse/MNG-5337
>             Project: Maven 2 & 3
>          Issue Type: Bug
>    Affects Versions: 3.0.5, 3.1
>            Reporter: Vladimir Kravets
>            Priority: Minor
>         Attachments: fix_jdk_build_version_activator.diff
>
>
> Since Oracle can apply some major changes between builds we need to have ability to detect build number from profile -> activation -> jdk tag
> By now using only first three components of jdk version. I propose to use first 4 components of the version to be able to process it further.
> E.g. from ~1.6.0-30 classpath separator is ";" instead of ":". In 1.7.x also using ";".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] (MNG-5337) Maven activation profile feature cannot differ jdk version with build number

Posted by "Vladimir Kravets (JIRA)" <ji...@codehaus.org>.
    [ https://jira.codehaus.org/browse/MNG-5337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=307301#comment-307301 ] 

Vladimir Kravets commented on MNG-5337:
---------------------------------------

Exactly, attached patch resolves this issue. 


                
> Maven activation profile feature cannot differ jdk version with build number
> ----------------------------------------------------------------------------
>
>                 Key: MNG-5337
>                 URL: https://jira.codehaus.org/browse/MNG-5337
>             Project: Maven 2 & 3
>          Issue Type: Bug
>    Affects Versions: 3.0.5, 3.1
>            Reporter: Vladimir Kravets
>            Priority: Minor
>         Attachments: fix_jdk_build_version_activator.diff
>
>
> Since Oracle can apply some major changes between builds we need to have ability to detect build number from profile -> activation -> jdk tag
> By now using only first three components of jdk version. I propose to use first 4 components of the version to be able to process it further.
> E.g. from ~1.6.0-30 classpath separator is ";" instead of ":". In 1.7.x also using ";".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira