You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2019/12/03 14:04:41 UTC
Review Request 71855: Added resource limits into `TaskInfo` and
`ExecutorInfo`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71855/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Greg Mann.
Bugs: MESOS-10043
https://issues.apache.org/jira/browse/MESOS-10043
Repository: mesos
Description
-------
Added resource limits into `TaskInfo` and `ExecutorInfo`.
Diffs
-----
include/mesos/mesos.proto 7d77ddd8021eb7cc3919f3151594dd38606c15c5
include/mesos/v1/mesos.proto 7abb6ba60a1b1861338c47717a49c72a5dffa68c
Diff: https://reviews.apache.org/r/71855/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 71855: Added resource limits into `TaskInfo`.
Posted by Qian Zhang <zh...@gmail.com>.
> On Dec. 20, 2019, 5 p.m., Greg Mann wrote:
> > include/mesos/mesos.proto
> > Lines 800-801 (patched)
> > <https://reviews.apache.org/r/71855/diff/2/?file=2190843#file2190843line800>
> >
> > What do you think about adding another argument to `launchExecutor()` for the executor container limits, rather than adding this field? Since this message is widely-used in public-facing APIs, I would prefer to avoid adding a strictly internal parameter if possible.
Agree.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71855/#review219077
-----------------------------------------------------------
On Dec. 20, 2019, 8:38 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71855/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2019, 8:38 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10043
> https://issues.apache.org/jira/browse/MESOS-10043
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added resource limits into `TaskInfo`.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 7d77ddd8021eb7cc3919f3151594dd38606c15c5
> include/mesos/v1/mesos.proto 7abb6ba60a1b1861338c47717a49c72a5dffa68c
>
>
> Diff: https://reviews.apache.org/r/71855/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 71855: Added resource limits into `TaskInfo` and
`ExecutorInfo`.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71855/#review219077
-----------------------------------------------------------
include/mesos/mesos.proto
Lines 800-801 (patched)
<https://reviews.apache.org/r/71855/#comment307138>
What do you think about adding another argument to `launchExecutor()` for the executor container limits, rather than adding this field? Since this message is widely-used in public-facing APIs, I would prefer to avoid adding a strictly internal parameter if possible.
- Greg Mann
On Dec. 20, 2019, 2:11 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71855/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2019, 2:11 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10043
> https://issues.apache.org/jira/browse/MESOS-10043
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added resource limits into `TaskInfo` and `ExecutorInfo`.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 7d77ddd8021eb7cc3919f3151594dd38606c15c5
> include/mesos/v1/mesos.proto 7abb6ba60a1b1861338c47717a49c72a5dffa68c
>
>
> Diff: https://reviews.apache.org/r/71855/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 71855: Added resource limits into `TaskInfo`.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71855/#review219093
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Dec. 20, 2019, 12:38 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71855/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2019, 12:38 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Greg Mann.
>
>
> Bugs: MESOS-10043
> https://issues.apache.org/jira/browse/MESOS-10043
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added resource limits into `TaskInfo`.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 7d77ddd8021eb7cc3919f3151594dd38606c15c5
> include/mesos/v1/mesos.proto 7abb6ba60a1b1861338c47717a49c72a5dffa68c
>
>
> Diff: https://reviews.apache.org/r/71855/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 71855: Added resource limits into `TaskInfo`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71855/
-----------------------------------------------------------
(Updated Dec. 20, 2019, 8:38 p.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Addressed review comments.
Summary (updated)
-----------------
Added resource limits into `TaskInfo`.
Bugs: MESOS-10043
https://issues.apache.org/jira/browse/MESOS-10043
Repository: mesos
Description (updated)
-------
Added resource limits into `TaskInfo`.
Diffs (updated)
-----
include/mesos/mesos.proto 7d77ddd8021eb7cc3919f3151594dd38606c15c5
include/mesos/v1/mesos.proto 7abb6ba60a1b1861338c47717a49c72a5dffa68c
Diff: https://reviews.apache.org/r/71855/diff/3/
Changes: https://reviews.apache.org/r/71855/diff/2-3/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 71855: Added resource limits into `TaskInfo` and
`ExecutorInfo`.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71855/
-----------------------------------------------------------
(Updated Dec. 20, 2019, 10:11 a.m.)
Review request for mesos, Andrei Budnik and Greg Mann.
Changes
-------
Fixed a typo.
Bugs: MESOS-10043
https://issues.apache.org/jira/browse/MESOS-10043
Repository: mesos
Description
-------
Added resource limits into `TaskInfo` and `ExecutorInfo`.
Diffs (updated)
-----
include/mesos/mesos.proto 7d77ddd8021eb7cc3919f3151594dd38606c15c5
include/mesos/v1/mesos.proto 7abb6ba60a1b1861338c47717a49c72a5dffa68c
Diff: https://reviews.apache.org/r/71855/diff/2/
Changes: https://reviews.apache.org/r/71855/diff/1-2/
Testing
-------
Thanks,
Qian Zhang