You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jakarta.apache.org by "Stefan Bodewig (JIRA)" <ca...@jakarta.apache.org> on 2010/07/23 08:00:49 UTC

[jira] Created: (CACTUS-273) Build fails with checkstyle plugin 2.5

Build fails with checkstyle plugin 2.5
--------------------------------------

                 Key: CACTUS-273
                 URL: https://issues.apache.org/jira/browse/CACTUS-273
             Project: Cactus
          Issue Type: Bug
          Components: Other
    Affects Versions: 1.8.2
            Reporter: Stefan Bodewig


This is related to CACTUS-262 but likely not the full story, hence this separate bug.

When running a clean build of Cactus trunk you'll get version 2.5 of the checkstyle plugin (at least until 2.6 is released) and run into http://jira.codehaus.org/browse/MCHECKSTYLE-130

At first I tried to fix the plugin version at 2.4 but the I'd need to change the checkstyle configuration since 2.4 usus checkstyle 5.0 and there have been some breaking changes "treewalker is not allowed as a parent of filelength" - see http://checkstyle.sourceforge.net/releasenotes.html#Release%205.0

Right now I'm running a build using version 2.3 and will provide a patch once it completes, I may also give version 2.4 and checkstyle 5.0 a try including the configuration changes necessary - or will add a comment if the changes look too big.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org


[jira] Updated: (CACTUS-273) Build fails with checkstyle plugin 2.5

Posted by "Stefan Bodewig (JIRA)" <ca...@jakarta.apache.org>.
     [ https://issues.apache.org/jira/browse/CACTUS-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Bodewig updated CACTUS-273:
----------------------------------

    Attachment: cactus-checkstyle-plugin-2.4-checkstyle-5.1.patch

This patch fixes the plugin version at 2.4 and adapts the configuration to checkstyle 5.x.

I had to disable the JavadocType check since the @goal tags inside the Mojos are violations now and the allowUnknownTags property doesn't seem to work with the 2.4 plugin.

If I were to decide I'd apply this patch and not the earlier one since it is going to help once the 2.6 version of the checkstyle plugin becomes available as well (and it would help Gump more ;-)


> Build fails with checkstyle plugin 2.5
> --------------------------------------
>
>                 Key: CACTUS-273
>                 URL: https://issues.apache.org/jira/browse/CACTUS-273
>             Project: Cactus
>          Issue Type: Bug
>          Components: Other
>    Affects Versions: 1.8.2
>            Reporter: Stefan Bodewig
>         Attachments: cactus-checkstyle-plugin-2.3.patch, cactus-checkstyle-plugin-2.4-checkstyle-5.1.patch
>
>
> This is related to CACTUS-262 but likely not the full story, hence this separate bug.
> When running a clean build of Cactus trunk you'll get version 2.5 of the checkstyle plugin (at least until 2.6 is released) and run into http://jira.codehaus.org/browse/MCHECKSTYLE-130
> At first I tried to fix the plugin version at 2.4 but the I'd need to change the checkstyle configuration since 2.4 usus checkstyle 5.0 and there have been some breaking changes "treewalker is not allowed as a parent of filelength" - see http://checkstyle.sourceforge.net/releasenotes.html#Release%205.0
> Right now I'm running a build using version 2.3 and will provide a patch once it completes, I may also give version 2.4 and checkstyle 5.0 a try including the configuration changes necessary - or will add a comment if the changes look too big.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org


[jira] Resolved: (CACTUS-273) Build fails with checkstyle plugin 2.5

Posted by "Stefan Bodewig (JIRA)" <ca...@jakarta.apache.org>.
     [ https://issues.apache.org/jira/browse/CACTUS-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Bodewig resolved CACTUS-273.
-----------------------------------

    Fix Version/s: 1.8.2
       Resolution: Fixed

svn revision 979968

> Build fails with checkstyle plugin 2.5
> --------------------------------------
>
>                 Key: CACTUS-273
>                 URL: https://issues.apache.org/jira/browse/CACTUS-273
>             Project: Cactus
>          Issue Type: Bug
>          Components: Other
>    Affects Versions: 1.8.2
>            Reporter: Stefan Bodewig
>             Fix For: 1.8.2
>
>         Attachments: cactus-checkstyle-plugin-2.3.patch, cactus-checkstyle-plugin-2.4-checkstyle-5.1.patch
>
>
> This is related to CACTUS-262 but likely not the full story, hence this separate bug.
> When running a clean build of Cactus trunk you'll get version 2.5 of the checkstyle plugin (at least until 2.6 is released) and run into http://jira.codehaus.org/browse/MCHECKSTYLE-130
> At first I tried to fix the plugin version at 2.4 but the I'd need to change the checkstyle configuration since 2.4 usus checkstyle 5.0 and there have been some breaking changes "treewalker is not allowed as a parent of filelength" - see http://checkstyle.sourceforge.net/releasenotes.html#Release%205.0
> Right now I'm running a build using version 2.3 and will provide a patch once it completes, I may also give version 2.4 and checkstyle 5.0 a try including the configuration changes necessary - or will add a comment if the changes look too big.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org


[jira] Updated: (CACTUS-273) Build fails with checkstyle plugin 2.5

Posted by "Stefan Bodewig (JIRA)" <ca...@jakarta.apache.org>.
     [ https://issues.apache.org/jira/browse/CACTUS-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Bodewig updated CACTUS-273:
----------------------------------

    Attachment: cactus-checkstyle-plugin-2.3.patch

Trivial patch that fixes the plugin version at 2.3.  Build passes using mvn 2.2.1 locally with this patch.

> Build fails with checkstyle plugin 2.5
> --------------------------------------
>
>                 Key: CACTUS-273
>                 URL: https://issues.apache.org/jira/browse/CACTUS-273
>             Project: Cactus
>          Issue Type: Bug
>          Components: Other
>    Affects Versions: 1.8.2
>            Reporter: Stefan Bodewig
>         Attachments: cactus-checkstyle-plugin-2.3.patch
>
>
> This is related to CACTUS-262 but likely not the full story, hence this separate bug.
> When running a clean build of Cactus trunk you'll get version 2.5 of the checkstyle plugin (at least until 2.6 is released) and run into http://jira.codehaus.org/browse/MCHECKSTYLE-130
> At first I tried to fix the plugin version at 2.4 but the I'd need to change the checkstyle configuration since 2.4 usus checkstyle 5.0 and there have been some breaking changes "treewalker is not allowed as a parent of filelength" - see http://checkstyle.sourceforge.net/releasenotes.html#Release%205.0
> Right now I'm running a build using version 2.3 and will provide a patch once it completes, I may also give version 2.4 and checkstyle 5.0 a try including the configuration changes necessary - or will add a comment if the changes look too big.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org