You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2010/11/13 18:09:14 UTC
[jira] Created: (CASSANDRA-1743) Switch to TFastFramedTransport
Switch to TFastFramedTransport
------------------------------
Key: CASSANDRA-1743
URL: https://issues.apache.org/jira/browse/CASSANDRA-1743
Project: Cassandra
Issue Type: Improvement
Components: Core
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
Fix For: 0.7.0
Attachments: 1743.txt
Forgot that after THRIFT-831 "fast" mode is not the default and is a separate transport class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-1743) Switch to TFastFramedTransport
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-1743.
---------------------------------------
Resolution: Fixed
Reviewer: jbellis
fixed import order + committed
> Switch to TFastFramedTransport
> ------------------------------
>
> Key: CASSANDRA-1743
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1743
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Fix For: 0.7.1
>
> Attachments: 1743.txt, 1743.txt, 1743_v3.txt, 1743_v4.txt, 1743_v5.txt
>
>
> Forgot that after THRIFT-831 "fast" mode is not the default and is a separate transport class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1743) Switch to TFastFramedTransport
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934395#action_12934395 ]
Jonathan Ellis commented on CASSANDRA-1743:
-------------------------------------------
that sounds like a bug in TFFT then, it should know that only data in the byte[] from the current request is valid
> Switch to TFastFramedTransport
> ------------------------------
>
> Key: CASSANDRA-1743
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1743
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.7.0
>
> Attachments: 1743.txt, 1743.txt
>
>
> Forgot that after THRIFT-831 "fast" mode is not the default and is a separate transport class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1743) Switch to TFastFramedTransport
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934087#action_12934087 ]
Jonathan Ellis commented on CASSANDRA-1743:
-------------------------------------------
as long as we're using thread-per-connection the underlying byte[] shouldn't change until the next request. i don't think that's the problem.
> Switch to TFastFramedTransport
> ------------------------------
>
> Key: CASSANDRA-1743
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1743
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.7.0
>
> Attachments: 1743.txt, 1743.txt
>
>
> Forgot that after THRIFT-831 "fast" mode is not the default and is a separate transport class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1743) Switch to TFastFramedTransport
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1743:
--------------------------------------
Fix Version/s: (was: 0.7.0)
0.7.1
> Switch to TFastFramedTransport
> ------------------------------
>
> Key: CASSANDRA-1743
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1743
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.7.1
>
> Attachments: 1743.txt, 1743.txt, 1743_v3.txt
>
>
> Forgot that after THRIFT-831 "fast" mode is not the default and is a separate transport class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1743) Switch to TFastFramedTransport
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1743:
--------------------------------------
Fix Version/s: (was: 0.7.1)
0.8
> Switch to TFastFramedTransport
> ------------------------------
>
> Key: CASSANDRA-1743
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1743
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Fix For: 0.8
>
> Attachments: 1743.txt, 1743.txt, 1743_v3.txt, 1743_v4.txt, 1743_v5.txt
>
> Original Estimate: 16h
> Remaining Estimate: 16h
>
> Forgot that after THRIFT-831 "fast" mode is not the default and is a separate transport class.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-1743) Switch to TFastFramedTransport
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934089#action_12934089 ]
T Jake Luciani commented on CASSANDRA-1743:
-------------------------------------------
That's what i mean, on the next request, it corrupting the data from the previous one because they both share the same underlying byte[] since it's re-used.
> Switch to TFastFramedTransport
> ------------------------------
>
> Key: CASSANDRA-1743
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1743
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.7.0
>
> Attachments: 1743.txt, 1743.txt
>
>
> Forgot that after THRIFT-831 "fast" mode is not the default and is a separate transport class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1743) Switch to TFastFramedTransport
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933846#action_12933846 ]
T Jake Luciani commented on CASSANDRA-1743:
-------------------------------------------
Maybe it's just a bug with it. Either way it cas causing 1744 for me.
> Switch to TFastFramedTransport
> ------------------------------
>
> Key: CASSANDRA-1743
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1743
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.7.0
>
> Attachments: 1743.txt, 1743.txt
>
>
> Forgot that after THRIFT-831 "fast" mode is not the default and is a separate transport class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1743) Switch to TFastFramedTransport
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani updated CASSANDRA-1743:
--------------------------------------
Attachment: 1743_v3.txt
This patch fixes the corruption issue by making copies of data that use the local write path. Also copies are made for schema migrations.
This decreases local write speed slightly(proxy writes are faster). read speed is improved across the board.
> Switch to TFastFramedTransport
> ------------------------------
>
> Key: CASSANDRA-1743
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1743
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.7.0
>
> Attachments: 1743.txt, 1743.txt, 1743_v3.txt
>
>
> Forgot that after THRIFT-831 "fast" mode is not the default and is a separate transport class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (CASSANDRA-1743) Switch to TFastFramedTransport
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reopened CASSANDRA-1743:
---------------------------------------
reverted because of CASSANDRA-2102 and possibly other bugs waiting to be found
> Switch to TFastFramedTransport
> ------------------------------
>
> Key: CASSANDRA-1743
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1743
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Fix For: 0.8
>
> Attachments: 1743.txt, 1743.txt, 1743_v3.txt, 1743_v4.txt, 1743_v5.txt
>
> Original Estimate: 16h
> Remaining Estimate: 16h
>
> Forgot that after THRIFT-831 "fast" mode is not the default and is a separate transport class.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-1743) Switch to TFastFramedTransport
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani updated CASSANDRA-1743:
--------------------------------------
Attachment: 1743_v5.txt
Rebased with only TFastFramedTransport change since other changes went in with CASSANDRA-1801
> Switch to TFastFramedTransport
> ------------------------------
>
> Key: CASSANDRA-1743
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1743
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Fix For: 0.7.1
>
> Attachments: 1743.txt, 1743.txt, 1743_v3.txt, 1743_v4.txt, 1743_v5.txt
>
>
> Forgot that after THRIFT-831 "fast" mode is not the default and is a separate transport class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1743) Switch to TFastFramedTransport
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931729#action_12931729 ]
Brandon Williams commented on CASSANDRA-1743:
---------------------------------------------
I get a "fast" OOM:
ERROR 15:52:23,570 Fatal exception in thread Thread[pool-1-thread-66,5,main]
java.lang.OutOfMemoryError: Java heap space
at org.apache.thrift.transport.AutoExpandingBuffer.<init>(AutoExpandingBuffer.java:37)
at org.apache.thrift.transport.AutoExpandingBufferWriteTransport.<init>(AutoExpandingBufferWriteTransport.java:32)
at org.apache.thrift.transport.TFastFramedTransport.<init>(TFastFramedTransport.java:107)
at org.apache.thrift.transport.TFastFramedTransport$Factory.getTransport(TFastFramedTransport.java:51)
at org.apache.cassandra.thrift.CustomTThreadPoolServer$WorkerProcess.run(CustomTThreadPoolServer.java:161)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
at java.lang.Thread.run(Thread.java:636)
> Switch to TFastFramedTransport
> ------------------------------
>
> Key: CASSANDRA-1743
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1743
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.7.0
>
> Attachments: 1743.txt
>
>
> Forgot that after THRIFT-831 "fast" mode is not the default and is a separate transport class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1743) Switch to TFastFramedTransport
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1743:
--------------------------------------
Attachment: 1743.txt
new patch starts w/ 64K buffer and grows if needed up to max frame size.
> Switch to TFastFramedTransport
> ------------------------------
>
> Key: CASSANDRA-1743
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1743
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.7.0
>
> Attachments: 1743.txt, 1743.txt
>
>
> Forgot that after THRIFT-831 "fast" mode is not the default and is a separate transport class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1743) Switch to TFastFramedTransport
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933843#action_12933843 ]
Jonathan Ellis commented on CASSANDRA-1743:
-------------------------------------------
but we're still using TThreadPoolServer so thread safety should be a non-issue?
> Switch to TFastFramedTransport
> ------------------------------
>
> Key: CASSANDRA-1743
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1743
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.7.0
>
> Attachments: 1743.txt, 1743.txt
>
>
> Forgot that after THRIFT-831 "fast" mode is not the default and is a separate transport class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1743) Switch to TFastFramedTransport
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974676#action_12974676 ]
Hudson commented on CASSANDRA-1743:
-----------------------------------
Integrated in Cassandra-0.7 #113 (See [https://hudson.apache.org/hudson/job/Cassandra-0.7/113/])
upgrade to TFastFramedTransport
patch by tjake; reviewed by jbellis for CASSANDRA-1743
> Switch to TFastFramedTransport
> ------------------------------
>
> Key: CASSANDRA-1743
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1743
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Fix For: 0.7.1
>
> Attachments: 1743.txt, 1743.txt, 1743_v3.txt, 1743_v4.txt, 1743_v5.txt
>
>
> Forgot that after THRIFT-831 "fast" mode is not the default and is a separate transport class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1743) Switch to TFastFramedTransport
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1743:
--------------------------------------
Attachment: 1743.txt
> Switch to TFastFramedTransport
> ------------------------------
>
> Key: CASSANDRA-1743
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1743
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.7.0
>
> Attachments: 1743.txt
>
>
> Forgot that after THRIFT-831 "fast" mode is not the default and is a separate transport class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Resolved] (CASSANDRA-1743) Switch to TFastFramedTransport
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-1743.
---------------------------------------
Resolution: Won't Fix
Fix Version/s: (was: 1.2)
Assignee: (was: T Jake Luciani)
now that we have a custom binary protocol, we can leave thrift in peace
> Switch to TFastFramedTransport
> ------------------------------
>
> Key: CASSANDRA-1743
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1743
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Attachments: 1743.txt, 1743.txt, 1743_v3.txt, 1743_v4.txt, 1743_v5.txt
>
> Original Estimate: 16h
> Remaining Estimate: 16h
>
> Forgot that after THRIFT-831 "fast" mode is not the default and is a separate transport class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (CASSANDRA-1743) Switch to TFastFramedTransport
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934085#action_12934085 ]
T Jake Luciani commented on CASSANDRA-1743:
-------------------------------------------
I think what's happening here is writes are not immutable and subsequent use of the same Server thread is changing the underlying byte[], corrupting the data. We would need to copy the data we wish to retain, this defeats the purpose of using TFastFramed but maybe it's a slight improvement? Seems too risky
> Switch to TFastFramedTransport
> ------------------------------
>
> Key: CASSANDRA-1743
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1743
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.7.0
>
> Attachments: 1743.txt, 1743.txt
>
>
> Forgot that after THRIFT-831 "fast" mode is not the default and is a separate transport class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-1743) Switch to TFastFramedTransport
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reassigned CASSANDRA-1743:
-----------------------------------------
Assignee: T Jake Luciani (was: Jonathan Ellis)
> Switch to TFastFramedTransport
> ------------------------------
>
> Key: CASSANDRA-1743
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1743
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Fix For: 0.7.1
>
> Attachments: 1743.txt, 1743.txt, 1743_v3.txt, 1743_v4.txt
>
>
> Forgot that after THRIFT-831 "fast" mode is not the default and is a separate transport class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1743) Switch to TFastFramedTransport
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934487#action_12934487 ]
T Jake Luciani commented on CASSANDRA-1743:
-------------------------------------------
I don't think it's TFFT it's how we use it :)
if we want it to work for us we need to re-create the transport on each request
otherwise we will have this corruption issue, but re-creating the transports defeats the purpose of TFastFramed for me.
as it is now the server will create the transport once per thread and reuse it for all subsequent requests on that thread.
from CustomTThreadPoolService::run()
{code}
inputTransport = inputTransportFactory_.getTransport(client_);
outputTransport = outputTransportFactory_.getTransport(client_);
inputProtocol = inputProtocolFactory_.getProtocol(inputTransport);
outputProtocol = outputProtocolFactory_.getProtocol(outputTransport);
while (!stopped_ && processor.process(inputProtocol, outputProtocol))
{
inputProtocol = inputProtocolFactory_.getProtocol(inputTransport);
outputProtocol = outputProtocolFactory_.getProtocol(outputTransport);
}
{code}
> Switch to TFastFramedTransport
> ------------------------------
>
> Key: CASSANDRA-1743
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1743
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.7.0
>
> Attachments: 1743.txt, 1743.txt
>
>
> Forgot that after THRIFT-831 "fast" mode is not the default and is a separate transport class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1743) Switch to TFastFramedTransport
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
T Jake Luciani updated CASSANDRA-1743:
--------------------------------------
Attachment: 1743_v4.txt
rebased patch
> Switch to TFastFramedTransport
> ------------------------------
>
> Key: CASSANDRA-1743
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1743
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.7.1
>
> Attachments: 1743.txt, 1743.txt, 1743_v3.txt, 1743_v4.txt
>
>
> Forgot that after THRIFT-831 "fast" mode is not the default and is a separate transport class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1743) Switch to TFastFramedTransport
Posted by "T Jake Luciani (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933837#action_12933837 ]
T Jake Luciani commented on CASSANDRA-1743:
-------------------------------------------
This won't work, TFastFramedTransport isn't thread safe so the underlying buffer is being corrupted causing CASSANDRA-1744
> Switch to TFastFramedTransport
> ------------------------------
>
> Key: CASSANDRA-1743
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1743
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.7.0
>
> Attachments: 1743.txt, 1743.txt
>
>
> Forgot that after THRIFT-831 "fast" mode is not the default and is a separate transport class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1743) Switch to TFastFramedTransport
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1743:
--------------------------------------
Remaining Estimate: 16h
Original Estimate: 16h
> Switch to TFastFramedTransport
> ------------------------------
>
> Key: CASSANDRA-1743
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1743
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Fix For: 0.7.1
>
> Attachments: 1743.txt, 1743.txt, 1743_v3.txt, 1743_v4.txt, 1743_v5.txt
>
> Original Estimate: 16h
> Remaining Estimate: 16h
>
> Forgot that after THRIFT-831 "fast" mode is not the default and is a separate transport class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.