You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2023/02/23 22:34:31 UTC
[native-toolchain-CR] CDPD-49242: Add SLES15 support
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19528
Change subject: CDPD-49242: Add SLES15 support
......................................................................
CDPD-49242: Add SLES15 support
Adds support for building with SLES15 SP4.
Adds a container definition for SLES15 based on public repositories.
SLES 15 SP4 does not support Python 2 so we omit that from the build
and symlink python to python3 for build dependencies. It also doesn't
provide Java 8 packages, so we use Java 11 and explicitly set JAVA_HOME
as Kudu's normal heuristics for finding JAVA_HOME didn't work.
Fixes several invocations of python that unexpectedly used the system
python instead of the python version built in the native-toolchain.
Change-Id: Ie27521cdbec2f7e966e70c2b0a954d391bf1500d
---
M Makefile
M docker/all/assert-dependencies-present.py
M docker/all/postinstall.sh
A docker/sles15.df
M in-docker.py
M source/kudu/build.sh
M source/python/build.sh
M source/thrift/build.sh
8 files changed, 76 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/28/19528/1
--
To view, visit http://gerrit.cloudera.org:8080/19528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie27521cdbec2f7e966e70c2b0a954d391bf1500d
Gerrit-Change-Number: 19528
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-11944: Add SLES15 support
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19528 )
Change subject: IMPALA-11944: Add SLES15 support
......................................................................
Patch Set 7: Code-Review+2
This looks good to me. I think it makes sense to go ahead and merge, because it doesn't impact anything other than sles15.
--
To view, visit http://gerrit.cloudera.org:8080/19528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie27521cdbec2f7e966e70c2b0a954d391bf1500d
Gerrit-Change-Number: 19528
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Feb 2023 23:01:21 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11944: Add SLES15 support
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19528 )
Change subject: IMPALA-11944: Add SLES15 support
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/19528/3/source/kudu/build.sh
File source/kudu/build.sh:
http://gerrit.cloudera.org:8080/#/c/19528/3/source/kudu/build.sh@125
PS3, Line 125: # Set JAVA_HOME to the system java. Kudu has a bunch of heuristics for trying to
I can remove this with the JDK 8 we ended up with.
http://gerrit.cloudera.org:8080/#/c/19528/3/source/python/build.sh
File source/python/build.sh:
http://gerrit.cloudera.org:8080/#/c/19528/3/source/python/build.sh@58
PS3, Line 58: wrap $LOCAL_INSTALL/bin/python -c 'import bz2; import readline; from urllib2 import HTTPSHandler; from httplib import HTTPConnection'
This and the thrift/build.sh could be handled in a different patch.
--
To view, visit http://gerrit.cloudera.org:8080/19528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie27521cdbec2f7e966e70c2b0a954d391bf1500d
Gerrit-Change-Number: 19528
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Feb 2023 21:32:12 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] CDPD-49242: Add SLES15 support
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19528 )
Change subject: CDPD-49242: Add SLES15 support
......................................................................
Patch Set 1:
Test build at https://playground-01.jenkins.cloudera.com/job/impala-toolchain-container-build/42/.
--
To view, visit http://gerrit.cloudera.org:8080/19528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie27521cdbec2f7e966e70c2b0a954d391bf1500d
Gerrit-Change-Number: 19528
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Feb 2023 22:38:21 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11944: Add SLES15 support
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19528 )
Change subject: IMPALA-11944: Add SLES15 support
......................................................................
Patch Set 6:
I'd like to commit this, then produce new builds of everything to pick up in Impala. I've done test builds that all pass, and it only impacts the new SLES15 container and build.
--
To view, visit http://gerrit.cloudera.org:8080/19528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie27521cdbec2f7e966e70c2b0a954d391bf1500d
Gerrit-Change-Number: 19528
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Feb 2023 22:05:28 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11944: Add SLES15 support
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal, Joe McDonnell,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19528
to look at the new patch set (#7).
Change subject: IMPALA-11944: Add SLES15 support
......................................................................
IMPALA-11944: Add SLES15 support
Adds support for building with SLES 15 SP4.
Adds a container definition for SLES 15 based on public repositories.
SLES 15 SP4 does not provide Python 2 or Java 8 JDK, so we use openSUSE
Leap 15.4 distribution packages for these.
Testing:
- produced build 15-dde6cb2d68 in impala-toolchain-test.s3.amazonaws.com
- completed test build of Impala with Python 2 and Java 8 SDK above
(with tweaks to pick up the test build and add OsMapping to
bin/bootstrap_toolchain.py)
- rebuild as 16-99685c020d also succeeded
Change-Id: Ie27521cdbec2f7e966e70c2b0a954d391bf1500d
---
M Makefile
A docker/sles15.df
M in-docker.py
3 files changed, 58 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/28/19528/7
--
To view, visit http://gerrit.cloudera.org:8080/19528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie27521cdbec2f7e966e70c2b0a954d391bf1500d
Gerrit-Change-Number: 19528
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-11944: Add SLES15 support
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal, Joe McDonnell,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19528
to look at the new patch set (#6).
Change subject: IMPALA-11944: Add SLES15 support
......................................................................
IMPALA-11944: Add SLES15 support
Adds support for building with SLES 15 SP4.
Adds a container definition for SLES 15 based on public repositories.
SLES 15 SP4 does not provide Python 2 or Java 8 JDK, so we use openSUSE
Leap 15.4 distribution packages for these.
Testing:
- produced build 15-dde6cb2d68 in impala-toolchain-test.s3.amazonaws.com
- completed test build of Impala (with tweaks to pick up the test build
and add OsMapping to bin/bootstrap_toolchain.py)
- rebuild as 16-99685c020d also succeeded
Change-Id: Ie27521cdbec2f7e966e70c2b0a954d391bf1500d
---
M Makefile
A docker/sles15.df
M in-docker.py
3 files changed, 58 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/28/19528/6
--
To view, visit http://gerrit.cloudera.org:8080/19528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie27521cdbec2f7e966e70c2b0a954d391bf1500d
Gerrit-Change-Number: 19528
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-11944: Add SLES15 support
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19528 )
Change subject: IMPALA-11944: Add SLES15 support
......................................................................
IMPALA-11944: Add SLES15 support
Adds support for building with SLES 15 SP4.
Adds a container definition for SLES 15 based on public repositories.
SLES 15 SP4 does not provide Python 2 or Java 8 JDK, so we use openSUSE
Leap 15.4 distribution packages for these.
Testing:
- produced build 15-dde6cb2d68 in impala-toolchain-test.s3.amazonaws.com
- completed test build of Impala with Python 2 and Java 8 SDK above
(with tweaks to pick up the test build and add OsMapping to
bin/bootstrap_toolchain.py)
- rebuild as 16-99685c020d also succeeded
Change-Id: Ie27521cdbec2f7e966e70c2b0a954d391bf1500d
Reviewed-on: http://gerrit.cloudera.org:8080/19528
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Michael Smith <mi...@cloudera.com>
---
M Makefile
A docker/sles15.df
M in-docker.py
3 files changed, 58 insertions(+), 0 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Michael Smith: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie27521cdbec2f7e966e70c2b0a954d391bf1500d
Gerrit-Change-Number: 19528
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-11944: Add SLES15 support
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19528 )
Change subject: IMPALA-11944: Add SLES15 support
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/19528/3/source/kudu/build.sh
File source/kudu/build.sh:
http://gerrit.cloudera.org:8080/#/c/19528/3/source/kudu/build.sh@125
PS3, Line 125: # Set JAVA_HOME to the system java. Kudu has a bunch of heuristics for trying to
> I can remove this with the JDK 8 we ended up with.
Done
http://gerrit.cloudera.org:8080/#/c/19528/3/source/python/build.sh
File source/python/build.sh:
http://gerrit.cloudera.org:8080/#/c/19528/3/source/python/build.sh@58
PS3, Line 58: wrap $LOCAL_INSTALL/bin/python -c 'import bz2; import readline; from urllib2 import HTTPSHandler; from httplib import HTTPConnection'
> This and the thrift/build.sh could be handled in a different patch.
Done
--
To view, visit http://gerrit.cloudera.org:8080/19528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie27521cdbec2f7e966e70c2b0a954d391bf1500d
Gerrit-Change-Number: 19528
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Feb 2023 17:35:15 +0000
Gerrit-HasComments: Yes
[native-toolchain-CR] IMPALA-11944: Add SLES15 support
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19528
to look at the new patch set (#4).
Change subject: IMPALA-11944: Add SLES15 support
......................................................................
IMPALA-11944: Add SLES15 support
Adds support for building with SLES 15 SP4.
Adds a container definition for SLES 15 based on public repositories.
SLES 15 SP4 does not provide Python 2 or Java 8 JDK, so we use openSUSE
Leap 15.4 distribution packages for these.
Change-Id: Ie27521cdbec2f7e966e70c2b0a954d391bf1500d
---
M Makefile
A docker/sles15.df
M in-docker.py
3 files changed, 58 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/28/19528/4
--
To view, visit http://gerrit.cloudera.org:8080/19528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie27521cdbec2f7e966e70c2b0a954d391bf1500d
Gerrit-Change-Number: 19528
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-11944: Add SLES15 support
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19528
to look at the new patch set (#3).
Change subject: IMPALA-11944: Add SLES15 support
......................................................................
IMPALA-11944: Add SLES15 support
Adds support for building with SLES 15 SP4.
Adds a container definition for SLES 15 based on public repositories.
SLES 15 SP4 does not provide Python 2 or Java 8 JDK, so we use openSUSE
Leap 15.4 distribution packages for these.
Fixes several invocations of python that unexpectedly used the system
python instead of the python version built in the native-toolchain.
Change-Id: Ie27521cdbec2f7e966e70c2b0a954d391bf1500d
---
M Makefile
A docker/sles15.df
M in-docker.py
M source/kudu/build.sh
M source/python/build.sh
M source/thrift/build.sh
6 files changed, 73 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/28/19528/3
--
To view, visit http://gerrit.cloudera.org:8080/19528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie27521cdbec2f7e966e70c2b0a954d391bf1500d
Gerrit-Change-Number: 19528
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-11944: Add SLES15 support
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal, Joe McDonnell,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19528
to look at the new patch set (#5).
Change subject: IMPALA-11944: Add SLES15 support
......................................................................
IMPALA-11944: Add SLES15 support
Adds support for building with SLES 15 SP4.
Adds a container definition for SLES 15 based on public repositories.
SLES 15 SP4 does not provide Python 2 or Java 8 JDK, so we use openSUSE
Leap 15.4 distribution packages for these.
Testing:
- produced build 15-dde6cb2d68 in impala-toolchain-test.s3.amazonaws.com
- completed test build of Impala (with tweaks to pick up the test build
and add OsMapping to bin/bootstrap_toolchain.py).
Change-Id: Ie27521cdbec2f7e966e70c2b0a954d391bf1500d
---
M Makefile
A docker/sles15.df
M in-docker.py
3 files changed, 58 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/28/19528/5
--
To view, visit http://gerrit.cloudera.org:8080/19528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie27521cdbec2f7e966e70c2b0a954d391bf1500d
Gerrit-Change-Number: 19528
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[native-toolchain-CR] IMPALA-11944: Add SLES15 support
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19528 )
Change subject: IMPALA-11944: Add SLES15 support
......................................................................
Patch Set 7: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie27521cdbec2f7e966e70c2b0a954d391bf1500d
Gerrit-Change-Number: 19528
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Feb 2023 23:15:47 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-11944: Add SLES15 support
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19528
to look at the new patch set (#2).
Change subject: IMPALA-11944: Add SLES15 support
......................................................................
IMPALA-11944: Add SLES15 support
Adds support for building with SLES15 SP4.
Adds a container definition for SLES15 based on public repositories.
SLES 15 SP4 does not support Python 2 so we omit that from the build
and symlink python to python3 for build dependencies. It also doesn't
provide Java 8 packages, so we use Java 11 and explicitly set JAVA_HOME
as Kudu's normal heuristics for finding JAVA_HOME didn't work.
Fixes several invocations of python that unexpectedly used the system
python instead of the python version built in the native-toolchain.
Change-Id: Ie27521cdbec2f7e966e70c2b0a954d391bf1500d
---
M Makefile
M docker/all/assert-dependencies-present.py
M docker/all/postinstall.sh
A docker/sles15.df
M in-docker.py
M source/kudu/build.sh
M source/python/build.sh
M source/thrift/build.sh
8 files changed, 76 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/28/19528/2
--
To view, visit http://gerrit.cloudera.org:8080/19528
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie27521cdbec2f7e966e70c2b0a954d391bf1500d
Gerrit-Change-Number: 19528
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>