You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexei Zakharov (JIRA)" <ji...@apache.org> on 2007/04/18 15:47:15 UTC
[jira] Resolved: (HARMONY-3672) [classlib][luni]Delete a unused
method of java.net.URL
[ https://issues.apache.org/jira/browse/HARMONY-3672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexei Zakharov resolved HARMONY-3672.
--------------------------------------
Resolution: Fixed
Hi Jimmy, thanks.
After reviewing your patch I've made some modifications:
1. In URLTest#test_getContent_LJavaLangClass()
I've removed duplicated block.
is = (InputStream) u.getContent(new Class[]{Object.class});
is.read(ba = new byte[4096]);
s = new String(ba);
assertTrue("Incorrect content " + u
+ " does not contain: \" A Seemingly Non Important String \"",
s.indexOf("A Seemingly Non Important String") >= 0);
What was it for?
2. In URLTest#test_openConnection_URL_Proxy()
I was confused with the following block:
try {
lh.openConnection(null , null);
fail("NullPointerException expected, but nothing was thrown!");
} catch (UnsupportedOperationException e) {
// Expected
}
So I've replaced "NUllPointerException expected" with "UnsupportedOperationException expected" in the failure message.
3. Newly introduced URLTest#test_getContent_LJavaLangClass was failing on RI in its original form. IMO this was due differences in handling of "file:" URLs by URL's construtor brtween RI and HARMONY. I've fixed this.
Modified version of the patch was committed at the revision 530019. Please verify that everything is ok.
> [classlib][luni]Delete a unused method of java.net.URL
> ------------------------------------------------------
>
> Key: HARMONY-3672
> URL: https://issues.apache.org/jira/browse/HARMONY-3672
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Jimmy, Jing Lv
> Assigned To: Alexei Zakharov
> Attachments: Harmony3672.diff
>
>
> A non-API mehtod getStreamHandler() is never used, delete it may make code clear.
> What's more, enrich some tests for URL and URLConnection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.