[GitHub] [spark] juliuszsompolski commented on a diff in pull request #42441: [CONNECT][POC] Have real server and real simple client in tests

["juliuszsompolski (via GitHub)" <gi...@apache.org>]

juliuszsompolski commented on code in PR #42441:
URL: https://github.com/apache/spark/pull/42441#discussion_r1290758670


##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -263,6 +263,7 @@ object SparkConnectService extends Logging {
   private type SessionCacheKey = (String, String)
 
   private[connect] var server: Server = _
+  private[connect] var service: SparkConnectService = _

Review Comment:
   actually probably not needed. This was from before I tried to just send request to the service directly, but was not satisfied, because I was not getting The Real Experience.



##########
connector/connect/client/jvm-internal/pom.xml:
##########
@@ -0,0 +1,235 @@
+<?xml version="1.0" encoding="UTF-8"?>

Review Comment:
   this is mostly a copy from jvm/pom.xml, so can surely be pruned as jvm-internal should have less deps.



##########
project/SparkBuild.scala:
##########
@@ -460,6 +463,7 @@ object SparkBuild extends PomBuild {
   enable(SparkConnectCommon.settings)(connectCommon)
   enable(SparkConnect.settings)(connect)
   enable(SparkConnectClient.settings)(connectClient)
+  enable(SparkConnectClient.settings)(connectClientInternal)

Review Comment:
   just reused the SparkConnectClient settings. Likely needs tweaking.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org