[GitHub] TisonKun edited a comment on issue #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener

[GitBox <gi...@apache.org>]

TisonKun edited a comment on issue #6729: [FLINK-10386] [taskmanager] Remove legacy class TaskExecutionStateListener
URL: https://github.com/apache/flink/pull/6729#issuecomment-427071700
 
 
   All "Why are we removing these assertions?" is as you say, we do not send those state updates via `TaskManagerActions.updateTaskExecutionState`. Maybe we can verify `TaskManagerActions.notifyFatalError`/`TaskManagerActions.failTask`/`TaskManagerActions.notifyFinalState` but all of them don't include detail task state.
   
   Besides, as the communication with @Clarkkkkk , `TaskTest` is a test based on legacy mode, there is a pull request #6778 to port it to FLIP-6 code base.
   
   I think the main issue is whether we replace `notifyObservers` with `TaskManagerActions.updateTaskExecutionState`. My opinion is not for now to hold the current(FLIP-6) message flow and defer the decision. If so, we remove those assertion because we don't send those message and the assertion should not hold.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services