You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/08/07 00:52:06 UTC
Re: Review Request: Add an API to destroy a cgroup (and all its sub-cgroups).
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5840/#review9910
-----------------------------------------------------------
src/linux/cgroups.cpp
<https://reviews.apache.org/r/5840/#comment21072>
s/finailize/finalize/
src/tests/cgroups_tests.cpp
<https://reviews.apache.org/r/5840/#comment21074>
Why the extra forks? These need a comment.
src/tests/cgroups_tests.cpp
<https://reviews.apache.org/r/5840/#comment21076>
What's the semantics of this with respect to the parent test? Will the parent just wait forever? Or will the test correctly "fail"?
third_party/libprocess/include/process/future.hpp
<https://reviews.apache.org/r/5840/#comment21077>
Can you please make this a const_iterator too?
- Benjamin Hindman
On July 24, 2012, 11:25 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5840/
> -----------------------------------------------------------
>
> (Updated July 24, 2012, 11:25 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Description
> -------
>
> The patch leverages the atomic task kill patch
> https://reviews.apache.org/r/5402/
>
> It can destroy an active cgroup (and all its sub-cgroups) by killing all tasks and remove the cgroups in appropriate order.
>
> It uses the process::collect mechanism to parallelize the killing process.
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp cec9e36
> src/linux/cgroups.cpp 93c140f
> src/tests/cgroups_tests.cpp 7f0f901
> third_party/libprocess/include/process/future.hpp 1da33ad
>
> Diff: https://reviews.apache.org/r/5840/diff/
>
>
> Testing
> -------
>
> On linux machines, make check.
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request: Add an API to destroy a cgroup (and all its sub-cgroups).
Posted by Jie Yu <yu...@gmail.com>.
> On Aug. 6, 2012, 10:52 p.m., Benjamin Hindman wrote:
> > third_party/libprocess/include/process/future.hpp, line 340
> > <https://reviews.apache.org/r/5840/diff/3/?file=128481#file128481line340>
> >
> > Can you please make this a const_iterator too?
Done.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5840/#review9910
-----------------------------------------------------------
On July 24, 2012, 11:25 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5840/
> -----------------------------------------------------------
>
> (Updated July 24, 2012, 11:25 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Description
> -------
>
> The patch leverages the atomic task kill patch
> https://reviews.apache.org/r/5402/
>
> It can destroy an active cgroup (and all its sub-cgroups) by killing all tasks and remove the cgroups in appropriate order.
>
> It uses the process::collect mechanism to parallelize the killing process.
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp cec9e36
> src/linux/cgroups.cpp 93c140f
> src/tests/cgroups_tests.cpp 7f0f901
> third_party/libprocess/include/process/future.hpp 1da33ad
>
> Diff: https://reviews.apache.org/r/5840/diff/
>
>
> Testing
> -------
>
> On linux machines, make check.
>
>
> Thanks,
>
> Jie Yu
>
>