You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/01/13 15:31:29 UTC

[GitHub] [pulsar] dawillcox commented on a change in pull request #6039: [Issue 6024][pulsar_storm] PulsarSpout emit to multiple streams

dawillcox commented on a change in pull request #6039: [Issue 6024][pulsar_storm] PulsarSpout emit to multiple streams
URL: https://github.com/apache/pulsar/pull/6039#discussion_r365866897
 
 

 ##########
 File path: pulsar-storm/src/main/java/org/apache/pulsar/storm/MessageToValuesMapper.java
 ##########
 @@ -33,12 +33,12 @@
      * @param msg
      * @return
      */
-    public Values toValues(Message<byte[]> msg);
 
 Review comment:
   `public` is redundant. Interface messages _must_ be public.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services