[jira] Commented: (MAPREDUCE-2193) 13 Findbugs warnings on trunk and branch-0.22

["Todd Lipcon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980589#action_12980589 ] 

Todd Lipcon commented on MAPREDUCE-2193:
----------------------------------------

In Localizer, I don't think it's correct to remove the synchronization on localizedUser. findbugs thinks it's suspicious that it's synchronizing on an AtomicBoolean, but we're not even using AtomicBoolean for its atomicity, we just need some kind of "holder object" for the boolean and AtomicBoolean is a handy one. Maybe instead we could use a single-element array? Or define Holder<T> somewhere in MR (this isn't the only place it would be handy)

Regarding JobInProgress, the synchronization here is pretty messed up... mostly because JIP is often externally synchronized upon, or done under the JT-wide or scheduler-wide lock. I think we should just set getTasks to be synchronized rather than ignoring this.

> 13 Findbugs warnings on trunk and branch-0.22
> ---------------------------------------------
>
>                 Key: MAPREDUCE-2193
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2193
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.22.0, 0.23.0
>            Reporter: Nigel Daley
>            Assignee: Harsh J Chouraria
>            Priority: Blocker
>             Fix For: 0.22.0, 0.23.0
>
>         Attachments: findbugsWarnings.html, hadoop-findbugs-report.html, hadoop-findbugs-report.html, mapreduce.trunk.findbugs.r1.diff, mapreduce.trunk.findbugs.r2.diff
>
>
> There are 13 findbugs warnings on trunk.  See attached html file.  These must be fixed or filtered out to get back to 0 warnings.  The OK_FINDBUGS_WARNINGS property in src/test/test-patch.properties should also be set to 0 in the patch that fixes this issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.