You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Oliver Deakin (JIRA)" <ji...@apache.org> on 2006/05/09 18:42:04 UTC
[jira] Created: (HARMONY-451) Consolidate icu4c zips
Consolidate icu4c zips
----------------------
Key: HARMONY-451
URL: http://issues.apache.org/jira/browse/HARMONY-451
Project: Harmony
Type: Improvement
Components: Classlib
Reporter: Oliver Deakin
Priority: Minor
Currently we have two icu4c-3.4-harmony.zip files located at depends\oss\<OS>.IA32, where <OS> is win or linux. Inside these zips there are a lot of header files which are identical between the two platforms except for linux using #ifndef where windows uses #if !defined.
This JIRA proposes that the contents of these two zips are combined into a single zip, and that at build time that zip has its contents placed into the native-src/<platform>/text/unicode directory, rather than native-src/<platform>/include/unicode, since it is only used by the text native component.
I will attach a script to refactor the icu4c zips into a single one, and also a patch for the build scripts and text makefiles to pick up the new file locations.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-451) Consolidate icu4c zips
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-451?page=all ]
George Harley reassigned HARMONY-451:
-------------------------------------
Assign To: George Harley
> Consolidate icu4c zips
> ----------------------
>
> Key: HARMONY-451
> URL: http://issues.apache.org/jira/browse/HARMONY-451
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: George Harley
> Priority: Minor
> Attachments: consolidate.unicode.diff, icu4c.refactor.sh
>
> Currently we have two icu4c-3.4-harmony.zip files located at depends\oss\<OS>.IA32, where <OS> is win or linux. Inside these zips there are a lot of header files which are identical between the two platforms except for linux using #ifndef where windows uses #if !defined.
> This JIRA proposes that the contents of these two zips are combined into a single zip, and that at build time that zip has its contents placed into the native-src/<platform>/text/unicode directory, rather than native-src/<platform>/include/unicode, since it is only used by the text native component.
> I will attach a script to refactor the icu4c zips into a single one, and also a patch for the build scripts and text makefiles to pick up the new file locations.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-451) Consolidate icu4c zips
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-451?page=all ]
George Harley closed HARMONY-451:
---------------------------------
Verified by Oliver.
> Consolidate icu4c zips
> ----------------------
>
> Key: HARMONY-451
> URL: http://issues.apache.org/jira/browse/HARMONY-451
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: George Harley
> Priority: Minor
> Attachments: consolidate.unicode.diff, icu4c.refactor.sh
>
> Currently we have two icu4c-3.4-harmony.zip files located at depends\oss\<OS>.IA32, where <OS> is win or linux. Inside these zips there are a lot of header files which are identical between the two platforms except for linux using #ifndef where windows uses #if !defined.
> This JIRA proposes that the contents of these two zips are combined into a single zip, and that at build time that zip has its contents placed into the native-src/<platform>/text/unicode directory, rather than native-src/<platform>/include/unicode, since it is only used by the text native component.
> I will attach a script to refactor the icu4c zips into a single one, and also a patch for the build scripts and text makefiles to pick up the new file locations.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-451) Consolidate icu4c zips
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-451?page=all ]
George Harley resolved HARMONY-451:
-----------------------------------
Resolution: Fixed
Hi Oliver,
Patch committed in revision 407035. Please could you check that it has been applied as expected.
Many thanks for this enhancement.
Best regards,
George
> Consolidate icu4c zips
> ----------------------
>
> Key: HARMONY-451
> URL: http://issues.apache.org/jira/browse/HARMONY-451
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: George Harley
> Priority: Minor
> Attachments: consolidate.unicode.diff, icu4c.refactor.sh
>
> Currently we have two icu4c-3.4-harmony.zip files located at depends\oss\<OS>.IA32, where <OS> is win or linux. Inside these zips there are a lot of header files which are identical between the two platforms except for linux using #ifndef where windows uses #if !defined.
> This JIRA proposes that the contents of these two zips are combined into a single zip, and that at build time that zip has its contents placed into the native-src/<platform>/text/unicode directory, rather than native-src/<platform>/include/unicode, since it is only used by the text native component.
> I will attach a script to refactor the icu4c zips into a single one, and also a patch for the build scripts and text makefiles to pick up the new file locations.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-451) Consolidate icu4c zips
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-451?page=all ]
Oliver Deakin updated HARMONY-451:
----------------------------------
Attachment: icu4c.refactor.sh
consolidate.unicode.diff
The icu4c.refactor.sh should be run inside a checked out classlib/trunk. It will unzip both the Windows and Linux icu4c zips into a directory under depends/oss, then rezip them into a single zip, after which it clears up the directory it was temporarily using.
consolidate.unicode.diff can be applied before or after the script is run, as it touches a disjoint set of files. It fixes up the build scripts to pick up the new single zip file, and alters them to unpack the zip under native-src/<platform>/text/unicode. Text makefiles have also been updated to reflect this new location.
> Consolidate icu4c zips
> ----------------------
>
> Key: HARMONY-451
> URL: http://issues.apache.org/jira/browse/HARMONY-451
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Oliver Deakin
> Priority: Minor
> Attachments: consolidate.unicode.diff, icu4c.refactor.sh
>
> Currently we have two icu4c-3.4-harmony.zip files located at depends\oss\<OS>.IA32, where <OS> is win or linux. Inside these zips there are a lot of header files which are identical between the two platforms except for linux using #ifndef where windows uses #if !defined.
> This JIRA proposes that the contents of these two zips are combined into a single zip, and that at build time that zip has its contents placed into the native-src/<platform>/text/unicode directory, rather than native-src/<platform>/include/unicode, since it is only used by the text native component.
> I will attach a script to refactor the icu4c zips into a single one, and also a patch for the build scripts and text makefiles to pick up the new file locations.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-451) Consolidate icu4c zips
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-451?page=comments#action_12412122 ]
Oliver Deakin commented on HARMONY-451:
---------------------------------------
That looks good, thanks for applying the patch George.
> Consolidate icu4c zips
> ----------------------
>
> Key: HARMONY-451
> URL: http://issues.apache.org/jira/browse/HARMONY-451
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Oliver Deakin
> Assignee: George Harley
> Priority: Minor
> Attachments: consolidate.unicode.diff, icu4c.refactor.sh
>
> Currently we have two icu4c-3.4-harmony.zip files located at depends\oss\<OS>.IA32, where <OS> is win or linux. Inside these zips there are a lot of header files which are identical between the two platforms except for linux using #ifndef where windows uses #if !defined.
> This JIRA proposes that the contents of these two zips are combined into a single zip, and that at build time that zip has its contents placed into the native-src/<platform>/text/unicode directory, rather than native-src/<platform>/include/unicode, since it is only used by the text native component.
> I will attach a script to refactor the icu4c zips into a single one, and also a patch for the build scripts and text makefiles to pick up the new file locations.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira