You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/10/11 18:42:12 UTC
[GitHub] [incubator-tvm] u99127 opened a new pull request #5519: [RFC] Make tflite frontend more data driven / improve errors.
u99127 opened a new pull request #5519:
URL: https://github.com/apache/incubator-tvm/pull/5519
This is a draft PR and only for discussion but not for merging as is.
These are a couple of commits that show a proof of concept about how we could restructure and improve the tflite frontend. I've lightly tested these by compiling a couple of tflite models to give me some confidence that they work. If this looks reasonable I'm happy to pull things out into separate individual pull requests that could allow us to migrate to this with newer operators that get added and refactor the existing operators in a piecemeal fashion with time and availability of folks.
The first commit tries to make the tflite operator table more data driven, the observation being that the common case is that of input and output operands being subject to an equality check that we can commonize into the top level. This means we can reduce the number of individual checks in every helper function and thus making it simpler for our developers to add new operators.
The second commit here shows another aspect of the tflite frontend which is the use of asserts instead of using tvm.error . If we have a set of errors that can be raised by the various frontends attached to tvm, we should use them more efficiently.
Thanks,
Ramana
@tqchen , @anijain2305 , @FrozenGene - comments / reviews would be welcome.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen closed pull request #5519: [RFC] Make tflite frontend more data driven / improve errors.
Posted by GitBox <gi...@apache.org>.
tqchen closed pull request #5519:
URL: https://github.com/apache/incubator-tvm/pull/5519
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] maheshambule commented on pull request #5519: [RFC] Make tflite frontend more data driven / improve errors.
Posted by GitBox <gi...@apache.org>.
maheshambule commented on pull request #5519:
URL: https://github.com/apache/incubator-tvm/pull/5519#issuecomment-624668257
@u99127, I am also working on refactoring TFLite frontend. This is a sample implementation https://github.com/apache/incubator-tvm/pull/5528. I would love to hear your opinion on it.
I am using a decorator to do all the checks, common stuff, and dynamic imports of options APIs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org