You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spamassassin.apache.org by mm...@apache.org on 2009/09/30 17:20:41 UTC

svn commit: r820297 - in /spamassassin/trunk: lib/Mail/SpamAssassin/BayesStore/BDB.pm xt/60_perlcritic.t

Author: mmartinec
Date: Wed Sep 30 15:20:41 2009
New Revision: 820297

URL: http://svn.apache.org/viewvc?rev=820297&view=rev
Log:
Deal with BayesStore/BDB.pm, removing another exception from
xt/60_perlcritic.t: Variables::ProhibitConditionalDeclarations

Modified:
    spamassassin/trunk/lib/Mail/SpamAssassin/BayesStore/BDB.pm
    spamassassin/trunk/xt/60_perlcritic.t

Modified: spamassassin/trunk/lib/Mail/SpamAssassin/BayesStore/BDB.pm
URL: http://svn.apache.org/viewvc/spamassassin/trunk/lib/Mail/SpamAssassin/BayesStore/BDB.pm?rev=820297&r1=820296&r2=820297&view=diff
==============================================================================
--- spamassassin/trunk/lib/Mail/SpamAssassin/BayesStore/BDB.pm (original)
+++ spamassassin/trunk/lib/Mail/SpamAssassin/BayesStore/BDB.pm Wed Sep 30 15:20:41 2009
@@ -705,7 +705,8 @@
   dbg("bayes: Entering get_running_expire_tok");
 
   my $value = $self->_get(vars => "RUNNING_EXPIRE") || "";
-  my $result = $value if $value =~ /^\d+$/;
+  my $result;
+  $result = $value if $value =~ /^\d+$/;
 
   dbg("bayes: get_running_expire_tok exiting with %s",
       !defined $result ? 'UNDEF' : $result);

Modified: spamassassin/trunk/xt/60_perlcritic.t
URL: http://svn.apache.org/viewvc/spamassassin/trunk/xt/60_perlcritic.t?rev=820297&r1=820296&r2=820297&view=diff
==============================================================================
--- spamassassin/trunk/xt/60_perlcritic.t (original)
+++ spamassassin/trunk/xt/60_perlcritic.t Wed Sep 30 15:20:41 2009
@@ -29,7 +29,7 @@
 
   severity = 5
   verbose = 10
-  exclude = ValuesAndExpressions::ProhibitLeadingZeros InputOutput::ProhibitBarewordFileHandles InputOutput::ProhibitTwoArgOpen TestingAndDebugging::RequireUseStrict Subroutines::ProhibitExplicitReturnUndef  Variables::RequireLexicalLoopIterators Subroutines::ProhibitSubroutinePrototypes ControlStructures::ProhibitMutatingListFunctions BuiltinFunctions::ProhibitStringyEval TestingAndDebugging::ProhibitNoStrict BuiltinFunctions::RequireGlobFunction Variables::ProhibitConditionalDeclarations InputOutput::ProhibitInteractiveTest 
+  exclude = ValuesAndExpressions::ProhibitLeadingZeros InputOutput::ProhibitBarewordFileHandles InputOutput::ProhibitTwoArgOpen TestingAndDebugging::RequireUseStrict Subroutines::ProhibitExplicitReturnUndef  Variables::RequireLexicalLoopIterators Subroutines::ProhibitSubroutinePrototypes ControlStructures::ProhibitMutatingListFunctions BuiltinFunctions::ProhibitStringyEval TestingAndDebugging::ProhibitNoStrict BuiltinFunctions::RequireGlobFunction InputOutput::ProhibitInteractiveTest 
 
 };
 close RC;