You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Jaideep dhok <ja...@inmobi.com> on 2015/03/25 11:15:43 UTC
Review Request 32478: LENS-349 : Hive driver jars should get
refreshed with db switches
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32478/
-----------------------------------------------------------
Review request for lens and Amareshwari Sriramadasu.
Bugs: LENS-349
https://issues.apache.org/jira/browse/LENS-349
Repository: lens
Description
-------
1. Set database in AbstractQueryContext at construction time. This will make sure that database used at the time of query submission is also used at the time of query execution
2. HiveDriver will maintain one session for a lens session + database name pair.
3. Borrowed some code related to closing class loaders and tests from the previous patch.
Reply
Diffs
-----
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java fd294664aaac300c4e3036dab8796dd228fb03e1
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 9e3c72393c1d9634b4ae03301b5d620b647df7ae
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8a5839b01ad20fc6ff030d55788ceb2c368d7f69
lens-driver-jdbc/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 523356903933af37eb9b1deca805cc8ae76a4cbb
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 390071cdd40ccc0308a4a58852e9dbfcbddabc3a
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 8c970821015b04e4adaff7d2949520ea5a0c4c82
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 20856a09610d76ca8072851e00125fc50aa4343c
lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java e44816372e889bdc7ce2ac34a43048e8af85181e
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 14a4eb2f09ad07bd6592f9f2e7ebff02080e0d14
lens-server/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
lens-server/testdata/serde.jar ec86e49a0be7cb9872756a4313ae81bd3cb5e543
lens-server/testdata/test.jar 1644d8cada37749f6a8c3a2a6c26b752ea7bac0f
Diff: https://reviews.apache.org/r/32478/diff/
Testing
-------
Changed existing test for db jars to validate db switch
Awaiting test output
Thanks,
Jaideep dhok
Re: Review Request 32478: LENS-349 : Hive driver jars should get
refreshed with db switches
Posted by Jaideep dhok <ja...@inmobi.com>.
> On March 26, 2015, 6:40 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java, line 317
> > <https://reviews.apache.org/r/32478/diff/2/?file=905290#file905290line317>
> >
> > Also, can we change this log to debug? Seeing this on every acquire
ok
- Jaideep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32478/#review77874
-----------------------------------------------------------
On March 25, 2015, 12:14 p.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32478/
> -----------------------------------------------------------
>
> (Updated March 25, 2015, 12:14 p.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-349
> https://issues.apache.org/jira/browse/LENS-349
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Set database in AbstractQueryContext at construction time. This will make sure that database used at the time of query submission is also used at the time of query execution
> 2. HiveDriver will maintain one session for a lens session + database name pair.
> 3. Borrowed some code related to closing class loaders and tests from the previous patch.
> Reply
>
>
> Diffs
> -----
>
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 81a536ed8ac3f7ea550794cf188db6ea9d599c7d
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 9e3c72393c1d9634b4ae03301b5d620b647df7ae
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8a5839b01ad20fc6ff030d55788ceb2c368d7f69
> lens-driver-jdbc/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 523356903933af37eb9b1deca805cc8ae76a4cbb
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 390071cdd40ccc0308a4a58852e9dbfcbddabc3a
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 8c970821015b04e4adaff7d2949520ea5a0c4c82
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 20856a09610d76ca8072851e00125fc50aa4343c
> lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java e44816372e889bdc7ce2ac34a43048e8af85181e
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 14a4eb2f09ad07bd6592f9f2e7ebff02080e0d14
> lens-server/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server/testdata/serde.jar ec86e49a0be7cb9872756a4313ae81bd3cb5e543
> lens-server/testdata/test.jar 1644d8cada37749f6a8c3a2a6c26b752ea7bac0f
>
> Diff: https://reviews.apache.org/r/32478/diff/
>
>
> Testing
> -------
>
> Changed existing test for db jars to validate db switch
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.190s]
> [INFO] Lens .............................................. SUCCESS [2.156s]
> [INFO] Lens API .......................................... SUCCESS [5.066s]
> [INFO] Lens API for server and extensions ................ SUCCESS [8.147s]
> [INFO] Lens Cube ......................................... SUCCESS [2:06.284s]
> [INFO] Lens DB storage ................................... SUCCESS [10.328s]
> [INFO] Lens Query Library ................................ SUCCESS [4.587s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:33.251s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [18.763s]
> [INFO] Lens Server ....................................... SUCCESS [5:46.309s]
> [INFO] Lens client ....................................... SUCCESS [20.491s]
> [INFO] Lens CLI .......................................... SUCCESS [2:28.343s]
> [INFO] Lens Examples ..................................... SUCCESS [0.998s]
> [INFO] Lens Distribution ................................. SUCCESS [10.435s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:01.982s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.541s]
> [INFO] Lens Regression ................................... SUCCESS [0.453s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:23.313s
> [INFO] Finished at: Wed Mar 25 12:11:23 UTC 2015
> [INFO] Final Memory: 97M/990M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 32478: LENS-349 : Hive driver jars should get
refreshed with db switches
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32478/#review77874
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java
<https://reviews.apache.org/r/32478/#comment126210>
Also, can we change this log to debug? Seeing this on every acquire
- Amareshwari Sriramadasu
On March 25, 2015, 12:14 p.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32478/
> -----------------------------------------------------------
>
> (Updated March 25, 2015, 12:14 p.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-349
> https://issues.apache.org/jira/browse/LENS-349
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Set database in AbstractQueryContext at construction time. This will make sure that database used at the time of query submission is also used at the time of query execution
> 2. HiveDriver will maintain one session for a lens session + database name pair.
> 3. Borrowed some code related to closing class loaders and tests from the previous patch.
> Reply
>
>
> Diffs
> -----
>
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 81a536ed8ac3f7ea550794cf188db6ea9d599c7d
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 9e3c72393c1d9634b4ae03301b5d620b647df7ae
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8a5839b01ad20fc6ff030d55788ceb2c368d7f69
> lens-driver-jdbc/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 523356903933af37eb9b1deca805cc8ae76a4cbb
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 390071cdd40ccc0308a4a58852e9dbfcbddabc3a
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 8c970821015b04e4adaff7d2949520ea5a0c4c82
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 20856a09610d76ca8072851e00125fc50aa4343c
> lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java e44816372e889bdc7ce2ac34a43048e8af85181e
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 14a4eb2f09ad07bd6592f9f2e7ebff02080e0d14
> lens-server/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server/testdata/serde.jar ec86e49a0be7cb9872756a4313ae81bd3cb5e543
> lens-server/testdata/test.jar 1644d8cada37749f6a8c3a2a6c26b752ea7bac0f
>
> Diff: https://reviews.apache.org/r/32478/diff/
>
>
> Testing
> -------
>
> Changed existing test for db jars to validate db switch
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.190s]
> [INFO] Lens .............................................. SUCCESS [2.156s]
> [INFO] Lens API .......................................... SUCCESS [5.066s]
> [INFO] Lens API for server and extensions ................ SUCCESS [8.147s]
> [INFO] Lens Cube ......................................... SUCCESS [2:06.284s]
> [INFO] Lens DB storage ................................... SUCCESS [10.328s]
> [INFO] Lens Query Library ................................ SUCCESS [4.587s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:33.251s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [18.763s]
> [INFO] Lens Server ....................................... SUCCESS [5:46.309s]
> [INFO] Lens client ....................................... SUCCESS [20.491s]
> [INFO] Lens CLI .......................................... SUCCESS [2:28.343s]
> [INFO] Lens Examples ..................................... SUCCESS [0.998s]
> [INFO] Lens Distribution ................................. SUCCESS [10.435s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:01.982s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.541s]
> [INFO] Lens Regression ................................... SUCCESS [0.453s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:23.313s
> [INFO] Finished at: Wed Mar 25 12:11:23 UTC 2015
> [INFO] Final Memory: 97M/990M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 32478: LENS-349 : Hive driver jars should get
refreshed with db switches
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On March 26, 2015, 5:57 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java, line 141
> > <https://reviews.apache.org/r/32478/diff/2/?file=905288#file905288line141>
> >
> > Can this be moved to method and called from getter when database is null aswell as in the constructor?
> >
> > For the queries submitted with old instance of server, database wouldnt have been restored upon restart.
>
> Jaideep dhok wrote:
> I didn't understand this, could you please clarify a bit. We are restoring databases on sessions while restarting server. See HiveSessionService.start
I meant earlier verison of lens which did not persist the database in the QueryContext
> On March 26, 2015, 5:57 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java, line 173
> > <https://reviews.apache.org/r/32478/diff/2/?file=905290#file905290line173>
> >
> > sessionDbClassLoaders are only cache coming from DatabaseResourceService.
> >
> > Closing these in session.close() would make them no longer accessible for other sessions. Isnt it?
>
> Jaideep dhok wrote:
> This is only per session cache. This only contains _merged_ class loaders which are DB class loader + session jar class loader. DB only class loaders which are maintained by DatabaseResourceService are not closed.
Here is the code flow I see :
private void updateSessionDbClassLoader(String database) {
ClassLoader updatedClassLoader = getDbResService().loadDBJars(database, persistInfo.getResources());
if (updatedClassLoader != null) {
sessionDbClassLoaders.put(database, updatedClassLoader);
}
}
protected synchronized ClassLoader loadDBJars(String database, Collection<LensSessionImpl.ResourceEntry> resources,
boolean addToCache) {
ClassLoader classLoader = classLoaderCache.get(database);
if (classLoader == null) {
// No change since there are no static resources to be added
return null;
}
if (resources == null || resources.isEmpty()) {
// Return DB class loader directly since no resources have to be merged.
return classLoader;
}
.....
}
If resources are empty, the classloader in sessionDbClassLoaders is the dbclassloader.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32478/#review77867
-----------------------------------------------------------
On March 25, 2015, 12:14 p.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32478/
> -----------------------------------------------------------
>
> (Updated March 25, 2015, 12:14 p.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-349
> https://issues.apache.org/jira/browse/LENS-349
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Set database in AbstractQueryContext at construction time. This will make sure that database used at the time of query submission is also used at the time of query execution
> 2. HiveDriver will maintain one session for a lens session + database name pair.
> 3. Borrowed some code related to closing class loaders and tests from the previous patch.
> Reply
>
>
> Diffs
> -----
>
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 81a536ed8ac3f7ea550794cf188db6ea9d599c7d
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 9e3c72393c1d9634b4ae03301b5d620b647df7ae
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8a5839b01ad20fc6ff030d55788ceb2c368d7f69
> lens-driver-jdbc/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 523356903933af37eb9b1deca805cc8ae76a4cbb
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 390071cdd40ccc0308a4a58852e9dbfcbddabc3a
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 8c970821015b04e4adaff7d2949520ea5a0c4c82
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 20856a09610d76ca8072851e00125fc50aa4343c
> lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java e44816372e889bdc7ce2ac34a43048e8af85181e
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 14a4eb2f09ad07bd6592f9f2e7ebff02080e0d14
> lens-server/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server/testdata/serde.jar ec86e49a0be7cb9872756a4313ae81bd3cb5e543
> lens-server/testdata/test.jar 1644d8cada37749f6a8c3a2a6c26b752ea7bac0f
>
> Diff: https://reviews.apache.org/r/32478/diff/
>
>
> Testing
> -------
>
> Changed existing test for db jars to validate db switch
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.190s]
> [INFO] Lens .............................................. SUCCESS [2.156s]
> [INFO] Lens API .......................................... SUCCESS [5.066s]
> [INFO] Lens API for server and extensions ................ SUCCESS [8.147s]
> [INFO] Lens Cube ......................................... SUCCESS [2:06.284s]
> [INFO] Lens DB storage ................................... SUCCESS [10.328s]
> [INFO] Lens Query Library ................................ SUCCESS [4.587s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:33.251s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [18.763s]
> [INFO] Lens Server ....................................... SUCCESS [5:46.309s]
> [INFO] Lens client ....................................... SUCCESS [20.491s]
> [INFO] Lens CLI .......................................... SUCCESS [2:28.343s]
> [INFO] Lens Examples ..................................... SUCCESS [0.998s]
> [INFO] Lens Distribution ................................. SUCCESS [10.435s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:01.982s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.541s]
> [INFO] Lens Regression ................................... SUCCESS [0.453s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:23.313s
> [INFO] Finished at: Wed Mar 25 12:11:23 UTC 2015
> [INFO] Final Memory: 97M/990M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 32478: LENS-349 : Hive driver jars should get
refreshed with db switches
Posted by Jaideep dhok <ja...@inmobi.com>.
> On March 26, 2015, 5:57 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java, line 141
> > <https://reviews.apache.org/r/32478/diff/2/?file=905288#file905288line141>
> >
> > Can this be moved to method and called from getter when database is null aswell as in the constructor?
> >
> > For the queries submitted with old instance of server, database wouldnt have been restored upon restart.
I didn't understand this, could you please clarify a bit. We are restoring databases on sessions while restarting server. See HiveSessionService.start
> On March 26, 2015, 5:57 a.m., Amareshwari Sriramadasu wrote:
> > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, line 144
> > <https://reviews.apache.org/r/32478/diff/2/?file=905285#file905285line144>
> >
> > By making one hive session for one lens-session +db, the session jar/auxialiary jars in session are getting tied to one particular db corresponding to the db at 'add jar' call?
Yes this is missed. Will fix it.
> On March 26, 2015, 5:57 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java, line 173
> > <https://reviews.apache.org/r/32478/diff/2/?file=905290#file905290line173>
> >
> > sessionDbClassLoaders are only cache coming from DatabaseResourceService.
> >
> > Closing these in session.close() would make them no longer accessible for other sessions. Isnt it?
This is only per session cache. This only contains _merged_ class loaders which are DB class loader + session jar class loader. DB only class loaders which are maintained by DatabaseResourceService are not closed.
- Jaideep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32478/#review77867
-----------------------------------------------------------
On March 25, 2015, 12:14 p.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32478/
> -----------------------------------------------------------
>
> (Updated March 25, 2015, 12:14 p.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-349
> https://issues.apache.org/jira/browse/LENS-349
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Set database in AbstractQueryContext at construction time. This will make sure that database used at the time of query submission is also used at the time of query execution
> 2. HiveDriver will maintain one session for a lens session + database name pair.
> 3. Borrowed some code related to closing class loaders and tests from the previous patch.
> Reply
>
>
> Diffs
> -----
>
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 81a536ed8ac3f7ea550794cf188db6ea9d599c7d
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 9e3c72393c1d9634b4ae03301b5d620b647df7ae
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8a5839b01ad20fc6ff030d55788ceb2c368d7f69
> lens-driver-jdbc/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 523356903933af37eb9b1deca805cc8ae76a4cbb
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 390071cdd40ccc0308a4a58852e9dbfcbddabc3a
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 8c970821015b04e4adaff7d2949520ea5a0c4c82
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 20856a09610d76ca8072851e00125fc50aa4343c
> lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java e44816372e889bdc7ce2ac34a43048e8af85181e
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 14a4eb2f09ad07bd6592f9f2e7ebff02080e0d14
> lens-server/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server/testdata/serde.jar ec86e49a0be7cb9872756a4313ae81bd3cb5e543
> lens-server/testdata/test.jar 1644d8cada37749f6a8c3a2a6c26b752ea7bac0f
>
> Diff: https://reviews.apache.org/r/32478/diff/
>
>
> Testing
> -------
>
> Changed existing test for db jars to validate db switch
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.190s]
> [INFO] Lens .............................................. SUCCESS [2.156s]
> [INFO] Lens API .......................................... SUCCESS [5.066s]
> [INFO] Lens API for server and extensions ................ SUCCESS [8.147s]
> [INFO] Lens Cube ......................................... SUCCESS [2:06.284s]
> [INFO] Lens DB storage ................................... SUCCESS [10.328s]
> [INFO] Lens Query Library ................................ SUCCESS [4.587s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:33.251s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [18.763s]
> [INFO] Lens Server ....................................... SUCCESS [5:46.309s]
> [INFO] Lens client ....................................... SUCCESS [20.491s]
> [INFO] Lens CLI .......................................... SUCCESS [2:28.343s]
> [INFO] Lens Examples ..................................... SUCCESS [0.998s]
> [INFO] Lens Distribution ................................. SUCCESS [10.435s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:01.982s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.541s]
> [INFO] Lens Regression ................................... SUCCESS [0.453s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:23.313s
> [INFO] Finished at: Wed Mar 25 12:11:23 UTC 2015
> [INFO] Final Memory: 97M/990M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 32478: LENS-349 : Hive driver jars should get
refreshed with db switches
Posted by Jaideep dhok <ja...@inmobi.com>.
> On March 26, 2015, 5:57 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java, line 173
> > <https://reviews.apache.org/r/32478/diff/2/?file=905290#file905290line173>
> >
> > sessionDbClassLoaders are only cache coming from DatabaseResourceService.
> >
> > Closing these in session.close() would make them no longer accessible for other sessions. Isnt it?
>
> Jaideep dhok wrote:
> This is only per session cache. This only contains _merged_ class loaders which are DB class loader + session jar class loader. DB only class loaders which are maintained by DatabaseResourceService are not closed.
>
> Amareshwari Sriramadasu wrote:
> Here is the code flow I see :
>
> private void updateSessionDbClassLoader(String database) {
> ClassLoader updatedClassLoader = getDbResService().loadDBJars(database, persistInfo.getResources());
> if (updatedClassLoader != null) {
> sessionDbClassLoaders.put(database, updatedClassLoader);
> }
> }
>
> protected synchronized ClassLoader loadDBJars(String database, Collection<LensSessionImpl.ResourceEntry> resources,
> boolean addToCache) {
> ClassLoader classLoader = classLoaderCache.get(database);
> if (classLoader == null) {
> // No change since there are no static resources to be added
> return null;
> }
>
> if (resources == null || resources.isEmpty()) {
> // Return DB class loader directly since no resources have to be merged.
> return classLoader;
> }
> .....
> }
>
> If resources are empty, the classloader in sessionDbClassLoaders is the dbclassloader.
Ok will add an extra check while closing class loaders.
- Jaideep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32478/#review77867
-----------------------------------------------------------
On March 25, 2015, 12:14 p.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32478/
> -----------------------------------------------------------
>
> (Updated March 25, 2015, 12:14 p.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-349
> https://issues.apache.org/jira/browse/LENS-349
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Set database in AbstractQueryContext at construction time. This will make sure that database used at the time of query submission is also used at the time of query execution
> 2. HiveDriver will maintain one session for a lens session + database name pair.
> 3. Borrowed some code related to closing class loaders and tests from the previous patch.
> Reply
>
>
> Diffs
> -----
>
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 81a536ed8ac3f7ea550794cf188db6ea9d599c7d
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 9e3c72393c1d9634b4ae03301b5d620b647df7ae
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8a5839b01ad20fc6ff030d55788ceb2c368d7f69
> lens-driver-jdbc/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 523356903933af37eb9b1deca805cc8ae76a4cbb
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 390071cdd40ccc0308a4a58852e9dbfcbddabc3a
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 8c970821015b04e4adaff7d2949520ea5a0c4c82
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 20856a09610d76ca8072851e00125fc50aa4343c
> lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java e44816372e889bdc7ce2ac34a43048e8af85181e
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 14a4eb2f09ad07bd6592f9f2e7ebff02080e0d14
> lens-server/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server/testdata/serde.jar ec86e49a0be7cb9872756a4313ae81bd3cb5e543
> lens-server/testdata/test.jar 1644d8cada37749f6a8c3a2a6c26b752ea7bac0f
>
> Diff: https://reviews.apache.org/r/32478/diff/
>
>
> Testing
> -------
>
> Changed existing test for db jars to validate db switch
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.190s]
> [INFO] Lens .............................................. SUCCESS [2.156s]
> [INFO] Lens API .......................................... SUCCESS [5.066s]
> [INFO] Lens API for server and extensions ................ SUCCESS [8.147s]
> [INFO] Lens Cube ......................................... SUCCESS [2:06.284s]
> [INFO] Lens DB storage ................................... SUCCESS [10.328s]
> [INFO] Lens Query Library ................................ SUCCESS [4.587s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:33.251s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [18.763s]
> [INFO] Lens Server ....................................... SUCCESS [5:46.309s]
> [INFO] Lens client ....................................... SUCCESS [20.491s]
> [INFO] Lens CLI .......................................... SUCCESS [2:28.343s]
> [INFO] Lens Examples ..................................... SUCCESS [0.998s]
> [INFO] Lens Distribution ................................. SUCCESS [10.435s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:01.982s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.541s]
> [INFO] Lens Regression ................................... SUCCESS [0.453s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:23.313s
> [INFO] Finished at: Wed Mar 25 12:11:23 UTC 2015
> [INFO] Final Memory: 97M/990M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 32478: LENS-349 : Hive driver jars should get
refreshed with db switches
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32478/#review77867
-----------------------------------------------------------
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java
<https://reviews.apache.org/r/32478/#comment126191>
By making one hive session for one lens-session +db, the session jar/auxialiary jars in session are getting tied to one particular db corresponding to the db at 'add jar' call?
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java
<https://reviews.apache.org/r/32478/#comment126192>
Can this be moved to method and called from getter when database is null aswell as in the constructor?
For the queries submitted with old instance of server, database wouldnt have been restored upon restart.
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java
<https://reviews.apache.org/r/32478/#comment126194>
sessionDbClassLoaders are only cache coming from DatabaseResourceService.
Closing these in session.close() would make them no longer accessible for other sessions. Isnt it?
- Amareshwari Sriramadasu
On March 25, 2015, 12:14 p.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32478/
> -----------------------------------------------------------
>
> (Updated March 25, 2015, 12:14 p.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-349
> https://issues.apache.org/jira/browse/LENS-349
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Set database in AbstractQueryContext at construction time. This will make sure that database used at the time of query submission is also used at the time of query execution
> 2. HiveDriver will maintain one session for a lens session + database name pair.
> 3. Borrowed some code related to closing class loaders and tests from the previous patch.
> Reply
>
>
> Diffs
> -----
>
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 81a536ed8ac3f7ea550794cf188db6ea9d599c7d
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 9e3c72393c1d9634b4ae03301b5d620b647df7ae
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8a5839b01ad20fc6ff030d55788ceb2c368d7f69
> lens-driver-jdbc/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 523356903933af37eb9b1deca805cc8ae76a4cbb
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 390071cdd40ccc0308a4a58852e9dbfcbddabc3a
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 8c970821015b04e4adaff7d2949520ea5a0c4c82
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 20856a09610d76ca8072851e00125fc50aa4343c
> lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java e44816372e889bdc7ce2ac34a43048e8af85181e
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 14a4eb2f09ad07bd6592f9f2e7ebff02080e0d14
> lens-server/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server/testdata/serde.jar ec86e49a0be7cb9872756a4313ae81bd3cb5e543
> lens-server/testdata/test.jar 1644d8cada37749f6a8c3a2a6c26b752ea7bac0f
>
> Diff: https://reviews.apache.org/r/32478/diff/
>
>
> Testing
> -------
>
> Changed existing test for db jars to validate db switch
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.190s]
> [INFO] Lens .............................................. SUCCESS [2.156s]
> [INFO] Lens API .......................................... SUCCESS [5.066s]
> [INFO] Lens API for server and extensions ................ SUCCESS [8.147s]
> [INFO] Lens Cube ......................................... SUCCESS [2:06.284s]
> [INFO] Lens DB storage ................................... SUCCESS [10.328s]
> [INFO] Lens Query Library ................................ SUCCESS [4.587s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:33.251s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [18.763s]
> [INFO] Lens Server ....................................... SUCCESS [5:46.309s]
> [INFO] Lens client ....................................... SUCCESS [20.491s]
> [INFO] Lens CLI .......................................... SUCCESS [2:28.343s]
> [INFO] Lens Examples ..................................... SUCCESS [0.998s]
> [INFO] Lens Distribution ................................. SUCCESS [10.435s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:01.982s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.541s]
> [INFO] Lens Regression ................................... SUCCESS [0.453s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:23.313s
> [INFO] Finished at: Wed Mar 25 12:11:23 UTC 2015
> [INFO] Final Memory: 97M/990M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 32478: LENS-349 : Hive driver jars should get
refreshed with db switches
Posted by Jaideep dhok <ja...@inmobi.com>.
> On March 26, 2015, 10:39 a.m., Rajat Khandelwal wrote:
> > lens-client/src/test/java/org/apache/lens/client/TestLensClient.java, line 83
> > <https://reviews.apache.org/r/32478/diff/2/?file=905284#file905284line83>
> >
> > Do we know why the old assert is failing?
This assert has to be changed everytime we create a new databse in tests so I am fixing that. After this we won't have to update the assert again if we add/remove some databases in tests, and it will be also safe from concurrent test runs.
> On March 26, 2015, 10:39 a.m., Rajat Khandelwal wrote:
> > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, line 720
> > <https://reviews.apache.org/r/32478/diff/2/?file=905285#file905285line720>
> >
> > name not required
will change var name.
- Jaideep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32478/#review77888
-----------------------------------------------------------
On March 25, 2015, 12:14 p.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32478/
> -----------------------------------------------------------
>
> (Updated March 25, 2015, 12:14 p.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-349
> https://issues.apache.org/jira/browse/LENS-349
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Set database in AbstractQueryContext at construction time. This will make sure that database used at the time of query submission is also used at the time of query execution
> 2. HiveDriver will maintain one session for a lens session + database name pair.
> 3. Borrowed some code related to closing class loaders and tests from the previous patch.
> Reply
>
>
> Diffs
> -----
>
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 81a536ed8ac3f7ea550794cf188db6ea9d599c7d
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 9e3c72393c1d9634b4ae03301b5d620b647df7ae
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8a5839b01ad20fc6ff030d55788ceb2c368d7f69
> lens-driver-jdbc/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 523356903933af37eb9b1deca805cc8ae76a4cbb
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 390071cdd40ccc0308a4a58852e9dbfcbddabc3a
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 8c970821015b04e4adaff7d2949520ea5a0c4c82
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 20856a09610d76ca8072851e00125fc50aa4343c
> lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java e44816372e889bdc7ce2ac34a43048e8af85181e
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 14a4eb2f09ad07bd6592f9f2e7ebff02080e0d14
> lens-server/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server/testdata/serde.jar ec86e49a0be7cb9872756a4313ae81bd3cb5e543
> lens-server/testdata/test.jar 1644d8cada37749f6a8c3a2a6c26b752ea7bac0f
>
> Diff: https://reviews.apache.org/r/32478/diff/
>
>
> Testing
> -------
>
> Changed existing test for db jars to validate db switch
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.190s]
> [INFO] Lens .............................................. SUCCESS [2.156s]
> [INFO] Lens API .......................................... SUCCESS [5.066s]
> [INFO] Lens API for server and extensions ................ SUCCESS [8.147s]
> [INFO] Lens Cube ......................................... SUCCESS [2:06.284s]
> [INFO] Lens DB storage ................................... SUCCESS [10.328s]
> [INFO] Lens Query Library ................................ SUCCESS [4.587s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:33.251s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [18.763s]
> [INFO] Lens Server ....................................... SUCCESS [5:46.309s]
> [INFO] Lens client ....................................... SUCCESS [20.491s]
> [INFO] Lens CLI .......................................... SUCCESS [2:28.343s]
> [INFO] Lens Examples ..................................... SUCCESS [0.998s]
> [INFO] Lens Distribution ................................. SUCCESS [10.435s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:01.982s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.541s]
> [INFO] Lens Regression ................................... SUCCESS [0.453s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:23.313s
> [INFO] Finished at: Wed Mar 25 12:11:23 UTC 2015
> [INFO] Final Memory: 97M/990M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 32478: LENS-349 : Hive driver jars should get
refreshed with db switches
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32478/#review77888
-----------------------------------------------------------
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java
<https://reviews.apache.org/r/32478/#comment126229>
Do we know why the old assert is failing?
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java
<https://reviews.apache.org/r/32478/#comment126230>
name not required
- Rajat Khandelwal
On March 25, 2015, 5:44 p.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32478/
> -----------------------------------------------------------
>
> (Updated March 25, 2015, 5:44 p.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-349
> https://issues.apache.org/jira/browse/LENS-349
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Set database in AbstractQueryContext at construction time. This will make sure that database used at the time of query submission is also used at the time of query execution
> 2. HiveDriver will maintain one session for a lens session + database name pair.
> 3. Borrowed some code related to closing class loaders and tests from the previous patch.
> Reply
>
>
> Diffs
> -----
>
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 81a536ed8ac3f7ea550794cf188db6ea9d599c7d
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 9e3c72393c1d9634b4ae03301b5d620b647df7ae
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8a5839b01ad20fc6ff030d55788ceb2c368d7f69
> lens-driver-jdbc/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 523356903933af37eb9b1deca805cc8ae76a4cbb
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 390071cdd40ccc0308a4a58852e9dbfcbddabc3a
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 8c970821015b04e4adaff7d2949520ea5a0c4c82
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 20856a09610d76ca8072851e00125fc50aa4343c
> lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java e44816372e889bdc7ce2ac34a43048e8af85181e
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 14a4eb2f09ad07bd6592f9f2e7ebff02080e0d14
> lens-server/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server/testdata/serde.jar ec86e49a0be7cb9872756a4313ae81bd3cb5e543
> lens-server/testdata/test.jar 1644d8cada37749f6a8c3a2a6c26b752ea7bac0f
>
> Diff: https://reviews.apache.org/r/32478/diff/
>
>
> Testing
> -------
>
> Changed existing test for db jars to validate db switch
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.190s]
> [INFO] Lens .............................................. SUCCESS [2.156s]
> [INFO] Lens API .......................................... SUCCESS [5.066s]
> [INFO] Lens API for server and extensions ................ SUCCESS [8.147s]
> [INFO] Lens Cube ......................................... SUCCESS [2:06.284s]
> [INFO] Lens DB storage ................................... SUCCESS [10.328s]
> [INFO] Lens Query Library ................................ SUCCESS [4.587s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:33.251s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [18.763s]
> [INFO] Lens Server ....................................... SUCCESS [5:46.309s]
> [INFO] Lens client ....................................... SUCCESS [20.491s]
> [INFO] Lens CLI .......................................... SUCCESS [2:28.343s]
> [INFO] Lens Examples ..................................... SUCCESS [0.998s]
> [INFO] Lens Distribution ................................. SUCCESS [10.435s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:01.982s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.541s]
> [INFO] Lens Regression ................................... SUCCESS [0.453s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:23.313s
> [INFO] Finished at: Wed Mar 25 12:11:23 UTC 2015
> [INFO] Final Memory: 97M/990M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 32478: LENS-349 : Hive driver jars should get
refreshed with db switches
Posted by Jaideep dhok <ja...@inmobi.com>.
> On March 27, 2015, 10:53 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, lines 2437-2447
> > <https://reviews.apache.org/r/32478/diff/4/?file=907668#file907668line2437>
> >
> > https://issues.apache.org/jira/browse/LENS-301 will be taken care with this?
Fixed as part of latest change.
- Jaideep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32478/#review78029
-----------------------------------------------------------
On March 27, 2015, 11:49 a.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32478/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 11:49 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-349
> https://issues.apache.org/jira/browse/LENS-349
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Set database in AbstractQueryContext at construction time. This will make sure that database used at the time of query submission is also used at the time of query execution
> 2. HiveDriver will maintain one session for a lens session + database name pair.
> 3. Borrowed some code related to closing class loaders and tests from the previous patch.
> Reply
>
>
> Diffs
> -----
>
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 81a536ed8ac3f7ea550794cf188db6ea9d599c7d
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 9e3c72393c1d9634b4ae03301b5d620b647df7ae
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8a5839b01ad20fc6ff030d55788ceb2c368d7f69
> lens-driver-jdbc/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 523356903933af37eb9b1deca805cc8ae76a4cbb
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 390071cdd40ccc0308a4a58852e9dbfcbddabc3a
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 8c970821015b04e4adaff7d2949520ea5a0c4c82
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 20856a09610d76ca8072851e00125fc50aa4343c
> lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java e44816372e889bdc7ce2ac34a43048e8af85181e
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 6306b51cdf2607c9762aec522d663019b202760f
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 14a4eb2f09ad07bd6592f9f2e7ebff02080e0d14
> lens-server/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server/testdata/serde.jar ec86e49a0be7cb9872756a4313ae81bd3cb5e543
> lens-server/testdata/test.jar 1644d8cada37749f6a8c3a2a6c26b752ea7bac0f
>
> Diff: https://reviews.apache.org/r/32478/diff/
>
>
> Testing
> -------
>
> Changed existing test for db jars to validate db switch
> Latest results after lazy add change
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.314s]
> [INFO] Lens .............................................. SUCCESS [2.023s]
> [INFO] Lens API .......................................... SUCCESS [5.038s]
> [INFO] Lens API for server and extensions ................ SUCCESS [7.293s]
> [INFO] Lens Cube ......................................... SUCCESS [2:03.134s]
> [INFO] Lens DB storage ................................... SUCCESS [9.614s]
> [INFO] Lens Query Library ................................ SUCCESS [4.771s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:33.396s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [17.050s]
> [INFO] Lens Server ....................................... SUCCESS [5:49.935s]
> [INFO] Lens client ....................................... SUCCESS [21.035s]
> [INFO] Lens CLI .......................................... SUCCESS [3:04.331s]
> [INFO] Lens Examples ..................................... SUCCESS [0.857s]
> [INFO] Lens Distribution ................................. SUCCESS [10.009s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:01.179s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.539s]
> [INFO] Lens Regression ................................... SUCCESS [0.467s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:55.934s
> [INFO] Finished at: Fri Mar 27 11:43:57 UTC 2015
> [INFO] Final Memory: 97M/1110M
> [INFO] ------------------------------------------------------------------------
> [SLOCCount] Report successfully processed and all data stored
> Recording test results
> Finished: SUCCESS
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 32478: LENS-349 : Hive driver jars should get
refreshed with db switches
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32478/#review78029
-----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java
<https://reviews.apache.org/r/32478/#comment126421>
can the same SessionState.get() code be here? This is actually giving wrong db, by giving default
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
<https://reviews.apache.org/r/32478/#comment126422>
https://issues.apache.org/jira/browse/LENS-301 will be taken care with this?
- Amareshwari Sriramadasu
On March 27, 2015, 10:41 a.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32478/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 10:41 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-349
> https://issues.apache.org/jira/browse/LENS-349
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Set database in AbstractQueryContext at construction time. This will make sure that database used at the time of query submission is also used at the time of query execution
> 2. HiveDriver will maintain one session for a lens session + database name pair.
> 3. Borrowed some code related to closing class loaders and tests from the previous patch.
> Reply
>
>
> Diffs
> -----
>
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 81a536ed8ac3f7ea550794cf188db6ea9d599c7d
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 9e3c72393c1d9634b4ae03301b5d620b647df7ae
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8a5839b01ad20fc6ff030d55788ceb2c368d7f69
> lens-driver-jdbc/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 523356903933af37eb9b1deca805cc8ae76a4cbb
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 390071cdd40ccc0308a4a58852e9dbfcbddabc3a
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 8c970821015b04e4adaff7d2949520ea5a0c4c82
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 20856a09610d76ca8072851e00125fc50aa4343c
> lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java e44816372e889bdc7ce2ac34a43048e8af85181e
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 14a4eb2f09ad07bd6592f9f2e7ebff02080e0d14
> lens-server/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server/testdata/serde.jar ec86e49a0be7cb9872756a4313ae81bd3cb5e543
> lens-server/testdata/test.jar 1644d8cada37749f6a8c3a2a6c26b752ea7bac0f
>
> Diff: https://reviews.apache.org/r/32478/diff/
>
>
> Testing
> -------
>
> Changed existing test for db jars to validate db switch
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.087s]
> [INFO] Lens .............................................. SUCCESS [1.810s]
> [INFO] Lens API .......................................... SUCCESS [5.499s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.904s]
> [INFO] Lens Cube ......................................... SUCCESS [2:17.874s]
> [INFO] Lens DB storage ................................... SUCCESS [15.951s]
> [INFO] Lens Query Library ................................ SUCCESS [6.794s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:39.982s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [17.581s]
> [INFO] Lens Server ....................................... SUCCESS [5:29.163s]
> [INFO] Lens client ....................................... SUCCESS [20.579s]
> [INFO] Lens CLI .......................................... SUCCESS [2:41.566s]
> [INFO] Lens Examples ..................................... SUCCESS [0.809s]
> [INFO] Lens Distribution ................................. SUCCESS [10.192s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:03.257s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.610s]
> [INFO] Lens Regression ................................... SUCCESS [0.461s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:44.150s
> [INFO] Finished at: Fri Mar 27 10:35:15 UTC 2015
> [INFO] Final Memory: 107M/1280M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 32478: LENS-349 : Hive driver jars should get
refreshed with db switches
Posted by Himanshu Gahlaut <ga...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32478/#review78103
-----------------------------------------------------------
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java
<https://reviews.apache.org/r/32478/#comment126551>
Javadoc can be improved to include change in implementation of this method.
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
<https://reviews.apache.org/r/32478/#comment126553>
areDBRsources => areDBResources ? Appears to be a typo.
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
<https://reviews.apache.org/r/32478/#comment126556>
CollectionUtils.isNotEmpty can be used here.
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
<https://reviews.apache.org/r/32478/#comment126555>
As LensSessionImpl.ResourceEntry is getting repeated multiple times. A static import for ResourceEntry would reduce code here.
- Himanshu Gahlaut
On March 27, 2015, 11:49 a.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32478/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 11:49 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-349
> https://issues.apache.org/jira/browse/LENS-349
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Set database in AbstractQueryContext at construction time. This will make sure that database used at the time of query submission is also used at the time of query execution
> 2. HiveDriver will maintain one session for a lens session + database name pair.
> 3. Borrowed some code related to closing class loaders and tests from the previous patch.
> Reply
>
>
> Diffs
> -----
>
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 81a536ed8ac3f7ea550794cf188db6ea9d599c7d
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 9e3c72393c1d9634b4ae03301b5d620b647df7ae
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8a5839b01ad20fc6ff030d55788ceb2c368d7f69
> lens-driver-jdbc/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 523356903933af37eb9b1deca805cc8ae76a4cbb
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 390071cdd40ccc0308a4a58852e9dbfcbddabc3a
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 8c970821015b04e4adaff7d2949520ea5a0c4c82
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 20856a09610d76ca8072851e00125fc50aa4343c
> lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java e44816372e889bdc7ce2ac34a43048e8af85181e
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 6306b51cdf2607c9762aec522d663019b202760f
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 14a4eb2f09ad07bd6592f9f2e7ebff02080e0d14
> lens-server/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server/testdata/serde.jar ec86e49a0be7cb9872756a4313ae81bd3cb5e543
> lens-server/testdata/test.jar 1644d8cada37749f6a8c3a2a6c26b752ea7bac0f
>
> Diff: https://reviews.apache.org/r/32478/diff/
>
>
> Testing
> -------
>
> Changed existing test for db jars to validate db switch
> Latest results after lazy add change
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.314s]
> [INFO] Lens .............................................. SUCCESS [2.023s]
> [INFO] Lens API .......................................... SUCCESS [5.038s]
> [INFO] Lens API for server and extensions ................ SUCCESS [7.293s]
> [INFO] Lens Cube ......................................... SUCCESS [2:03.134s]
> [INFO] Lens DB storage ................................... SUCCESS [9.614s]
> [INFO] Lens Query Library ................................ SUCCESS [4.771s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:33.396s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [17.050s]
> [INFO] Lens Server ....................................... SUCCESS [5:49.935s]
> [INFO] Lens client ....................................... SUCCESS [21.035s]
> [INFO] Lens CLI .......................................... SUCCESS [3:04.331s]
> [INFO] Lens Examples ..................................... SUCCESS [0.857s]
> [INFO] Lens Distribution ................................. SUCCESS [10.009s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:01.179s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.539s]
> [INFO] Lens Regression ................................... SUCCESS [0.467s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:55.934s
> [INFO] Finished at: Fri Mar 27 11:43:57 UTC 2015
> [INFO] Final Memory: 97M/1110M
> [INFO] ------------------------------------------------------------------------
> [SLOCCount] Report successfully processed and all data stored
> Recording test results
> Finished: SUCCESS
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 32478: LENS-349 : Hive driver jars should get
refreshed with db switches
Posted by Jaideep dhok <ja...@inmobi.com>.
> On March 27, 2015, 12:02 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, line 2426
> > <https://reviews.apache.org/r/32478/diff/5/?file=907681#file907681line2426>
> >
> > Why are these resources being removed? They are actully getting removed from underlying session.getDBResources
It's a copy of db resources not affecting original resource list from db resource service.
- Jaideep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32478/#review78034
-----------------------------------------------------------
On March 27, 2015, 11:49 a.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32478/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 11:49 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-349
> https://issues.apache.org/jira/browse/LENS-349
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Set database in AbstractQueryContext at construction time. This will make sure that database used at the time of query submission is also used at the time of query execution
> 2. HiveDriver will maintain one session for a lens session + database name pair.
> 3. Borrowed some code related to closing class loaders and tests from the previous patch.
> Reply
>
>
> Diffs
> -----
>
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 81a536ed8ac3f7ea550794cf188db6ea9d599c7d
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 9e3c72393c1d9634b4ae03301b5d620b647df7ae
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8a5839b01ad20fc6ff030d55788ceb2c368d7f69
> lens-driver-jdbc/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 523356903933af37eb9b1deca805cc8ae76a4cbb
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 390071cdd40ccc0308a4a58852e9dbfcbddabc3a
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 8c970821015b04e4adaff7d2949520ea5a0c4c82
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 20856a09610d76ca8072851e00125fc50aa4343c
> lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java e44816372e889bdc7ce2ac34a43048e8af85181e
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 6306b51cdf2607c9762aec522d663019b202760f
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 14a4eb2f09ad07bd6592f9f2e7ebff02080e0d14
> lens-server/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server/testdata/serde.jar ec86e49a0be7cb9872756a4313ae81bd3cb5e543
> lens-server/testdata/test.jar 1644d8cada37749f6a8c3a2a6c26b752ea7bac0f
>
> Diff: https://reviews.apache.org/r/32478/diff/
>
>
> Testing
> -------
>
> Changed existing test for db jars to validate db switch
> Latest results after lazy add change
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.314s]
> [INFO] Lens .............................................. SUCCESS [2.023s]
> [INFO] Lens API .......................................... SUCCESS [5.038s]
> [INFO] Lens API for server and extensions ................ SUCCESS [7.293s]
> [INFO] Lens Cube ......................................... SUCCESS [2:03.134s]
> [INFO] Lens DB storage ................................... SUCCESS [9.614s]
> [INFO] Lens Query Library ................................ SUCCESS [4.771s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:33.396s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [17.050s]
> [INFO] Lens Server ....................................... SUCCESS [5:49.935s]
> [INFO] Lens client ....................................... SUCCESS [21.035s]
> [INFO] Lens CLI .......................................... SUCCESS [3:04.331s]
> [INFO] Lens Examples ..................................... SUCCESS [0.857s]
> [INFO] Lens Distribution ................................. SUCCESS [10.009s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:01.179s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.539s]
> [INFO] Lens Regression ................................... SUCCESS [0.467s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:55.934s
> [INFO] Finished at: Fri Mar 27 11:43:57 UTC 2015
> [INFO] Final Memory: 97M/1110M
> [INFO] ------------------------------------------------------------------------
> [SLOCCount] Report successfully processed and all data stored
> Recording test results
> Finished: SUCCESS
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 32478: LENS-349 : Hive driver jars should get
refreshed with db switches
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32478/#review78034
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
<https://reviews.apache.org/r/32478/#comment126424>
This would also be removed?
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
<https://reviews.apache.org/r/32478/#comment126425>
Why are these resources being removed? They are actully getting removed from underlying session.getDBResources
- Amareshwari Sriramadasu
On March 27, 2015, 11:49 a.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32478/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 11:49 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-349
> https://issues.apache.org/jira/browse/LENS-349
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Set database in AbstractQueryContext at construction time. This will make sure that database used at the time of query submission is also used at the time of query execution
> 2. HiveDriver will maintain one session for a lens session + database name pair.
> 3. Borrowed some code related to closing class loaders and tests from the previous patch.
> Reply
>
>
> Diffs
> -----
>
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 81a536ed8ac3f7ea550794cf188db6ea9d599c7d
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 9e3c72393c1d9634b4ae03301b5d620b647df7ae
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8a5839b01ad20fc6ff030d55788ceb2c368d7f69
> lens-driver-jdbc/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 523356903933af37eb9b1deca805cc8ae76a4cbb
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 390071cdd40ccc0308a4a58852e9dbfcbddabc3a
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 8c970821015b04e4adaff7d2949520ea5a0c4c82
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 20856a09610d76ca8072851e00125fc50aa4343c
> lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java e44816372e889bdc7ce2ac34a43048e8af85181e
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 6306b51cdf2607c9762aec522d663019b202760f
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 14a4eb2f09ad07bd6592f9f2e7ebff02080e0d14
> lens-server/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server/testdata/serde.jar ec86e49a0be7cb9872756a4313ae81bd3cb5e543
> lens-server/testdata/test.jar 1644d8cada37749f6a8c3a2a6c26b752ea7bac0f
>
> Diff: https://reviews.apache.org/r/32478/diff/
>
>
> Testing
> -------
>
> Changed existing test for db jars to validate db switch
> Latest results after lazy add change
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.314s]
> [INFO] Lens .............................................. SUCCESS [2.023s]
> [INFO] Lens API .......................................... SUCCESS [5.038s]
> [INFO] Lens API for server and extensions ................ SUCCESS [7.293s]
> [INFO] Lens Cube ......................................... SUCCESS [2:03.134s]
> [INFO] Lens DB storage ................................... SUCCESS [9.614s]
> [INFO] Lens Query Library ................................ SUCCESS [4.771s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:33.396s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [17.050s]
> [INFO] Lens Server ....................................... SUCCESS [5:49.935s]
> [INFO] Lens client ....................................... SUCCESS [21.035s]
> [INFO] Lens CLI .......................................... SUCCESS [3:04.331s]
> [INFO] Lens Examples ..................................... SUCCESS [0.857s]
> [INFO] Lens Distribution ................................. SUCCESS [10.009s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:01.179s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.539s]
> [INFO] Lens Regression ................................... SUCCESS [0.467s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:55.934s
> [INFO] Finished at: Fri Mar 27 11:43:57 UTC 2015
> [INFO] Final Memory: 97M/1110M
> [INFO] ------------------------------------------------------------------------
> [SLOCCount] Report successfully processed and all data stored
> Recording test results
> Finished: SUCCESS
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 32478: LENS-349 : Hive driver jars should get
refreshed with db switches
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32478/#review78180
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On March 30, 2015, 8:06 a.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32478/
> -----------------------------------------------------------
>
> (Updated March 30, 2015, 8:06 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-349
> https://issues.apache.org/jira/browse/LENS-349
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Set database in AbstractQueryContext at construction time. This will make sure that database used at the time of query submission is also used at the time of query execution
> 2. HiveDriver will maintain one session for a lens session + database name pair.
> 3. Borrowed some code related to closing class loaders and tests from the previous patch.
> Reply
>
>
> Diffs
> -----
>
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 81a536ed8ac3f7ea550794cf188db6ea9d599c7d
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 218dc53145398f1fc584efa6160c49fb6b8f2d0c
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java b16c34665c9cceeb40cbd0d633a5f8d2802de381
> lens-driver-jdbc/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 6799e0c7a0f487280a581b9ba034f70a1c814418
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ea2da14f51dc0eb4f0e06e73ae7752f1fe5cb769
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 8c970821015b04e4adaff7d2949520ea5a0c4c82
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 20856a09610d76ca8072851e00125fc50aa4343c
> lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java e44816372e889bdc7ce2ac34a43048e8af85181e
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 6306b51cdf2607c9762aec522d663019b202760f
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java e3e3d4baf43f67f96687b47b3273046e24720254
> lens-server/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server/testdata/serde.jar ec86e49a0be7cb9872756a4313ae81bd3cb5e543
> lens-server/testdata/test.jar 1644d8cada37749f6a8c3a2a6c26b752ea7bac0f
>
> Diff: https://reviews.apache.org/r/32478/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [23.993s]
> [INFO] Lens .............................................. SUCCESS [24.084s]
> [INFO] Lens API .......................................... SUCCESS [13.620s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.656s]
> [INFO] Lens Cube ......................................... SUCCESS [3:16.315s]
> [INFO] Lens DB storage ................................... SUCCESS [17.831s]
> [INFO] Lens Query Library ................................ SUCCESS [10.164s]
> [INFO] Lens Hive Driver .................................. SUCCESS [4:12.615s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [27.693s]
> [INFO] Lens Server ....................................... SUCCESS [19:58.109s]
> [INFO] Lens client ....................................... SUCCESS [31.580s]
> [INFO] Lens CLI .......................................... SUCCESS [6:33.093s]
> [INFO] Lens Examples ..................................... SUCCESS [3.288s]
> [INFO] Lens Distribution ................................. SUCCESS [18.011s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:30.753s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [10.808s]
> [INFO] Lens Regression ................................... SUCCESS [0.643s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 39:55.049s
> [INFO] Finished at: Mon Mar 30 13:33:40 IST 2015
> [INFO] Final Memory: 128M/840M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 32478: LENS-349 : Hive driver jars should get
refreshed with db switches
Posted by Himanshu Gahlaut <ga...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32478/#review78184
-----------------------------------------------------------
Ship it!
Ship It!
- Himanshu Gahlaut
On March 30, 2015, 8:06 a.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32478/
> -----------------------------------------------------------
>
> (Updated March 30, 2015, 8:06 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-349
> https://issues.apache.org/jira/browse/LENS-349
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Set database in AbstractQueryContext at construction time. This will make sure that database used at the time of query submission is also used at the time of query execution
> 2. HiveDriver will maintain one session for a lens session + database name pair.
> 3. Borrowed some code related to closing class loaders and tests from the previous patch.
> Reply
>
>
> Diffs
> -----
>
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 81a536ed8ac3f7ea550794cf188db6ea9d599c7d
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 218dc53145398f1fc584efa6160c49fb6b8f2d0c
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java b16c34665c9cceeb40cbd0d633a5f8d2802de381
> lens-driver-jdbc/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 6799e0c7a0f487280a581b9ba034f70a1c814418
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ea2da14f51dc0eb4f0e06e73ae7752f1fe5cb769
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 8c970821015b04e4adaff7d2949520ea5a0c4c82
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 20856a09610d76ca8072851e00125fc50aa4343c
> lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java e44816372e889bdc7ce2ac34a43048e8af85181e
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 6306b51cdf2607c9762aec522d663019b202760f
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java e3e3d4baf43f67f96687b47b3273046e24720254
> lens-server/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server/testdata/serde.jar ec86e49a0be7cb9872756a4313ae81bd3cb5e543
> lens-server/testdata/test.jar 1644d8cada37749f6a8c3a2a6c26b752ea7bac0f
>
> Diff: https://reviews.apache.org/r/32478/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [23.993s]
> [INFO] Lens .............................................. SUCCESS [24.084s]
> [INFO] Lens API .......................................... SUCCESS [13.620s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.656s]
> [INFO] Lens Cube ......................................... SUCCESS [3:16.315s]
> [INFO] Lens DB storage ................................... SUCCESS [17.831s]
> [INFO] Lens Query Library ................................ SUCCESS [10.164s]
> [INFO] Lens Hive Driver .................................. SUCCESS [4:12.615s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [27.693s]
> [INFO] Lens Server ....................................... SUCCESS [19:58.109s]
> [INFO] Lens client ....................................... SUCCESS [31.580s]
> [INFO] Lens CLI .......................................... SUCCESS [6:33.093s]
> [INFO] Lens Examples ..................................... SUCCESS [3.288s]
> [INFO] Lens Distribution ................................. SUCCESS [18.011s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:30.753s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [10.808s]
> [INFO] Lens Regression ................................... SUCCESS [0.643s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 39:55.049s
> [INFO] Finished at: Mon Mar 30 13:33:40 IST 2015
> [INFO] Final Memory: 128M/840M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 32478: LENS-349 : Hive driver jars should get
refreshed with db switches
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32478/
-----------------------------------------------------------
(Updated March 30, 2015, 8:06 a.m.)
Review request for lens and Amareshwari Sriramadasu.
Changes
-------
rebased with master and review comments by Himanshu
Bugs: LENS-349
https://issues.apache.org/jira/browse/LENS-349
Repository: lens
Description
-------
1. Set database in AbstractQueryContext at construction time. This will make sure that database used at the time of query submission is also used at the time of query execution
2. HiveDriver will maintain one session for a lens session + database name pair.
3. Borrowed some code related to closing class loaders and tests from the previous patch.
Reply
Diffs (updated)
-----
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 81a536ed8ac3f7ea550794cf188db6ea9d599c7d
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 218dc53145398f1fc584efa6160c49fb6b8f2d0c
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java b16c34665c9cceeb40cbd0d633a5f8d2802de381
lens-driver-jdbc/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 6799e0c7a0f487280a581b9ba034f70a1c814418
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ea2da14f51dc0eb4f0e06e73ae7752f1fe5cb769
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 8c970821015b04e4adaff7d2949520ea5a0c4c82
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 20856a09610d76ca8072851e00125fc50aa4343c
lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java e44816372e889bdc7ce2ac34a43048e8af85181e
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 6306b51cdf2607c9762aec522d663019b202760f
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java e3e3d4baf43f67f96687b47b3273046e24720254
lens-server/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
lens-server/testdata/serde.jar ec86e49a0be7cb9872756a4313ae81bd3cb5e543
lens-server/testdata/test.jar 1644d8cada37749f6a8c3a2a6c26b752ea7bac0f
Diff: https://reviews.apache.org/r/32478/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [23.993s]
[INFO] Lens .............................................. SUCCESS [24.084s]
[INFO] Lens API .......................................... SUCCESS [13.620s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.656s]
[INFO] Lens Cube ......................................... SUCCESS [3:16.315s]
[INFO] Lens DB storage ................................... SUCCESS [17.831s]
[INFO] Lens Query Library ................................ SUCCESS [10.164s]
[INFO] Lens Hive Driver .................................. SUCCESS [4:12.615s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [27.693s]
[INFO] Lens Server ....................................... SUCCESS [19:58.109s]
[INFO] Lens client ....................................... SUCCESS [31.580s]
[INFO] Lens CLI .......................................... SUCCESS [6:33.093s]
[INFO] Lens Examples ..................................... SUCCESS [3.288s]
[INFO] Lens Distribution ................................. SUCCESS [18.011s]
[INFO] Lens ML Lib ....................................... SUCCESS [2:30.753s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [10.808s]
[INFO] Lens Regression ................................... SUCCESS [0.643s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 39:55.049s
[INFO] Finished at: Mon Mar 30 13:33:40 IST 2015
[INFO] Final Memory: 128M/840M
[INFO] ------------------------------------------------------------------------
Thanks,
Jaideep dhok
Re: Review Request 32478: LENS-349 : Hive driver jars should get
refreshed with db switches
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32478/#review78037
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On March 27, 2015, 11:49 a.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32478/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 11:49 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-349
> https://issues.apache.org/jira/browse/LENS-349
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Set database in AbstractQueryContext at construction time. This will make sure that database used at the time of query submission is also used at the time of query execution
> 2. HiveDriver will maintain one session for a lens session + database name pair.
> 3. Borrowed some code related to closing class loaders and tests from the previous patch.
> Reply
>
>
> Diffs
> -----
>
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 81a536ed8ac3f7ea550794cf188db6ea9d599c7d
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 9e3c72393c1d9634b4ae03301b5d620b647df7ae
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8a5839b01ad20fc6ff030d55788ceb2c368d7f69
> lens-driver-jdbc/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 523356903933af37eb9b1deca805cc8ae76a4cbb
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 390071cdd40ccc0308a4a58852e9dbfcbddabc3a
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 8c970821015b04e4adaff7d2949520ea5a0c4c82
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 20856a09610d76ca8072851e00125fc50aa4343c
> lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java e44816372e889bdc7ce2ac34a43048e8af85181e
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 6306b51cdf2607c9762aec522d663019b202760f
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 14a4eb2f09ad07bd6592f9f2e7ebff02080e0d14
> lens-server/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server/testdata/serde.jar ec86e49a0be7cb9872756a4313ae81bd3cb5e543
> lens-server/testdata/test.jar 1644d8cada37749f6a8c3a2a6c26b752ea7bac0f
>
> Diff: https://reviews.apache.org/r/32478/diff/
>
>
> Testing
> -------
>
> Changed existing test for db jars to validate db switch
> Latest results after lazy add change
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.314s]
> [INFO] Lens .............................................. SUCCESS [2.023s]
> [INFO] Lens API .......................................... SUCCESS [5.038s]
> [INFO] Lens API for server and extensions ................ SUCCESS [7.293s]
> [INFO] Lens Cube ......................................... SUCCESS [2:03.134s]
> [INFO] Lens DB storage ................................... SUCCESS [9.614s]
> [INFO] Lens Query Library ................................ SUCCESS [4.771s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:33.396s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [17.050s]
> [INFO] Lens Server ....................................... SUCCESS [5:49.935s]
> [INFO] Lens client ....................................... SUCCESS [21.035s]
> [INFO] Lens CLI .......................................... SUCCESS [3:04.331s]
> [INFO] Lens Examples ..................................... SUCCESS [0.857s]
> [INFO] Lens Distribution ................................. SUCCESS [10.009s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:01.179s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.539s]
> [INFO] Lens Regression ................................... SUCCESS [0.467s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:55.934s
> [INFO] Finished at: Fri Mar 27 11:43:57 UTC 2015
> [INFO] Final Memory: 97M/1110M
> [INFO] ------------------------------------------------------------------------
> [SLOCCount] Report successfully processed and all data stored
> Recording test results
> Finished: SUCCESS
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 32478: LENS-349 : Hive driver jars should get
refreshed with db switches
Posted by Jaideep dhok <ja...@inmobi.com>.
> On March 27, 2015, 7:55 p.m., Himanshu Gahlaut wrote:
> > lens-client/src/test/java/org/apache/lens/client/TestLensClient.java, line 85
> > <https://reviews.apache.org/r/32478/diff/5/?file=907676#file907676line85>
> >
> > client.getAllDatabases().contains("testclientdb") is repeating here.. can we reduce code by having a containsDatabase method in LensClient and and LensMetadataClient. This sort of style also improves datahiding because clients who need only search (contains) does not have to get exposed to entire database collection.
> >
> > public LensClient {
> >
> > public boolean containsDatabase(final String dbName) {
> > return mc.containsDatabase(dbName);
> > }
> > }
> >
> > public LensMetadataclient {
> > public boolean containsDatabase(final String dbName) {
> > return getAllDatabases(dbName).contains(dbName);
> > }
> > }
>
> Jaideep dhok wrote:
> We still needs to expose getAllDatabases (it's used to list all dbs in CLI), so contains call won't help much. All calls in LensClient are counterparts of their REST calls. However, I do feel we should add a 'database exists' call in the metastore resource.
>
> Himanshu Gahlaut wrote:
> Even if this change does not allow making getAllDatabases() private, creating a isExistsDatabase() call in LensClient would reduce code in calling classes. Instead of writing
> client.getAllDatabases().contains("testclientdb") ,
> we just have to write
> client.isExistsDatabase("testclientdb")
>
> a.getB().getC().performX() or a.getB().performY() leads to more code. Individually it looks like this chaining of getters does not add up more code but when this sort of thing is there at mulitple places, they collectively increase code and code becomes less readable. Also giving a name like isDatabaseExists to chain of getters makes the code more readable. However this could be my personal opinion as well. I understand that everyone might not find it less readable. Also your choice of name databaseExists is better than containsDatabase.
I aggree with the readability thing, but database exist call only in the client without a supporting server side call doesn't make sense. We should add a server side database exists call in metastore API and corresponding call in client. However, that is out of scope for this patch. We can take it up in another JIRA.
- Jaideep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32478/#review78100
-----------------------------------------------------------
On March 27, 2015, 11:49 a.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32478/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 11:49 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-349
> https://issues.apache.org/jira/browse/LENS-349
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Set database in AbstractQueryContext at construction time. This will make sure that database used at the time of query submission is also used at the time of query execution
> 2. HiveDriver will maintain one session for a lens session + database name pair.
> 3. Borrowed some code related to closing class loaders and tests from the previous patch.
> Reply
>
>
> Diffs
> -----
>
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 81a536ed8ac3f7ea550794cf188db6ea9d599c7d
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 9e3c72393c1d9634b4ae03301b5d620b647df7ae
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8a5839b01ad20fc6ff030d55788ceb2c368d7f69
> lens-driver-jdbc/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 523356903933af37eb9b1deca805cc8ae76a4cbb
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 390071cdd40ccc0308a4a58852e9dbfcbddabc3a
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 8c970821015b04e4adaff7d2949520ea5a0c4c82
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 20856a09610d76ca8072851e00125fc50aa4343c
> lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java e44816372e889bdc7ce2ac34a43048e8af85181e
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 6306b51cdf2607c9762aec522d663019b202760f
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 14a4eb2f09ad07bd6592f9f2e7ebff02080e0d14
> lens-server/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server/testdata/serde.jar ec86e49a0be7cb9872756a4313ae81bd3cb5e543
> lens-server/testdata/test.jar 1644d8cada37749f6a8c3a2a6c26b752ea7bac0f
>
> Diff: https://reviews.apache.org/r/32478/diff/
>
>
> Testing
> -------
>
> Changed existing test for db jars to validate db switch
> Latest results after lazy add change
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.314s]
> [INFO] Lens .............................................. SUCCESS [2.023s]
> [INFO] Lens API .......................................... SUCCESS [5.038s]
> [INFO] Lens API for server and extensions ................ SUCCESS [7.293s]
> [INFO] Lens Cube ......................................... SUCCESS [2:03.134s]
> [INFO] Lens DB storage ................................... SUCCESS [9.614s]
> [INFO] Lens Query Library ................................ SUCCESS [4.771s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:33.396s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [17.050s]
> [INFO] Lens Server ....................................... SUCCESS [5:49.935s]
> [INFO] Lens client ....................................... SUCCESS [21.035s]
> [INFO] Lens CLI .......................................... SUCCESS [3:04.331s]
> [INFO] Lens Examples ..................................... SUCCESS [0.857s]
> [INFO] Lens Distribution ................................. SUCCESS [10.009s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:01.179s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.539s]
> [INFO] Lens Regression ................................... SUCCESS [0.467s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:55.934s
> [INFO] Finished at: Fri Mar 27 11:43:57 UTC 2015
> [INFO] Final Memory: 97M/1110M
> [INFO] ------------------------------------------------------------------------
> [SLOCCount] Report successfully processed and all data stored
> Recording test results
> Finished: SUCCESS
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 32478: LENS-349 : Hive driver jars should get
refreshed with db switches
Posted by Himanshu Gahlaut <ga...@gmail.com>.
> On March 27, 2015, 7:55 p.m., Himanshu Gahlaut wrote:
> > lens-client/src/test/java/org/apache/lens/client/TestLensClient.java, line 85
> > <https://reviews.apache.org/r/32478/diff/5/?file=907676#file907676line85>
> >
> > client.getAllDatabases().contains("testclientdb") is repeating here.. can we reduce code by having a containsDatabase method in LensClient and and LensMetadataClient. This sort of style also improves datahiding because clients who need only search (contains) does not have to get exposed to entire database collection.
> >
> > public LensClient {
> >
> > public boolean containsDatabase(final String dbName) {
> > return mc.containsDatabase(dbName);
> > }
> > }
> >
> > public LensMetadataclient {
> > public boolean containsDatabase(final String dbName) {
> > return getAllDatabases(dbName).contains(dbName);
> > }
> > }
>
> Jaideep dhok wrote:
> We still needs to expose getAllDatabases (it's used to list all dbs in CLI), so contains call won't help much. All calls in LensClient are counterparts of their REST calls. However, I do feel we should add a 'database exists' call in the metastore resource.
Even if this change does not allow making getAllDatabases() private, creating a isExistsDatabase() call in LensClient would reduce code in calling classes. Instead of writing
client.getAllDatabases().contains("testclientdb") ,
we just have to write
client.isExistsDatabase("testclientdb")
a.getB().getC().performX() or a.getB().performY() leads to more code. Individually it looks like this chaining of getters does not add up more code but when this sort of thing is there at mulitple places, they collectively increase code and code becomes less readable. Also giving a name like isDatabaseExists to chain of getters makes the code more readable. However this could be my personal opinion as well. I understand that everyone might not find it less readable. Also your choice of name databaseExists is better than containsDatabase.
- Himanshu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32478/#review78100
-----------------------------------------------------------
On March 27, 2015, 11:49 a.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32478/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 11:49 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-349
> https://issues.apache.org/jira/browse/LENS-349
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Set database in AbstractQueryContext at construction time. This will make sure that database used at the time of query submission is also used at the time of query execution
> 2. HiveDriver will maintain one session for a lens session + database name pair.
> 3. Borrowed some code related to closing class loaders and tests from the previous patch.
> Reply
>
>
> Diffs
> -----
>
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 81a536ed8ac3f7ea550794cf188db6ea9d599c7d
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 9e3c72393c1d9634b4ae03301b5d620b647df7ae
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8a5839b01ad20fc6ff030d55788ceb2c368d7f69
> lens-driver-jdbc/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 523356903933af37eb9b1deca805cc8ae76a4cbb
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 390071cdd40ccc0308a4a58852e9dbfcbddabc3a
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 8c970821015b04e4adaff7d2949520ea5a0c4c82
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 20856a09610d76ca8072851e00125fc50aa4343c
> lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java e44816372e889bdc7ce2ac34a43048e8af85181e
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 6306b51cdf2607c9762aec522d663019b202760f
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 14a4eb2f09ad07bd6592f9f2e7ebff02080e0d14
> lens-server/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server/testdata/serde.jar ec86e49a0be7cb9872756a4313ae81bd3cb5e543
> lens-server/testdata/test.jar 1644d8cada37749f6a8c3a2a6c26b752ea7bac0f
>
> Diff: https://reviews.apache.org/r/32478/diff/
>
>
> Testing
> -------
>
> Changed existing test for db jars to validate db switch
> Latest results after lazy add change
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.314s]
> [INFO] Lens .............................................. SUCCESS [2.023s]
> [INFO] Lens API .......................................... SUCCESS [5.038s]
> [INFO] Lens API for server and extensions ................ SUCCESS [7.293s]
> [INFO] Lens Cube ......................................... SUCCESS [2:03.134s]
> [INFO] Lens DB storage ................................... SUCCESS [9.614s]
> [INFO] Lens Query Library ................................ SUCCESS [4.771s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:33.396s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [17.050s]
> [INFO] Lens Server ....................................... SUCCESS [5:49.935s]
> [INFO] Lens client ....................................... SUCCESS [21.035s]
> [INFO] Lens CLI .......................................... SUCCESS [3:04.331s]
> [INFO] Lens Examples ..................................... SUCCESS [0.857s]
> [INFO] Lens Distribution ................................. SUCCESS [10.009s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:01.179s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.539s]
> [INFO] Lens Regression ................................... SUCCESS [0.467s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:55.934s
> [INFO] Finished at: Fri Mar 27 11:43:57 UTC 2015
> [INFO] Final Memory: 97M/1110M
> [INFO] ------------------------------------------------------------------------
> [SLOCCount] Report successfully processed and all data stored
> Recording test results
> Finished: SUCCESS
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 32478: LENS-349 : Hive driver jars should get
refreshed with db switches
Posted by Jaideep dhok <ja...@inmobi.com>.
> On March 27, 2015, 7:55 p.m., Himanshu Gahlaut wrote:
> > lens-client/src/test/java/org/apache/lens/client/TestLensClient.java, line 85
> > <https://reviews.apache.org/r/32478/diff/5/?file=907676#file907676line85>
> >
> > client.getAllDatabases().contains("testclientdb") is repeating here.. can we reduce code by having a containsDatabase method in LensClient and and LensMetadataClient. This sort of style also improves datahiding because clients who need only search (contains) does not have to get exposed to entire database collection.
> >
> > public LensClient {
> >
> > public boolean containsDatabase(final String dbName) {
> > return mc.containsDatabase(dbName);
> > }
> > }
> >
> > public LensMetadataclient {
> > public boolean containsDatabase(final String dbName) {
> > return getAllDatabases(dbName).contains(dbName);
> > }
> > }
We still needs to expose getAllDatabases (it's used to list all dbs in CLI), so contains call won't help much. All calls in LensClient are counterparts of their REST calls. However, I do feel we should add a 'database exists' call in the metastore resource.
- Jaideep
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32478/#review78100
-----------------------------------------------------------
On March 27, 2015, 11:49 a.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32478/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 11:49 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-349
> https://issues.apache.org/jira/browse/LENS-349
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Set database in AbstractQueryContext at construction time. This will make sure that database used at the time of query submission is also used at the time of query execution
> 2. HiveDriver will maintain one session for a lens session + database name pair.
> 3. Borrowed some code related to closing class loaders and tests from the previous patch.
> Reply
>
>
> Diffs
> -----
>
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 81a536ed8ac3f7ea550794cf188db6ea9d599c7d
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 9e3c72393c1d9634b4ae03301b5d620b647df7ae
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8a5839b01ad20fc6ff030d55788ceb2c368d7f69
> lens-driver-jdbc/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 523356903933af37eb9b1deca805cc8ae76a4cbb
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 390071cdd40ccc0308a4a58852e9dbfcbddabc3a
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 8c970821015b04e4adaff7d2949520ea5a0c4c82
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 20856a09610d76ca8072851e00125fc50aa4343c
> lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java e44816372e889bdc7ce2ac34a43048e8af85181e
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 6306b51cdf2607c9762aec522d663019b202760f
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 14a4eb2f09ad07bd6592f9f2e7ebff02080e0d14
> lens-server/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server/testdata/serde.jar ec86e49a0be7cb9872756a4313ae81bd3cb5e543
> lens-server/testdata/test.jar 1644d8cada37749f6a8c3a2a6c26b752ea7bac0f
>
> Diff: https://reviews.apache.org/r/32478/diff/
>
>
> Testing
> -------
>
> Changed existing test for db jars to validate db switch
> Latest results after lazy add change
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.314s]
> [INFO] Lens .............................................. SUCCESS [2.023s]
> [INFO] Lens API .......................................... SUCCESS [5.038s]
> [INFO] Lens API for server and extensions ................ SUCCESS [7.293s]
> [INFO] Lens Cube ......................................... SUCCESS [2:03.134s]
> [INFO] Lens DB storage ................................... SUCCESS [9.614s]
> [INFO] Lens Query Library ................................ SUCCESS [4.771s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:33.396s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [17.050s]
> [INFO] Lens Server ....................................... SUCCESS [5:49.935s]
> [INFO] Lens client ....................................... SUCCESS [21.035s]
> [INFO] Lens CLI .......................................... SUCCESS [3:04.331s]
> [INFO] Lens Examples ..................................... SUCCESS [0.857s]
> [INFO] Lens Distribution ................................. SUCCESS [10.009s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:01.179s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.539s]
> [INFO] Lens Regression ................................... SUCCESS [0.467s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:55.934s
> [INFO] Finished at: Fri Mar 27 11:43:57 UTC 2015
> [INFO] Final Memory: 97M/1110M
> [INFO] ------------------------------------------------------------------------
> [SLOCCount] Report successfully processed and all data stored
> Recording test results
> Finished: SUCCESS
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 32478: LENS-349 : Hive driver jars should get
refreshed with db switches
Posted by Himanshu Gahlaut <ga...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32478/#review78100
-----------------------------------------------------------
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java
<https://reviews.apache.org/r/32478/#comment126547>
client.getAllDatabases().contains("testclientdb") is repeating here.. can we reduce code by having a containsDatabase method in LensClient and and LensMetadataClient. This sort of style also improves datahiding because clients who need only search (contains) does not have to get exposed to entire database collection.
public LensClient {
public boolean containsDatabase(final String dbName) {
return mc.containsDatabase(dbName);
}
}
public LensMetadataclient {
public boolean containsDatabase(final String dbName) {
return getAllDatabases(dbName).contains(dbName);
}
}
- Himanshu Gahlaut
On March 27, 2015, 11:49 a.m., Jaideep dhok wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32478/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 11:49 a.m.)
>
>
> Review request for lens and Amareshwari Sriramadasu.
>
>
> Bugs: LENS-349
> https://issues.apache.org/jira/browse/LENS-349
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Set database in AbstractQueryContext at construction time. This will make sure that database used at the time of query submission is also used at the time of query execution
> 2. HiveDriver will maintain one session for a lens session + database name pair.
> 3. Borrowed some code related to closing class loaders and tests from the previous patch.
> Reply
>
>
> Diffs
> -----
>
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 81a536ed8ac3f7ea550794cf188db6ea9d599c7d
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 9e3c72393c1d9634b4ae03301b5d620b647df7ae
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8a5839b01ad20fc6ff030d55788ceb2c368d7f69
> lens-driver-jdbc/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 523356903933af37eb9b1deca805cc8ae76a4cbb
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 390071cdd40ccc0308a4a58852e9dbfcbddabc3a
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 8c970821015b04e4adaff7d2949520ea5a0c4c82
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 20856a09610d76ca8072851e00125fc50aa4343c
> lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java e44816372e889bdc7ce2ac34a43048e8af85181e
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 6306b51cdf2607c9762aec522d663019b202760f
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 14a4eb2f09ad07bd6592f9f2e7ebff02080e0d14
> lens-server/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
> lens-server/testdata/serde.jar ec86e49a0be7cb9872756a4313ae81bd3cb5e543
> lens-server/testdata/test.jar 1644d8cada37749f6a8c3a2a6c26b752ea7bac0f
>
> Diff: https://reviews.apache.org/r/32478/diff/
>
>
> Testing
> -------
>
> Changed existing test for db jars to validate db switch
> Latest results after lazy add change
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.314s]
> [INFO] Lens .............................................. SUCCESS [2.023s]
> [INFO] Lens API .......................................... SUCCESS [5.038s]
> [INFO] Lens API for server and extensions ................ SUCCESS [7.293s]
> [INFO] Lens Cube ......................................... SUCCESS [2:03.134s]
> [INFO] Lens DB storage ................................... SUCCESS [9.614s]
> [INFO] Lens Query Library ................................ SUCCESS [4.771s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:33.396s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [17.050s]
> [INFO] Lens Server ....................................... SUCCESS [5:49.935s]
> [INFO] Lens client ....................................... SUCCESS [21.035s]
> [INFO] Lens CLI .......................................... SUCCESS [3:04.331s]
> [INFO] Lens Examples ..................................... SUCCESS [0.857s]
> [INFO] Lens Distribution ................................. SUCCESS [10.009s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:01.179s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.539s]
> [INFO] Lens Regression ................................... SUCCESS [0.467s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:55.934s
> [INFO] Finished at: Fri Mar 27 11:43:57 UTC 2015
> [INFO] Final Memory: 97M/1110M
> [INFO] ------------------------------------------------------------------------
> [SLOCCount] Report successfully processed and all data stored
> Recording test results
> Finished: SUCCESS
>
>
> Thanks,
>
> Jaideep dhok
>
>
Re: Review Request 32478: LENS-349 : Hive driver jars should get
refreshed with db switches
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32478/
-----------------------------------------------------------
(Updated March 27, 2015, 11:49 a.m.)
Review request for lens and Amareshwari Sriramadasu.
Changes
-------
Pass all jars lazily
Bugs: LENS-349
https://issues.apache.org/jira/browse/LENS-349
Repository: lens
Description
-------
1. Set database in AbstractQueryContext at construction time. This will make sure that database used at the time of query submission is also used at the time of query execution
2. HiveDriver will maintain one session for a lens session + database name pair.
3. Borrowed some code related to closing class loaders and tests from the previous patch.
Reply
Diffs (updated)
-----
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 81a536ed8ac3f7ea550794cf188db6ea9d599c7d
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 9e3c72393c1d9634b4ae03301b5d620b647df7ae
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8a5839b01ad20fc6ff030d55788ceb2c368d7f69
lens-driver-jdbc/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 523356903933af37eb9b1deca805cc8ae76a4cbb
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 390071cdd40ccc0308a4a58852e9dbfcbddabc3a
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 8c970821015b04e4adaff7d2949520ea5a0c4c82
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 20856a09610d76ca8072851e00125fc50aa4343c
lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java e44816372e889bdc7ce2ac34a43048e8af85181e
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 6306b51cdf2607c9762aec522d663019b202760f
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 14a4eb2f09ad07bd6592f9f2e7ebff02080e0d14
lens-server/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
lens-server/testdata/serde.jar ec86e49a0be7cb9872756a4313ae81bd3cb5e543
lens-server/testdata/test.jar 1644d8cada37749f6a8c3a2a6c26b752ea7bac0f
Diff: https://reviews.apache.org/r/32478/diff/
Testing (updated)
-------
Changed existing test for db jars to validate db switch
Latest results after lazy add change
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.314s]
[INFO] Lens .............................................. SUCCESS [2.023s]
[INFO] Lens API .......................................... SUCCESS [5.038s]
[INFO] Lens API for server and extensions ................ SUCCESS [7.293s]
[INFO] Lens Cube ......................................... SUCCESS [2:03.134s]
[INFO] Lens DB storage ................................... SUCCESS [9.614s]
[INFO] Lens Query Library ................................ SUCCESS [4.771s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:33.396s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [17.050s]
[INFO] Lens Server ....................................... SUCCESS [5:49.935s]
[INFO] Lens client ....................................... SUCCESS [21.035s]
[INFO] Lens CLI .......................................... SUCCESS [3:04.331s]
[INFO] Lens Examples ..................................... SUCCESS [0.857s]
[INFO] Lens Distribution ................................. SUCCESS [10.009s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:01.179s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.539s]
[INFO] Lens Regression ................................... SUCCESS [0.467s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15:55.934s
[INFO] Finished at: Fri Mar 27 11:43:57 UTC 2015
[INFO] Final Memory: 97M/1110M
[INFO] ------------------------------------------------------------------------
[SLOCCount] Report successfully processed and all data stored
Recording test results
Finished: SUCCESS
Thanks,
Jaideep dhok
Re: Review Request 32478: LENS-349 : Hive driver jars should get
refreshed with db switches
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32478/
-----------------------------------------------------------
(Updated March 27, 2015, 10:41 a.m.)
Review request for lens and Amareshwari Sriramadasu.
Bugs: LENS-349
https://issues.apache.org/jira/browse/LENS-349
Repository: lens
Description
-------
1. Set database in AbstractQueryContext at construction time. This will make sure that database used at the time of query submission is also used at the time of query execution
2. HiveDriver will maintain one session for a lens session + database name pair.
3. Borrowed some code related to closing class loaders and tests from the previous patch.
Reply
Diffs (updated)
-----
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 81a536ed8ac3f7ea550794cf188db6ea9d599c7d
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 9e3c72393c1d9634b4ae03301b5d620b647df7ae
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8a5839b01ad20fc6ff030d55788ceb2c368d7f69
lens-driver-jdbc/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 523356903933af37eb9b1deca805cc8ae76a4cbb
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 390071cdd40ccc0308a4a58852e9dbfcbddabc3a
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 8c970821015b04e4adaff7d2949520ea5a0c4c82
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 20856a09610d76ca8072851e00125fc50aa4343c
lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java e44816372e889bdc7ce2ac34a43048e8af85181e
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 14a4eb2f09ad07bd6592f9f2e7ebff02080e0d14
lens-server/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
lens-server/testdata/serde.jar ec86e49a0be7cb9872756a4313ae81bd3cb5e543
lens-server/testdata/test.jar 1644d8cada37749f6a8c3a2a6c26b752ea7bac0f
Diff: https://reviews.apache.org/r/32478/diff/
Testing
-------
Changed existing test for db jars to validate db switch
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.087s]
[INFO] Lens .............................................. SUCCESS [1.810s]
[INFO] Lens API .......................................... SUCCESS [5.499s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.904s]
[INFO] Lens Cube ......................................... SUCCESS [2:17.874s]
[INFO] Lens DB storage ................................... SUCCESS [15.951s]
[INFO] Lens Query Library ................................ SUCCESS [6.794s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:39.982s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [17.581s]
[INFO] Lens Server ....................................... SUCCESS [5:29.163s]
[INFO] Lens client ....................................... SUCCESS [20.579s]
[INFO] Lens CLI .......................................... SUCCESS [2:41.566s]
[INFO] Lens Examples ..................................... SUCCESS [0.809s]
[INFO] Lens Distribution ................................. SUCCESS [10.192s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:03.257s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.610s]
[INFO] Lens Regression ................................... SUCCESS [0.461s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15:44.150s
[INFO] Finished at: Fri Mar 27 10:35:15 UTC 2015
[INFO] Final Memory: 107M/1280M
[INFO] ------------------------------------------------------------------------
Thanks,
Jaideep dhok
Re: Review Request 32478: LENS-349 : Hive driver jars should get
refreshed with db switches
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32478/
-----------------------------------------------------------
(Updated March 27, 2015, 10:38 a.m.)
Review request for lens and Amareshwari Sriramadasu.
Changes
-------
Added test for sessions jars to be added after db switch.
Updated test results
Bugs: LENS-349
https://issues.apache.org/jira/browse/LENS-349
Repository: lens
Description
-------
1. Set database in AbstractQueryContext at construction time. This will make sure that database used at the time of query submission is also used at the time of query execution
2. HiveDriver will maintain one session for a lens session + database name pair.
3. Borrowed some code related to closing class loaders and tests from the previous patch.
Reply
Diffs
-----
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 81a536ed8ac3f7ea550794cf188db6ea9d599c7d
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 9e3c72393c1d9634b4ae03301b5d620b647df7ae
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8a5839b01ad20fc6ff030d55788ceb2c368d7f69
lens-driver-jdbc/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 523356903933af37eb9b1deca805cc8ae76a4cbb
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 390071cdd40ccc0308a4a58852e9dbfcbddabc3a
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 8c970821015b04e4adaff7d2949520ea5a0c4c82
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 20856a09610d76ca8072851e00125fc50aa4343c
lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java e44816372e889bdc7ce2ac34a43048e8af85181e
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 14a4eb2f09ad07bd6592f9f2e7ebff02080e0d14
lens-server/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
lens-server/testdata/serde.jar ec86e49a0be7cb9872756a4313ae81bd3cb5e543
lens-server/testdata/test.jar 1644d8cada37749f6a8c3a2a6c26b752ea7bac0f
Diff: https://reviews.apache.org/r/32478/diff/
Testing (updated)
-------
Changed existing test for db jars to validate db switch
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.087s]
[INFO] Lens .............................................. SUCCESS [1.810s]
[INFO] Lens API .......................................... SUCCESS [5.499s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.904s]
[INFO] Lens Cube ......................................... SUCCESS [2:17.874s]
[INFO] Lens DB storage ................................... SUCCESS [15.951s]
[INFO] Lens Query Library ................................ SUCCESS [6.794s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:39.982s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [17.581s]
[INFO] Lens Server ....................................... SUCCESS [5:29.163s]
[INFO] Lens client ....................................... SUCCESS [20.579s]
[INFO] Lens CLI .......................................... SUCCESS [2:41.566s]
[INFO] Lens Examples ..................................... SUCCESS [0.809s]
[INFO] Lens Distribution ................................. SUCCESS [10.192s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:03.257s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.610s]
[INFO] Lens Regression ................................... SUCCESS [0.461s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15:44.150s
[INFO] Finished at: Fri Mar 27 10:35:15 UTC 2015
[INFO] Final Memory: 107M/1280M
[INFO] ------------------------------------------------------------------------
Thanks,
Jaideep dhok
Re: Review Request 32478: LENS-349 : Hive driver jars should get
refreshed with db switches
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32478/
-----------------------------------------------------------
(Updated March 27, 2015, 9:25 a.m.)
Review request for lens and Amareshwari Sriramadasu.
Changes
-------
Review changes.
1. Add session resources while switching DB
2. Checking classloader before close.
Bugs: LENS-349
https://issues.apache.org/jira/browse/LENS-349
Repository: lens
Description
-------
1. Set database in AbstractQueryContext at construction time. This will make sure that database used at the time of query submission is also used at the time of query execution
2. HiveDriver will maintain one session for a lens session + database name pair.
3. Borrowed some code related to closing class loaders and tests from the previous patch.
Reply
Diffs (updated)
-----
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 81a536ed8ac3f7ea550794cf188db6ea9d599c7d
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 9e3c72393c1d9634b4ae03301b5d620b647df7ae
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8a5839b01ad20fc6ff030d55788ceb2c368d7f69
lens-driver-jdbc/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 523356903933af37eb9b1deca805cc8ae76a4cbb
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 390071cdd40ccc0308a4a58852e9dbfcbddabc3a
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 8c970821015b04e4adaff7d2949520ea5a0c4c82
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 20856a09610d76ca8072851e00125fc50aa4343c
lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java e44816372e889bdc7ce2ac34a43048e8af85181e
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 14a4eb2f09ad07bd6592f9f2e7ebff02080e0d14
lens-server/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
lens-server/testdata/serde.jar ec86e49a0be7cb9872756a4313ae81bd3cb5e543
lens-server/testdata/test.jar 1644d8cada37749f6a8c3a2a6c26b752ea7bac0f
Diff: https://reviews.apache.org/r/32478/diff/
Testing
-------
Changed existing test for db jars to validate db switch
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.190s]
[INFO] Lens .............................................. SUCCESS [2.156s]
[INFO] Lens API .......................................... SUCCESS [5.066s]
[INFO] Lens API for server and extensions ................ SUCCESS [8.147s]
[INFO] Lens Cube ......................................... SUCCESS [2:06.284s]
[INFO] Lens DB storage ................................... SUCCESS [10.328s]
[INFO] Lens Query Library ................................ SUCCESS [4.587s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:33.251s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [18.763s]
[INFO] Lens Server ....................................... SUCCESS [5:46.309s]
[INFO] Lens client ....................................... SUCCESS [20.491s]
[INFO] Lens CLI .......................................... SUCCESS [2:28.343s]
[INFO] Lens Examples ..................................... SUCCESS [0.998s]
[INFO] Lens Distribution ................................. SUCCESS [10.435s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:01.982s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.541s]
[INFO] Lens Regression ................................... SUCCESS [0.453s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15:23.313s
[INFO] Finished at: Wed Mar 25 12:11:23 UTC 2015
[INFO] Final Memory: 97M/990M
[INFO] ------------------------------------------------------------------------
Thanks,
Jaideep dhok
Re: Review Request 32478: LENS-349 : Hive driver jars should get
refreshed with db switches
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32478/
-----------------------------------------------------------
(Updated March 25, 2015, 12:14 p.m.)
Review request for lens and Amareshwari Sriramadasu.
Changes
-------
Fixed tests and checkstyle.
Bugs: LENS-349
https://issues.apache.org/jira/browse/LENS-349
Repository: lens
Description
-------
1. Set database in AbstractQueryContext at construction time. This will make sure that database used at the time of query submission is also used at the time of query execution
2. HiveDriver will maintain one session for a lens session + database name pair.
3. Borrowed some code related to closing class loaders and tests from the previous patch.
Reply
Diffs (updated)
-----
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java 81a536ed8ac3f7ea550794cf188db6ea9d599c7d
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 9e3c72393c1d9634b4ae03301b5d620b647df7ae
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 8a5839b01ad20fc6ff030d55788ceb2c368d7f69
lens-driver-jdbc/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 523356903933af37eb9b1deca805cc8ae76a4cbb
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 390071cdd40ccc0308a4a58852e9dbfcbddabc3a
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 8c970821015b04e4adaff7d2949520ea5a0c4c82
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 20856a09610d76ca8072851e00125fc50aa4343c
lens-server/src/test/java/org/apache/lens/server/LensTestUtil.java e44816372e889bdc7ce2ac34a43048e8af85181e
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 14a4eb2f09ad07bd6592f9f2e7ebff02080e0d14
lens-server/testdata/DatabaseJarSerde.java 03caff31916072b0e6944d1bd13161dca5cef878
lens-server/testdata/serde.jar ec86e49a0be7cb9872756a4313ae81bd3cb5e543
lens-server/testdata/test.jar 1644d8cada37749f6a8c3a2a6c26b752ea7bac0f
Diff: https://reviews.apache.org/r/32478/diff/
Testing (updated)
-------
Changed existing test for db jars to validate db switch
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.190s]
[INFO] Lens .............................................. SUCCESS [2.156s]
[INFO] Lens API .......................................... SUCCESS [5.066s]
[INFO] Lens API for server and extensions ................ SUCCESS [8.147s]
[INFO] Lens Cube ......................................... SUCCESS [2:06.284s]
[INFO] Lens DB storage ................................... SUCCESS [10.328s]
[INFO] Lens Query Library ................................ SUCCESS [4.587s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:33.251s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [18.763s]
[INFO] Lens Server ....................................... SUCCESS [5:46.309s]
[INFO] Lens client ....................................... SUCCESS [20.491s]
[INFO] Lens CLI .......................................... SUCCESS [2:28.343s]
[INFO] Lens Examples ..................................... SUCCESS [0.998s]
[INFO] Lens Distribution ................................. SUCCESS [10.435s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:01.982s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.541s]
[INFO] Lens Regression ................................... SUCCESS [0.453s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15:23.313s
[INFO] Finished at: Wed Mar 25 12:11:23 UTC 2015
[INFO] Final Memory: 97M/990M
[INFO] ------------------------------------------------------------------------
Thanks,
Jaideep dhok