You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/12 14:30:35 UTC
[GitHub] [spark] srowen commented on issue #26858: [SPARK-30120][ML] Use
BoundedPriorityQueue for small dataset in LSH approxNearestNeighbors
srowen commented on issue #26858: [SPARK-30120][ML] Use BoundedPriorityQueue for small dataset in LSH approxNearestNeighbors
URL: https://github.com/apache/spark/pull/26858#issuecomment-565029952
@zhengruifeng I think the logic does have to depend on the size of the dataset; you don't want to collect 10M elements to find 10 nearest neighbors. But I do think the priority queue size needs to be numNearestNeighbors, yes, if that's what you mean.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org