You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by gi...@git.apache.org on 2017/08/09 19:52:54 UTC

[GitHub] mdeuser commented on a change in pull request #2591: User-Agent CLI/version header

mdeuser commented on a change in pull request #2591: User-Agent CLI/version header
URL: https://github.com/apache/incubator-openwhisk/pull/2591#discussion_r132288455
 
 

 ##########
 File path: tools/cli/go-whisk-cli/main.go
 ##########
 @@ -48,6 +48,7 @@ func init() {
 
     // Rest of CLI uses the Properties struct, so set the build time there
     commands.Properties.CLIVersion = CLI_BUILD_TIME
+    os.Setenv("CLI_Version", CLI_BUILD_TIME)
 
 Review comment:
   avoid using "global" style variables.  instead set a value on the http config object during it's initialization
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services