[GitHub] andrzej-kaczmarek commented on a change in pull request #236: nimble/host: Allow auto-start to be disabled

[GitBox <gi...@apache.org>]

andrzej-kaczmarek commented on a change in pull request #236: nimble/host: Allow auto-start to be disabled
URL: https://github.com/apache/mynewt-nimble/pull/236#discussion_r230748188
 
 

 ##########
 File path: nimble/host/src/ble_hs.c
 ##########
 @@ -699,7 +710,10 @@ ble_hs_init(void)
      * the application to configure this package in the meantime.
      */
 #ifdef MYNEWT
-    ble_npl_eventq_put((struct ble_npl_eventq *)os_eventq_dflt_get(), &ble_hs_ev_start);
+#if MYNEWT_VAL(BLE_HS_AUTO_START)
 
 Review comment:
   I guess this `#if` should wrap complete `#if #else` instead of only mynewt-specific part since you also updated ports to work with this new setting

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services