You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/22 10:17:40 UTC
[GitHub] [skywalking] shink opened a new issue #7768: [Bug][Eyes] The `.ini` files with correct license header didn't pass skywalking-eys check
shink opened a new issue #7768:
URL: https://github.com/apache/skywalking/issues/7768
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues.
### Apache SkyWalking Component
License Tools (apache/skywalking-eyes)
### What happened
The `.ini` files with correct license header didn't pass skywalking-eys check.
For example, the `master.ini` header as following, but it didn't pass the check and doesn't support being automatically fixed.
```ini
;
; Licensed to the Apache Software Foundation (ASF) under one or more
; contributor license agreements. See the NOTICE file distributed with
; this work for additional information regarding copyright ownership.
; The ASF licenses this file to You under the Apache License, Version 2.0
; (the "License"); you may not use this file except in compliance with
; the License. You may obtain a copy of the License at
;
; http://www.apache.org/licenses/LICENSE-2.0
;
; Unless required by applicable law or agreed to in writing, software
; distributed under the License is distributed on an "AS IS" BASIS,
; WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
; See the License for the specific language governing permissions and
; limitations under the License.
;
```
### What you expected to happen
There are some source files have common license header, but all `.ini` files didn't pass the check.
### How to reproduce
Please see https://github.com/apache/incubator-inlong/pull/1572
### Anything else
_No response_
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] shink commented on issue #7768: [Bug][Eyes] The `.ini` files with correct license header didn't pass skywalking-eys check
Posted by GitBox <gi...@apache.org>.
shink commented on issue #7768:
URL: https://github.com/apache/skywalking/issues/7768#issuecomment-924974564
@wu-sheng Thank you very much! And the license header in `cmd` type files must be start with `@rem`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #7768: [Bug][Eyes] The `.ini` files with correct license header didn't pass skywalking-eys check
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #7768:
URL: https://github.com/apache/skywalking/issues/7768#issuecomment-925449676
`.ini`, `.cmd` and `.bat` are all supported but not released yet, because you are using `v0.1.0`. Consider to use a more recent revision, I've commented in you PR https://github.com/apache/incubator-inlong/pull/1572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7768: [Bug][Eyes] The `.ini` files with correct license header didn't pass skywalking-eys check
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7768:
URL: https://github.com/apache/skywalking/issues/7768#issuecomment-924935053
Read this doc, https://github.com/apache/skywalking-eyes#supported-file-types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] shink commented on issue #7768: [Bug][Eyes] The `.ini` files with correct license header didn't pass skywalking-eys check
Posted by GitBox <gi...@apache.org>.
shink commented on issue #7768:
URL: https://github.com/apache/skywalking/issues/7768#issuecomment-924798828
@wu-sheng I wonder if it is a bug, or because of my error? If it is a bug, I'm really want to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 closed issue #7768: [Bug][Eyes] The `.ini` files with correct license header didn't pass skywalking-eys check
Posted by GitBox <gi...@apache.org>.
kezhenxu94 closed issue #7768:
URL: https://github.com/apache/skywalking/issues/7768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] shink edited a comment on issue #7768: [Bug][Eyes] The `.ini` files with correct license header didn't pass skywalking-eys check
Posted by GitBox <gi...@apache.org>.
shink edited a comment on issue #7768:
URL: https://github.com/apache/skywalking/issues/7768#issuecomment-924933314
Are `.cmd` files supported? This `master.ini` also cann't pass the check.
```cmd
REM Licensed to the Apache Software Foundation (ASF) under one
REM or more contributor license agreements. See the NOTICE file
REM distributed with this work for additional information
REM regarding copyright ownership. The ASF licenses this file
REM to you under the Apache License, Version 2.0 (the
REM "License"); you may not use this file except in compliance
REM with the License. You may obtain a copy of the License at
REM
REM http://www.apache.org/licenses/LICENSE-2.0
REM
REM Unless required by applicable law or agreed to in writing,
REM software distributed under the License is distributed on an
REM "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
REM KIND, either express or implied. See the License for the
REM specific language governing permissions and limitations
REM under the License.
```
See https://github.com/apache/incubator-inlong/pull/1572/checks?check_run_id=3675682629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7768: [Bug][Eyes] The `.ini` files with correct license header didn't pass skywalking-eys check
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7768:
URL: https://github.com/apache/skywalking/issues/7768#issuecomment-924793371
Are you going to submit pull request to fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] shink edited a comment on issue #7768: [Bug][Eyes] The `.ini` files with correct license header didn't pass skywalking-eys check
Posted by GitBox <gi...@apache.org>.
shink edited a comment on issue #7768:
URL: https://github.com/apache/skywalking/issues/7768#issuecomment-924933314
Are `.cmd` files supported? This `master.cmd` also cann't pass the check.
```cmd
REM Licensed to the Apache Software Foundation (ASF) under one
REM or more contributor license agreements. See the NOTICE file
REM distributed with this work for additional information
REM regarding copyright ownership. The ASF licenses this file
REM to you under the Apache License, Version 2.0 (the
REM "License"); you may not use this file except in compliance
REM with the License. You may obtain a copy of the License at
REM
REM http://www.apache.org/licenses/LICENSE-2.0
REM
REM Unless required by applicable law or agreed to in writing,
REM software distributed under the License is distributed on an
REM "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
REM KIND, either express or implied. See the License for the
REM specific language governing permissions and limitations
REM under the License.
```
See https://github.com/apache/incubator-inlong/pull/1572/checks?check_run_id=3675682629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7768: [Bug][Eyes] The `.ini` files with correct license header didn't pass skywalking-eys check
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7768:
URL: https://github.com/apache/skywalking/issues/7768#issuecomment-925000646
> @wu-sheng Thank you very much! And the license header in `cmd` type files must be start with `@rem`, right?
This style file accepts pull request, I didn't read all of them. If your style is correct, you could change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #7768: [Bug][Eyes] The `.ini` files with correct license header didn't pass skywalking-eys check
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7768:
URL: https://github.com/apache/skywalking/issues/7768#issuecomment-924799937
> Yes I am willing to submit a PR!
I clicked this, which is why I asked.
@kezhenxu94 will take a look later, let's see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] shink commented on issue #7768: [Bug][Eyes] The `.ini` files with correct license header didn't pass skywalking-eys check
Posted by GitBox <gi...@apache.org>.
shink commented on issue #7768:
URL: https://github.com/apache/skywalking/issues/7768#issuecomment-924933314
Are `.cmd` files supported? This `master.ini` also cann't pass the check.
```cmd
REM Licensed to the Apache Software Foundation (ASF) under one
REM or more contributor license agreements. See the NOTICE file
REM distributed with this work for additional information
REM regarding copyright ownership. The ASF licenses this file
REM to you under the Apache License, Version 2.0 (the
REM "License"); you may not use this file except in compliance
REM with the License. You may obtain a copy of the License at
REM
REM http://www.apache.org/licenses/LICENSE-2.0
REM
REM Unless required by applicable law or agreed to in writing,
REM software distributed under the License is distributed on an
REM "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
REM KIND, either express or implied. See the License for the
REM specific language governing permissions and limitations
REM under the License.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org