You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/27 12:43:28 UTC
[GitHub] [flink] libenchao opened a new pull request #10706:
[FLINK-15418][table-planner-blink] Set FlinkRelDistribution in
StreamExecMatchRule
libenchao opened a new pull request #10706: [FLINK-15418][table-planner-blink] Set FlinkRelDistribution in StreamExecMatchRule
URL: https://github.com/apache/flink/pull/10706
## What is the purpose of the change
This pr fix that StreamExecMatchRule not sets FlinkRelDistribution trait.
## Brief change log
1, Set FlinkRelDistribution in StreamExecMatchRule.
## Verifying this change
This change added tests and can be verified as follows:
MatchRecognizeITCase.testPartitionByWithParallelSource
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10706:
[FLINK-15418][table-planner-blink] Set FlinkRelDistribution in
StreamExecMatchRule
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10706: [FLINK-15418][table-planner-blink] Set FlinkRelDistribution in StreamExecMatchRule
URL: https://github.com/apache/flink/pull/10706#issuecomment-569270452
<!--
Meta data
Hash:daaa89195ca2ff2cc09823f6f8505b99b9010997 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142456775 TriggerType:PUSH TriggerID:daaa89195ca2ff2cc09823f6f8505b99b9010997
Hash:daaa89195ca2ff2cc09823f6f8505b99b9010997 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3958 TriggerType:PUSH TriggerID:daaa89195ca2ff2cc09823f6f8505b99b9010997
Hash:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142463428 TriggerType:PUSH TriggerID:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0
Hash:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3959 TriggerType:PUSH TriggerID:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0
-->
## CI report:
* daaa89195ca2ff2cc09823f6f8505b99b9010997 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142456775) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3958)
* 6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142463428) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3959)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #10706:
[FLINK-15418][table-planner-blink] Set FlinkRelDistribution in
StreamExecMatchRule
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #10706: [FLINK-15418][table-planner-blink] Set FlinkRelDistribution in StreamExecMatchRule
URL: https://github.com/apache/flink/pull/10706#discussion_r361933000
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/MatchRecognizeITCase.scala
##########
@@ -416,6 +416,54 @@ class MatchRecognizeITCase(backend: StateBackendMode) extends StreamingWithState
assertEquals(expected.sorted, sink.getAppendResults.sorted)
}
+ @Test
+ def testPartitionByWithParallelSource(): Unit = {
+ val env = StreamExecutionEnvironment.getExecutionEnvironment
+ env.setStreamTimeCharacteristic(TimeCharacteristic.EventTime)
+ env.setParallelism(2)
+ val tEnv = StreamTableEnvironment.create(env, TableTestUtil.STREAM_SETTING)
+
+ val data = new mutable.MutableList[(String, Long, Int, Int)]
+ data.+=(("ACME", 1L, 19, 1))
+ data.+=(("ACME", 2L, 17, 2))
+ data.+=(("ACME", 3L, 13, 3))
+ data.+=(("ACME", 4L, 20, 4))
+ val parallelSource = new ParallelCollectionWrapper[(String, Long, Int, Int)](
+ data, 0, data.length)
+
+ val t = env.fromParallelCollection(parallelSource)
+ .assignAscendingTimestamps(tickerEvent => tickerEvent._2)
Review comment:
Apply `.setParallelism(4)` to reshuffle data to reproduce the problem, in this way, we don't need to introduce `ParallelCollectionWrapper`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] libenchao commented on issue #10706:
[FLINK-15418][table-planner-blink] Set FlinkRelDistribution in
StreamExecMatchRule
Posted by GitBox <gi...@apache.org>.
libenchao commented on issue #10706: [FLINK-15418][table-planner-blink] Set FlinkRelDistribution in StreamExecMatchRule
URL: https://github.com/apache/flink/pull/10706#issuecomment-569633153
@wuchong Thanks for the review, I've updated the code according to suggestions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10706:
[FLINK-15418][table-planner-blink] Set FlinkRelDistribution in
StreamExecMatchRule
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10706: [FLINK-15418][table-planner-blink] Set FlinkRelDistribution in StreamExecMatchRule
URL: https://github.com/apache/flink/pull/10706#issuecomment-569270452
<!--
Meta data
Hash:daaa89195ca2ff2cc09823f6f8505b99b9010997 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142456775 TriggerType:PUSH TriggerID:daaa89195ca2ff2cc09823f6f8505b99b9010997
Hash:daaa89195ca2ff2cc09823f6f8505b99b9010997 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3958 TriggerType:PUSH TriggerID:daaa89195ca2ff2cc09823f6f8505b99b9010997
Hash:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142463428 TriggerType:PUSH TriggerID:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0
Hash:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3959 TriggerType:PUSH TriggerID:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0
Hash:4cee7a516b3a8f47de0b3574f44bb285a54fda35 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142473273 TriggerType:PUSH TriggerID:4cee7a516b3a8f47de0b3574f44bb285a54fda35
Hash:4cee7a516b3a8f47de0b3574f44bb285a54fda35 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3961 TriggerType:PUSH TriggerID:4cee7a516b3a8f47de0b3574f44bb285a54fda35
-->
## CI report:
* daaa89195ca2ff2cc09823f6f8505b99b9010997 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142456775) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3958)
* 6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142463428) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3959)
* 4cee7a516b3a8f47de0b3574f44bb285a54fda35 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142473273) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3961)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10706:
[FLINK-15418][table-planner-blink] Set FlinkRelDistribution in
StreamExecMatchRule
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10706: [FLINK-15418][table-planner-blink] Set FlinkRelDistribution in StreamExecMatchRule
URL: https://github.com/apache/flink/pull/10706#issuecomment-569270452
<!--
Meta data
Hash:daaa89195ca2ff2cc09823f6f8505b99b9010997 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142456775 TriggerType:PUSH TriggerID:daaa89195ca2ff2cc09823f6f8505b99b9010997
Hash:daaa89195ca2ff2cc09823f6f8505b99b9010997 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3958 TriggerType:PUSH TriggerID:daaa89195ca2ff2cc09823f6f8505b99b9010997
Hash:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142463428 TriggerType:PUSH TriggerID:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0
Hash:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3959 TriggerType:PUSH TriggerID:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0
Hash:4cee7a516b3a8f47de0b3574f44bb285a54fda35 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142473273 TriggerType:PUSH TriggerID:4cee7a516b3a8f47de0b3574f44bb285a54fda35
Hash:4cee7a516b3a8f47de0b3574f44bb285a54fda35 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3961 TriggerType:PUSH TriggerID:4cee7a516b3a8f47de0b3574f44bb285a54fda35
-->
## CI report:
* daaa89195ca2ff2cc09823f6f8505b99b9010997 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142456775) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3958)
* 6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142463428) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3959)
* 4cee7a516b3a8f47de0b3574f44bb285a54fda35 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142473273) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3961)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #10706:
[FLINK-15418][table-planner-blink] Set FlinkRelDistribution in
StreamExecMatchRule
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #10706: [FLINK-15418][table-planner-blink] Set FlinkRelDistribution in StreamExecMatchRule
URL: https://github.com/apache/flink/pull/10706#discussion_r361947220
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/rules/physical/stream/StreamExecMatchRule.scala
##########
@@ -57,16 +57,19 @@ class StreamExecMatchRule
override def convert(rel: RelNode): RelNode = {
val logicalMatch: FlinkLogicalMatch = rel.asInstanceOf[FlinkLogicalMatch]
val traitSet: RelTraitSet = rel.getTraitSet.replace(FlinkConventions.STREAM_PHYSICAL)
-
val partitionKeys = logicalMatch.getPartitionKeys
- val newTraitSet = if (partitionKeys != null && !partitionKeys.isEmpty) {
- traitSet.replace(FlinkRelDistribution.hash(logicalMatch.getPartitionKeys.toList))
+
+ val requiredDistribution = if (partitionKeys != null && !partitionKeys.isEmpty) {
Review comment:
Nit: `partitionKeys` is never null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #10706:
[FLINK-15418][table-planner-blink] Set FlinkRelDistribution in
StreamExecMatchRule
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #10706: [FLINK-15418][table-planner-blink] Set FlinkRelDistribution in StreamExecMatchRule
URL: https://github.com/apache/flink/pull/10706#discussion_r361912912
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/rules/physical/stream/StreamExecMatchRule.scala
##########
@@ -71,7 +80,7 @@ class StreamExecMatchRule
new StreamExecMatch(
rel.getCluster,
- traitSet,
+ newTraitSet,
Review comment:
The trait set of current relation and the input node is not the same. Only the required trait set contains distribution. You can refer `StreamExecGroupAggregateRule` as an example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10706:
[FLINK-15418][table-planner-blink] Set FlinkRelDistribution in
StreamExecMatchRule
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10706: [FLINK-15418][table-planner-blink] Set FlinkRelDistribution in StreamExecMatchRule
URL: https://github.com/apache/flink/pull/10706#issuecomment-569270452
<!--
Meta data
Hash:daaa89195ca2ff2cc09823f6f8505b99b9010997 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142456775 TriggerType:PUSH TriggerID:daaa89195ca2ff2cc09823f6f8505b99b9010997
Hash:daaa89195ca2ff2cc09823f6f8505b99b9010997 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3958 TriggerType:PUSH TriggerID:daaa89195ca2ff2cc09823f6f8505b99b9010997
Hash:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0
-->
## CI report:
* daaa89195ca2ff2cc09823f6f8505b99b9010997 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142456775) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3958)
* 6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10706:
[FLINK-15418][table-planner-blink] Set FlinkRelDistribution in
StreamExecMatchRule
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10706: [FLINK-15418][table-planner-blink] Set FlinkRelDistribution in StreamExecMatchRule
URL: https://github.com/apache/flink/pull/10706#issuecomment-569270452
<!--
Meta data
Hash:daaa89195ca2ff2cc09823f6f8505b99b9010997 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142456775 TriggerType:PUSH TriggerID:daaa89195ca2ff2cc09823f6f8505b99b9010997
Hash:daaa89195ca2ff2cc09823f6f8505b99b9010997 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3958 TriggerType:PUSH TriggerID:daaa89195ca2ff2cc09823f6f8505b99b9010997
Hash:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142463428 TriggerType:PUSH TriggerID:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0
Hash:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3959 TriggerType:PUSH TriggerID:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0
Hash:4cee7a516b3a8f47de0b3574f44bb285a54fda35 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142473273 TriggerType:PUSH TriggerID:4cee7a516b3a8f47de0b3574f44bb285a54fda35
Hash:4cee7a516b3a8f47de0b3574f44bb285a54fda35 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3961 TriggerType:PUSH TriggerID:4cee7a516b3a8f47de0b3574f44bb285a54fda35
Hash:1b4b4788035186d5c01e5c8236052045140bc1f1 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142634653 TriggerType:PUSH TriggerID:1b4b4788035186d5c01e5c8236052045140bc1f1
Hash:1b4b4788035186d5c01e5c8236052045140bc1f1 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3982 TriggerType:PUSH TriggerID:1b4b4788035186d5c01e5c8236052045140bc1f1
-->
## CI report:
* daaa89195ca2ff2cc09823f6f8505b99b9010997 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142456775) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3958)
* 6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142463428) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3959)
* 4cee7a516b3a8f47de0b3574f44bb285a54fda35 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142473273) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3961)
* 1b4b4788035186d5c01e5c8236052045140bc1f1 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142634653) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3982)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10706:
[FLINK-15418][table-planner-blink] Set FlinkRelDistribution in
StreamExecMatchRule
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10706: [FLINK-15418][table-planner-blink] Set FlinkRelDistribution in StreamExecMatchRule
URL: https://github.com/apache/flink/pull/10706#issuecomment-569262950
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit daaa89195ca2ff2cc09823f6f8505b99b9010997 (Fri Dec 27 12:46:40 UTC 2019)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15418).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10706:
[FLINK-15418][table-planner-blink] Set FlinkRelDistribution in
StreamExecMatchRule
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10706: [FLINK-15418][table-planner-blink] Set FlinkRelDistribution in StreamExecMatchRule
URL: https://github.com/apache/flink/pull/10706#issuecomment-569270452
<!--
Meta data
Hash:daaa89195ca2ff2cc09823f6f8505b99b9010997 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142456775 TriggerType:PUSH TriggerID:daaa89195ca2ff2cc09823f6f8505b99b9010997
Hash:daaa89195ca2ff2cc09823f6f8505b99b9010997 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3958 TriggerType:PUSH TriggerID:daaa89195ca2ff2cc09823f6f8505b99b9010997
Hash:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142463428 TriggerType:PUSH TriggerID:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0
Hash:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3959 TriggerType:PUSH TriggerID:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0
Hash:4cee7a516b3a8f47de0b3574f44bb285a54fda35 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142473273 TriggerType:PUSH TriggerID:4cee7a516b3a8f47de0b3574f44bb285a54fda35
Hash:4cee7a516b3a8f47de0b3574f44bb285a54fda35 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3961 TriggerType:PUSH TriggerID:4cee7a516b3a8f47de0b3574f44bb285a54fda35
-->
## CI report:
* daaa89195ca2ff2cc09823f6f8505b99b9010997 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142456775) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3958)
* 6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142463428) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3959)
* 4cee7a516b3a8f47de0b3574f44bb285a54fda35 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142473273) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3961)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10706:
[FLINK-15418][table-planner-blink] Set FlinkRelDistribution in
StreamExecMatchRule
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10706: [FLINK-15418][table-planner-blink] Set FlinkRelDistribution in StreamExecMatchRule
URL: https://github.com/apache/flink/pull/10706#issuecomment-569270452
<!--
Meta data
Hash:daaa89195ca2ff2cc09823f6f8505b99b9010997 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:daaa89195ca2ff2cc09823f6f8505b99b9010997
-->
## CI report:
* daaa89195ca2ff2cc09823f6f8505b99b9010997 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10706:
[FLINK-15418][table-planner-blink] Set FlinkRelDistribution in
StreamExecMatchRule
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10706: [FLINK-15418][table-planner-blink] Set FlinkRelDistribution in StreamExecMatchRule
URL: https://github.com/apache/flink/pull/10706#issuecomment-569270452
<!--
Meta data
Hash:daaa89195ca2ff2cc09823f6f8505b99b9010997 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142456775 TriggerType:PUSH TriggerID:daaa89195ca2ff2cc09823f6f8505b99b9010997
Hash:daaa89195ca2ff2cc09823f6f8505b99b9010997 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3958 TriggerType:PUSH TriggerID:daaa89195ca2ff2cc09823f6f8505b99b9010997
Hash:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142463428 TriggerType:PUSH TriggerID:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0
Hash:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3959 TriggerType:PUSH TriggerID:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0
Hash:4cee7a516b3a8f47de0b3574f44bb285a54fda35 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:4cee7a516b3a8f47de0b3574f44bb285a54fda35
-->
## CI report:
* daaa89195ca2ff2cc09823f6f8505b99b9010997 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142456775) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3958)
* 6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142463428) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3959)
* 4cee7a516b3a8f47de0b3574f44bb285a54fda35 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10706:
[FLINK-15418][table-planner-blink] Set FlinkRelDistribution in
StreamExecMatchRule
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10706: [FLINK-15418][table-planner-blink] Set FlinkRelDistribution in StreamExecMatchRule
URL: https://github.com/apache/flink/pull/10706#issuecomment-569270452
<!--
Meta data
Hash:daaa89195ca2ff2cc09823f6f8505b99b9010997 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142456775 TriggerType:PUSH TriggerID:daaa89195ca2ff2cc09823f6f8505b99b9010997
Hash:daaa89195ca2ff2cc09823f6f8505b99b9010997 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3958 TriggerType:PUSH TriggerID:daaa89195ca2ff2cc09823f6f8505b99b9010997
Hash:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142463428 TriggerType:PUSH TriggerID:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0
Hash:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3959 TriggerType:PUSH TriggerID:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0
Hash:4cee7a516b3a8f47de0b3574f44bb285a54fda35 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142473273 TriggerType:PUSH TriggerID:4cee7a516b3a8f47de0b3574f44bb285a54fda35
Hash:4cee7a516b3a8f47de0b3574f44bb285a54fda35 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3961 TriggerType:PUSH TriggerID:4cee7a516b3a8f47de0b3574f44bb285a54fda35
Hash:1b4b4788035186d5c01e5c8236052045140bc1f1 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:1b4b4788035186d5c01e5c8236052045140bc1f1
-->
## CI report:
* daaa89195ca2ff2cc09823f6f8505b99b9010997 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142456775) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3958)
* 6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142463428) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3959)
* 4cee7a516b3a8f47de0b3574f44bb285a54fda35 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142473273) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3961)
* 1b4b4788035186d5c01e5c8236052045140bc1f1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10706:
[FLINK-15418][table-planner-blink] Set FlinkRelDistribution in
StreamExecMatchRule
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10706: [FLINK-15418][table-planner-blink] Set FlinkRelDistribution in StreamExecMatchRule
URL: https://github.com/apache/flink/pull/10706#issuecomment-569270452
<!--
Meta data
Hash:daaa89195ca2ff2cc09823f6f8505b99b9010997 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142456775 TriggerType:PUSH TriggerID:daaa89195ca2ff2cc09823f6f8505b99b9010997
Hash:daaa89195ca2ff2cc09823f6f8505b99b9010997 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3958 TriggerType:PUSH TriggerID:daaa89195ca2ff2cc09823f6f8505b99b9010997
Hash:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142463428 TriggerType:PUSH TriggerID:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0
Hash:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3959 TriggerType:PUSH TriggerID:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0
Hash:4cee7a516b3a8f47de0b3574f44bb285a54fda35 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142473273 TriggerType:PUSH TriggerID:4cee7a516b3a8f47de0b3574f44bb285a54fda35
Hash:4cee7a516b3a8f47de0b3574f44bb285a54fda35 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3961 TriggerType:PUSH TriggerID:4cee7a516b3a8f47de0b3574f44bb285a54fda35
Hash:1b4b4788035186d5c01e5c8236052045140bc1f1 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142634653 TriggerType:PUSH TriggerID:1b4b4788035186d5c01e5c8236052045140bc1f1
Hash:1b4b4788035186d5c01e5c8236052045140bc1f1 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3982 TriggerType:PUSH TriggerID:1b4b4788035186d5c01e5c8236052045140bc1f1
-->
## CI report:
* daaa89195ca2ff2cc09823f6f8505b99b9010997 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142456775) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3958)
* 6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142463428) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3959)
* 4cee7a516b3a8f47de0b3574f44bb285a54fda35 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142473273) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3961)
* 1b4b4788035186d5c01e5c8236052045140bc1f1 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142634653) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3982)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong closed pull request #10706:
[FLINK-15418][table-planner-blink] Set FlinkRelDistribution in
StreamExecMatchRule
Posted by GitBox <gi...@apache.org>.
wuchong closed pull request #10706: [FLINK-15418][table-planner-blink] Set FlinkRelDistribution in StreamExecMatchRule
URL: https://github.com/apache/flink/pull/10706
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10706:
[FLINK-15418][table-planner-blink] Set FlinkRelDistribution in
StreamExecMatchRule
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10706: [FLINK-15418][table-planner-blink] Set FlinkRelDistribution in StreamExecMatchRule
URL: https://github.com/apache/flink/pull/10706#issuecomment-569270452
<!--
Meta data
Hash:daaa89195ca2ff2cc09823f6f8505b99b9010997 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142456775 TriggerType:PUSH TriggerID:daaa89195ca2ff2cc09823f6f8505b99b9010997
Hash:daaa89195ca2ff2cc09823f6f8505b99b9010997 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3958 TriggerType:PUSH TriggerID:daaa89195ca2ff2cc09823f6f8505b99b9010997
-->
## CI report:
* daaa89195ca2ff2cc09823f6f8505b99b9010997 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142456775) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3958)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] libenchao commented on a change in pull request #10706:
[FLINK-15418][table-planner-blink] Set FlinkRelDistribution in
StreamExecMatchRule
Posted by GitBox <gi...@apache.org>.
libenchao commented on a change in pull request #10706: [FLINK-15418][table-planner-blink] Set FlinkRelDistribution in StreamExecMatchRule
URL: https://github.com/apache/flink/pull/10706#discussion_r361948990
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/rules/physical/stream/StreamExecMatchRule.scala
##########
@@ -57,16 +57,19 @@ class StreamExecMatchRule
override def convert(rel: RelNode): RelNode = {
val logicalMatch: FlinkLogicalMatch = rel.asInstanceOf[FlinkLogicalMatch]
val traitSet: RelTraitSet = rel.getTraitSet.replace(FlinkConventions.STREAM_PHYSICAL)
-
val partitionKeys = logicalMatch.getPartitionKeys
- val newTraitSet = if (partitionKeys != null && !partitionKeys.isEmpty) {
- traitSet.replace(FlinkRelDistribution.hash(logicalMatch.getPartitionKeys.toList))
+
+ val requiredDistribution = if (partitionKeys != null && !partitionKeys.isEmpty) {
Review comment:
removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10706:
[FLINK-15418][table-planner-blink] Set FlinkRelDistribution in
StreamExecMatchRule
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10706: [FLINK-15418][table-planner-blink] Set FlinkRelDistribution in StreamExecMatchRule
URL: https://github.com/apache/flink/pull/10706#issuecomment-569270452
<!--
Meta data
Hash:daaa89195ca2ff2cc09823f6f8505b99b9010997 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142456775 TriggerType:PUSH TriggerID:daaa89195ca2ff2cc09823f6f8505b99b9010997
Hash:daaa89195ca2ff2cc09823f6f8505b99b9010997 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3958 TriggerType:PUSH TriggerID:daaa89195ca2ff2cc09823f6f8505b99b9010997
Hash:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142463428 TriggerType:PUSH TriggerID:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0
Hash:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3959 TriggerType:PUSH TriggerID:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0
-->
## CI report:
* daaa89195ca2ff2cc09823f6f8505b99b9010997 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142456775) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3958)
* 6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142463428) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3959)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10706:
[FLINK-15418][table-planner-blink] Set FlinkRelDistribution in
StreamExecMatchRule
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10706: [FLINK-15418][table-planner-blink] Set FlinkRelDistribution in StreamExecMatchRule
URL: https://github.com/apache/flink/pull/10706#issuecomment-569270452
<!--
Meta data
Hash:daaa89195ca2ff2cc09823f6f8505b99b9010997 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142456775 TriggerType:PUSH TriggerID:daaa89195ca2ff2cc09823f6f8505b99b9010997
Hash:daaa89195ca2ff2cc09823f6f8505b99b9010997 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3958 TriggerType:PUSH TriggerID:daaa89195ca2ff2cc09823f6f8505b99b9010997
Hash:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142463428 TriggerType:PUSH TriggerID:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0
Hash:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3959 TriggerType:PUSH TriggerID:6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0
Hash:4cee7a516b3a8f47de0b3574f44bb285a54fda35 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142473273 TriggerType:PUSH TriggerID:4cee7a516b3a8f47de0b3574f44bb285a54fda35
Hash:4cee7a516b3a8f47de0b3574f44bb285a54fda35 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3961 TriggerType:PUSH TriggerID:4cee7a516b3a8f47de0b3574f44bb285a54fda35
Hash:1b4b4788035186d5c01e5c8236052045140bc1f1 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142634653 TriggerType:PUSH TriggerID:1b4b4788035186d5c01e5c8236052045140bc1f1
Hash:1b4b4788035186d5c01e5c8236052045140bc1f1 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3982 TriggerType:PUSH TriggerID:1b4b4788035186d5c01e5c8236052045140bc1f1
-->
## CI report:
* daaa89195ca2ff2cc09823f6f8505b99b9010997 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142456775) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3958)
* 6365f53e67dd2bbd91a11cc1e4e19f35d62c49e0 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142463428) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3959)
* 4cee7a516b3a8f47de0b3574f44bb285a54fda35 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142473273) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3961)
* 1b4b4788035186d5c01e5c8236052045140bc1f1 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142634653) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3982)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong commented on a change in pull request #10706:
[FLINK-15418][table-planner-blink] Set FlinkRelDistribution in
StreamExecMatchRule
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #10706: [FLINK-15418][table-planner-blink] Set FlinkRelDistribution in StreamExecMatchRule
URL: https://github.com/apache/flink/pull/10706#discussion_r361913336
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/MatchRecognizeITCase.scala
##########
@@ -416,6 +416,54 @@ class MatchRecognizeITCase(backend: StateBackendMode) extends StreamingWithState
assertEquals(expected.sorted, sink.getAppendResults.sorted)
}
+ @Test
+ def testPartitionByWithParallelSource(): Unit = {
+ val env = StreamExecutionEnvironment.getExecutionEnvironment
+ env.setStreamTimeCharacteristic(TimeCharacteristic.EventTime)
+ env.setParallelism(2)
Review comment:
We don't need this. The default parallelism is 4 which should also work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services