You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/11/12 14:24:53 UTC

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5216: Support for new Feature: Clone a Virtual Machine (#4818)

DaanHoogland commented on a change in pull request #5216:
URL: https://github.com/apache/cloudstack/pull/5216#discussion_r708331939



##########
File path: test/integration/smoke/test_vm_life_cycle.py
##########
@@ -2085,14 +2085,19 @@ def setUp(self):
         self.cleanup = []
 
     def tearDown(self):
-        super(TestCloneVM, self).tearDown()
+        try:
+            cleanup_resources(self.apiclient, self.cleanup)
+        except Exception as e:
+            raise Exception("Warning: Exception during cleanup : %s" % e)

Review comment:
       please use the parent method , change before merging
   ```suggestion
           super(TestCloneVM,self).tearDown()
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org