You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by GitBox <gi...@apache.org> on 2021/05/23 15:12:16 UTC
[GitHub] [karaf] jassuncao opened a new pull request #1379: KARAF-7155 - Deleting a factory configuration doesn't delete the associated json file
jassuncao opened a new pull request #1379:
URL: https://github.com/apache/karaf/pull/1379
JsonConfigInstaller keeps tracks of configurations that are associated
to a json file. When the configuration is deleted it will try to delete
the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] jbonofre commented on pull request #1379: KARAF-7155 - Deleting a factory configuration doesn't delete the associated json file
Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #1379:
URL: https://github.com/apache/karaf/pull/1379#issuecomment-991703524
Actually, it works for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] jbonofre commented on pull request #1379: KARAF-7155 - Deleting a factory configuration doesn't delete the associated json file
Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #1379:
URL: https://github.com/apache/karaf/pull/1379#issuecomment-856775796
@jassuncao what about using `felix.fileinstall.filename` to delete the file ? This way we don't have to store the factory/pid in the map, just read the `felix.fileinstall.filename` from the properties and remove it.
It's the fix I did.
Thoughts ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] jbonofre commented on pull request #1379: KARAF-7155 - Deleting a factory configuration doesn't delete the associated json file
Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #1379:
URL: https://github.com/apache/karaf/pull/1379#issuecomment-991703524
Actually, it works for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] jbonofre closed pull request #1379: KARAF-7155 - Deleting a factory configuration doesn't delete the associated json file
Posted by GitBox <gi...@apache.org>.
jbonofre closed pull request #1379:
URL: https://github.com/apache/karaf/pull/1379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] jassuncao commented on pull request #1379: KARAF-7155 - Deleting a factory configuration doesn't delete the associated json file
Posted by GitBox <gi...@apache.org>.
jassuncao commented on pull request #1379:
URL: https://github.com/apache/karaf/pull/1379#issuecomment-856905707
@jbonofre I had the idea configuration properties wouldn't be available after receiving a ConfigurationEvent.CM_DELETED. I'm almost sure I attempted that, but I might have missed something,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] jbonofre commented on pull request #1379: KARAF-7155 - Deleting a factory configuration doesn't delete the associated json file
Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #1379:
URL: https://github.com/apache/karaf/pull/1379#issuecomment-859998014
@jassuncao thanks, let me try something and I will let you know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf] jbonofre closed pull request #1379: KARAF-7155 - Deleting a factory configuration doesn't delete the associated json file
Posted by GitBox <gi...@apache.org>.
jbonofre closed pull request #1379:
URL: https://github.com/apache/karaf/pull/1379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org