You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Gregory Shimansky (JIRA)" <ji...@apache.org> on 2007/07/25 13:47:31 UTC
[jira] Created: (HARMONY-4534) [drlvm][thread] Need to remove
obsolete variables p_the_safepoint_control_thread and
global_safepoint_status
[drlvm][thread] Need to remove obsolete variables p_the_safepoint_control_thread and global_safepoint_status
------------------------------------------------------------------------------------------------------------
Key: HARMONY-4534
URL: https://issues.apache.org/jira/browse/HARMONY-4534
Project: Harmony
Issue Type: Bug
Components: DRLVM
Reporter: Gregory Shimansky
The two variables mentioned in summary are obsolete and it was agreed in [1] that they may be safely removed. It is only necessary to make sure that nothing is broken after they are removed from the code.
[1] http://thread.gmane.org/gmane.comp.java.harmony.devel/28353
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4534) [drlvm][thread] Need to remove
obsolete variables p_the_safepoint_control_thread and
global_safepoint_status
Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Petrenko updated HARMONY-4534:
-------------------------------------
Attachment: (was: HARMONY-4534.workaround.diff)
> [drlvm][thread] Need to remove obsolete variables p_the_safepoint_control_thread and global_safepoint_status
> ------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-4534
> URL: https://issues.apache.org/jira/browse/HARMONY-4534
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Gregory Shimansky
> Priority: Blocker
> Attachments: HARMONY-4534.workaround.diff
>
>
> The two variables mentioned in summary are obsolete and it was agreed in [1] that they may be safely removed. It is only necessary to make sure that nothing is broken after they are removed from the code.
> [1] http://thread.gmane.org/gmane.comp.java.harmony.devel/28353
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4534) [drlvm][thread] Need to remove
obsolete variables p_the_safepoint_control_thread and
global_safepoint_status
Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Petrenko updated HARMONY-4534:
-------------------------------------
Attachment: HARMONY-4534.workaround.diff
> [drlvm][thread] Need to remove obsolete variables p_the_safepoint_control_thread and global_safepoint_status
> ------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-4534
> URL: https://issues.apache.org/jira/browse/HARMONY-4534
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Gregory Shimansky
> Priority: Blocker
> Attachments: HARMONY-4534.workaround.diff
>
>
> The two variables mentioned in summary are obsolete and it was agreed in [1] that they may be safely removed. It is only necessary to make sure that nothing is broken after they are removed from the code.
> [1] http://thread.gmane.org/gmane.comp.java.harmony.devel/28353
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4534) [drlvm][thread] Need to remove
obsolete variables p_the_safepoint_control_thread and
global_safepoint_status
Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Petrenko updated HARMONY-4534:
-------------------------------------
Priority: Blocker (was: Major)
I would say that this issue is blocker since drlvm can not be built with gcc 4.1.1 and newer
> [drlvm][thread] Need to remove obsolete variables p_the_safepoint_control_thread and global_safepoint_status
> ------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-4534
> URL: https://issues.apache.org/jira/browse/HARMONY-4534
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Gregory Shimansky
> Priority: Blocker
>
> The two variables mentioned in summary are obsolete and it was agreed in [1] that they may be safely removed. It is only necessary to make sure that nothing is broken after they are removed from the code.
> [1] http://thread.gmane.org/gmane.comp.java.harmony.devel/28353
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4534) [drlvm][thread] Need to remove
obsolete variables p_the_safepoint_control_thread and
global_safepoint_status
Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ilya Berezhniuk updated HARMONY-4534:
-------------------------------------
Attachment: H-4534.patch
Here is a patch removing specified variables.
These variables are used for checking only, and actually used by GCv4 which is not included into the build. So I did not change its usage in GCv4 code.
VM remains buildable (unfortunately, I cannot check with latest gcc), but 'build test' shows some crashes. I hope these crashes are introduced by another change, because suggested patch is quite clear.
> [drlvm][thread] Need to remove obsolete variables p_the_safepoint_control_thread and global_safepoint_status
> ------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-4534
> URL: https://issues.apache.org/jira/browse/HARMONY-4534
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Gregory Shimansky
> Priority: Blocker
> Attachments: H-4534.patch, HARMONY-4534.workaround.diff
>
>
> The two variables mentioned in summary are obsolete and it was agreed in [1] that they may be safely removed. It is only necessary to make sure that nothing is broken after they are removed from the code.
> [1] http://thread.gmane.org/gmane.comp.java.harmony.devel/28353
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-4534) [drlvm][thread] Need to remove
obsolete variables p_the_safepoint_control_thread and
global_safepoint_status
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky reassigned HARMONY-4534:
------------------------------------------
Assignee: Gregory Shimansky
> [drlvm][thread] Need to remove obsolete variables p_the_safepoint_control_thread and global_safepoint_status
> ------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-4534
> URL: https://issues.apache.org/jira/browse/HARMONY-4534
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Gregory Shimansky
> Assignee: Gregory Shimansky
> Priority: Blocker
> Attachments: H-4534.patch, HARMONY-4534.workaround.diff
>
>
> The two variables mentioned in summary are obsolete and it was agreed in [1] that they may be safely removed. It is only necessary to make sure that nothing is broken after they are removed from the code.
> [1] http://thread.gmane.org/gmane.comp.java.harmony.devel/28353
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-4534) [drlvm][thread] Need to remove
obsolete variables p_the_safepoint_control_thread and
global_safepoint_status
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky closed HARMONY-4534.
--------------------------------------
Resolution: Fixed
Committed and verified at 559857.
> [drlvm][thread] Need to remove obsolete variables p_the_safepoint_control_thread and global_safepoint_status
> ------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-4534
> URL: https://issues.apache.org/jira/browse/HARMONY-4534
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Gregory Shimansky
> Assignee: Gregory Shimansky
> Priority: Blocker
> Attachments: H-4534.patch, HARMONY-4534.workaround.diff
>
>
> The two variables mentioned in summary are obsolete and it was agreed in [1] that they may be safely removed. It is only necessary to make sure that nothing is broken after they are removed from the code.
> [1] http://thread.gmane.org/gmane.comp.java.harmony.devel/28353
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4534) [drlvm][thread] Need to remove
obsolete variables p_the_safepoint_control_thread and
global_safepoint_status
Posted by "Alexey Petrenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Petrenko updated HARMONY-4534:
-------------------------------------
Attachment: HARMONY-4534.workaround.diff
This patch marks the variable with "extern C" in header file.
I can build VM with gcc 4.1.1 now.
> [drlvm][thread] Need to remove obsolete variables p_the_safepoint_control_thread and global_safepoint_status
> ------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-4534
> URL: https://issues.apache.org/jira/browse/HARMONY-4534
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Gregory Shimansky
> Priority: Blocker
> Attachments: HARMONY-4534.workaround.diff
>
>
> The two variables mentioned in summary are obsolete and it was agreed in [1] that they may be safely removed. It is only necessary to make sure that nothing is broken after they are removed from the code.
> [1] http://thread.gmane.org/gmane.comp.java.harmony.devel/28353
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.