You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@polaris.apache.org by "ebyhr (via GitHub)" <gi...@apache.org> on 2024/08/24 02:45:14 UTC
[PR] Enable ErrorProne FallThrough, MissingCasesInEnumSwitch, ModifiedButNotUsed, OrphanedFormatString [polaris]
ebyhr opened a new pull request, #202:
URL: https://github.com/apache/polaris/pull/202
# Description
Enable ErrorProne FallThrough, MissingCasesInEnumSwitch, ModifiedButNotUsed, OrphanedFormatString
## Type of change
Please delete options that are not relevant.
# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
- [ ] Test A
- [ ] Test B
**Test Configuration**:
* Firmware version:
* Hardware:
* Toolchain:
* SDK:
# Checklist:
Please delete options that are not relevant.
- [x] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream modules
- [ ] If adding new functionality, I have discussed my implementation with the community using the linked GitHub issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable ErrorProne FallThrough, MissingCasesInEnumSwitch, OrphanedFormatString [polaris]
Posted by "ebyhr (via GitHub)" <gi...@apache.org>.
ebyhr commented on code in PR #202:
URL: https://github.com/apache/polaris/pull/202#discussion_r1730272513
##########
polaris-service/src/main/java/io/polaris/service/catalog/PolarisCatalogHandlerWrapper.java:
##########
@@ -578,7 +578,7 @@ public LoadTableResponse createTableDirectWithWriteDelegation(
.withLocation(request.location())
.withPartitionSpec(request.spec())
.withSortOrder(request.writeOrder())
- .withProperties(request.properties())
+ .withProperties(properties)
Review Comment:
Separated into https://github.com/apache/polaris/pull/207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable ErrorProne FallThrough, MissingCasesInEnumSwitch, OrphanedFormatString [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy merged PR #202:
URL: https://github.com/apache/polaris/pull/202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable ErrorProne FallThrough, MissingCasesInEnumSwitch, ModifiedButNotUsed, OrphanedFormatString [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on code in PR #202:
URL: https://github.com/apache/polaris/pull/202#discussion_r1730269850
##########
polaris-service/src/main/java/io/polaris/service/catalog/PolarisCatalogHandlerWrapper.java:
##########
@@ -578,7 +578,7 @@ public LoadTableResponse createTableDirectWithWriteDelegation(
.withLocation(request.location())
.withPartitionSpec(request.spec())
.withSortOrder(request.writeOrder())
- .withProperties(request.properties())
+ .withProperties(properties)
Review Comment:
Looks like this change doesn't fit into the description/title of this PR. Mind moving this change to a separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org