[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2823: GOBBLIN-976: Add dynamic config to the state before instantiating met…

[GitBox <gi...@apache.org>]

sv2000 commented on a change in pull request #2823: GOBBLIN-976: Add dynamic config to the state before instantiating met…
URL: https://github.com/apache/incubator-gobblin/pull/2823#discussion_r349384500
 
 

 ##########
 File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/mapreduce/MRJobLauncher.java
 ##########
 @@ -766,6 +767,7 @@ protected void setup(Context context) {
       for (Map.Entry<String, ConfigValue> entry : dynamicConfig.entrySet()) {
         this.jobState.setProp(entry.getKey(), entry.getValue().unwrapped().toString());
         configuration.set(entry.getKey(), entry.getValue().unwrapped().toString());
+        gobblinJobState.setProp(entry.getKey(), entry.getValue().unwrapped().toString());
 
 Review comment:
   I did consider it. I think this needs a significant clean up. In addition to configuration and gobblinJobState, we also have jobProps (which is a java.util.Properties). It seems that there is overlap in configs across these types, and it is unclear which property should go where. Arguably, since Hadoop APIs use Configuration, we should set all properties in the configuration object. But I am open to suggestions. I will create a tech-debt ticket and use that for addressing this. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services