You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2017/04/20 12:33:50 UTC

Review Request 58566: Remove Hard Coded Dependency to libtirpc-devel

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58566/
-----------------------------------------------------------

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-20801
    https://issues.apache.org/jira/browse/AMBARI-20801


Repository: ambari


Description
-------

It looks like there was a problem discovered with HDP 2.5 NFS Gateway's RPM
where it was missing a dependency on `libtirpc-devel`. This seems to have been
discovered at the exact same time by both Ambari and HDFS release teams. As
such, two parallel fixes were made:

  * AMBARI-19567 adds this to the `metainfo.xml` of HDFS.
  * HDFS fixed this in their NFS RPM

Because HDFS fixed this, Ambari should _not_ need to manually call out the
requirement of this package. Instead, we should rely on the RPM dependencies.
The code from AMBARI-19567 should be reverted.


Diffs
-----

  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 8a9c08a 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/metainfo.xml 8c2ec8b 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/metainfo.xml ccf9a4e 


Diff: https://reviews.apache.org/r/58566/diff/1/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 58566: Remove Hard Coded Dependency to libtirpc-devel

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58566/#review172480
-----------------------------------------------------------


Ship it!




Ship It!

- Vitalyi Brodetskyi


On \u041a\u0432\u0456\u0442\u0435\u043d\u044c 20, 2017, 12:33 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f, Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58566/
> -----------------------------------------------------------
> 
> (Updated \u041a\u0432\u0456\u0442\u0435\u043d\u044c 20, 2017, 12:33 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20801
>     https://issues.apache.org/jira/browse/AMBARI-20801
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> It looks like there was a problem discovered with HDP 2.5 NFS Gateway's RPM
> where it was missing a dependency on `libtirpc-devel`. This seems to have been
> discovered at the exact same time by both Ambari and HDFS release teams. As
> such, two parallel fixes were made:
> 
>   * AMBARI-19567 adds this to the `metainfo.xml` of HDFS.
>   * HDFS fixed this in their NFS RPM
> 
> Because HDFS fixed this, Ambari should _not_ need to manually call out the
> requirement of this package. Instead, we should rely on the RPM dependencies.
> The code from AMBARI-19567 should be reverted.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 8a9c08a 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/metainfo.xml 8c2ec8b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/metainfo.xml ccf9a4e 
> 
> 
> Diff: https://reviews.apache.org/r/58566/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>