You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/25 08:55:14 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #3189: Add sleep to object_store CI
tustvold opened a new pull request, #3189:
URL: https://github.com/apache/arrow-rs/pull/3189
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Frequently this job fails with
```
* TCP_NODELAY set
* Connected to localhost (::1) port 4443 (#0)
> POST /storage/v1/b HTTP/1.1
> Host: localhost:4443
> User-Agent: curl/7.68.0
> Accept: */*
> Content-Type: application/json
> Content-Length: 22
>
} [22 bytes data]
* upload completely sent off: 22 out of 22 bytes
* Empty reply from server
100 22 0 0 100 22 0 22000 --:--:-- --:--:-- --:--:-- 22000
```
https://github.com/apache/arrow-rs/actions/runs/3546438851/jobs/5955482110
Where success looks like
```
* TCP_NODELAY set
* Connected to localhost (::1) port 4443 (#0)
> POST /storage/v1/b HTTP/1.1
> Host: localhost:4443
> User-Agent: curl/7.68.0
> Accept: */*
> Content-Type: application/json
> Content-Length: 22
>
} [22 bytes data]
* upload completely sent off: 22 out of 22 bytes
* Mark bundle as not supporting multiuse
< HTTP/1.1 200 OK
< Content-Type: application/json
< Date: Fri, 25 Nov 2022 07:06:50 GMT
< Content-Length: 151
<
{ [151 bytes data]
```
It is possible this is some sort of startup race, so lets add a sleep and see if it helps
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3189: Add sleep to object_store CI
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3189:
URL: https://github.com/apache/arrow-rs/pull/3189#issuecomment-1327321870
Benchmark runs are scheduled for baseline = 4c37ec24a95a4a0c30f5f5eb4e81fd3647816a6f and contender = 3998bed87d9eaa95ea1e1e205bac1fa218a9e0f1. 3998bed87d9eaa95ea1e1e205bac1fa218a9e0f1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/f5445d81710b4a6eb9b0ef4e4a61593b...9a8be87bf33f4108b40bf27a0cc77524/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/37fd78c449d34660a772797ec9f304da...4bb715644d044f2d90f23204af9fc94f/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/1a576a366cc34dafabef38a0931e1d4e...06a0d3ced3ad4e9cb2f049d06bd6d184/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9d796d02051149069694ca5ffcf1a771...519f0dbcb49f47b2a50779964055c2d9/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #3189: Add sleep to object_store CI
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #3189:
URL: https://github.com/apache/arrow-rs/pull/3189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a diff in pull request #3189: Add sleep to object_store CI
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #3189:
URL: https://github.com/apache/arrow-rs/pull/3189#discussion_r1032256679
##########
.github/workflows/object_store.yml:
##########
@@ -86,6 +86,7 @@ jobs:
- name: Configure Fake GCS Server (GCP emulation)
run: |
docker run -d -p 4443:4443 fsouza/fake-gcs-server -scheme http
+ sleep 1
Review Comment:
```suggestion
# Give the container a moment to start up prior to configuring it
sleep 1
```
##########
.github/workflows/object_store.yml:
##########
@@ -86,6 +86,7 @@ jobs:
- name: Configure Fake GCS Server (GCP emulation)
run: |
docker run -d -p 4443:4443 fsouza/fake-gcs-server -scheme http
+ sleep 1
Review Comment:
We could also always do the classic loop until success with timeout -- but I think the sleep idea initially is much simpler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org