You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/07/26 10:04:17 UTC

[GitHub] [jackrabbit-oak] nit0906 commented on a diff in pull request #639: OAK-9856 | Log query and caller stack trace in case of ES search fail…

nit0906 commented on code in PR #639:
URL: https://github.com/apache/jackrabbit-oak/pull/639#discussion_r929773251


##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/async/ElasticResultRowAsyncIterator.java:
##########
@@ -71,11 +71,11 @@ public class ElasticResultRowAsyncIterator implements Iterator<FulltextResultRow
     private final Predicate<String> rowInclusionPredicate;
     private final ElasticMetricHandler metricHandler;
     private final LMSEstimator estimator;
-
     private final ElasticQueryScanner elasticQueryScanner;
     private final ElasticRequestHandler elasticRequestHandler;
     private final ElasticResponseHandler elasticResponseHandler;
     private final ElasticFacetProvider elasticFacetProvider;
+    private final BlockingQueue<Throwable> errorQueue = new LinkedBlockingQueue<>();

Review Comment:
   @nfsantos  - there could be possible multiple calls to onFailure (since we get the results from ES in batched - there could possibly be a case where the query is fine and returns well on the first fetch but there are some connectivity issues during the second fetch - I am not entirely sure about such a case though.)
   
   But agreed, I can possibly try and use the existing result queue somehow. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org