You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by apurvam <gi...@git.apache.org> on 2017/06/09 22:53:59 UTC

[GitHub] kafka pull request #3286: KAFKA-5415: Remove timestamp check in completeTran...

GitHub user apurvam opened a pull request:

    https://github.com/apache/kafka/pull/3286

    KAFKA-5415: Remove timestamp check in completeTransitionTo

    This assertion is hard to get right because the system time can roll backward on a host due to NTP (as shown in the ticket), and also because a transaction can start on one host and complete on another. Getting precise clock times across hosts is virtually impossible, and this check makes things fragile.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apurvam/kafka KAFKA-5415-avoid-timestamp-check-in-completeTransition

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3286.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3286
    
----
commit ccf5217d5a5985e7e88b2794c5fe43ff5b1d8a58
Author: Apurva Mehta <ap...@confluent.io>
Date:   2017-06-09T22:51:31Z

    Remove timestamp check in completeTransitionTo

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #3286: KAFKA-5415: Remove timestamp check in completeTran...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/3286


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---