You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/08 04:10:56 UTC

[GitHub] MaxGekk opened a new pull request #20793: [WIP][SPARK-23643] Shrinking the buffer in hashSeed up to size of the seed parameter

MaxGekk opened a new pull request #20793: [WIP][SPARK-23643] Shrinking the buffer in hashSeed up to size of the seed parameter
URL: https://github.com/apache/spark/pull/20793
 
 
   ## What changes were proposed in this pull request?
   
   The hashSeed method allocates 64 bytes instead of 8. Other bytes are always zeros (thanks to default behavior of ByteBuffer). And they could be excluded from hash calculation because they don't differentiate inputs.
   
   ## How was this patch tested?
   
   By running the existing tests - XORShiftRandomSuite

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org