You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@karaf.apache.org by Ioannis Canellos <io...@gmail.com> on 2011/11/19 14:02:57 UTC
Re: svn commit: r1201204 - in /karaf/trunk/features/core/src:
main/java/org/apache/karaf/features/internal/ main/resources/org/apache/karaf/features/
test/java/org/apache/karaf/features/ test/resources/org/apache/karaf/features/
I came across this one today:
> - <xs:attribute name="name" type="xs:string" />
> + <xs:attribute name="name" type="xs:string" use="required" />
> </xs:complexType>
>
Though I don't mind setting things strict, this will render some of the
existing existing feature descriptors useless (I am refering to 3rd party
descriptors).
This sounds kinda heavy and I do not see a good reason for it (what I mean
is that in order to cover a trivial need we seriously break backwards
compatibility).
If we still have to do so, then we might need to bump the version of the
xsd.
--
*Ioannis Canellos*
*
FuseSource <http://fusesource.com>
**
Blog: http://iocanel.blogspot.com
**
Apache Karaf <http://karaf.apache.org/> Committer & PMC
Apache Camel <http://camel.apache.org/> Committer
Apache ServiceMix <http://servicemix.apache.org/> Committer
Apache Gora <http://incubator.apache.org/gora/> Committer
Apache DirectMemory <http://incubator.apache.org/directmemory/> Committer
*
Re: svn commit: r1201204 - in /karaf/trunk/features/core/src:
main/java/org/apache/karaf/features/internal/ main/resources/org/apache/karaf/features/
test/java/org/apache/karaf/features/ test/resources/org/apache/karaf/features/
Posted by Achim Nierbeck <bc...@googlemail.com>.
Though I have to say,
it requires a bump in the xsd version, cause if this is required now it's a
major version upgrade.
:)
regards, Achim
2011/11/19 Jean-Baptiste Onofré <jb...@nanthrax.net>
> Hi Ioannis,
>
> My comments:
>
> 1/ it's on trunk, I display just a warning on 2.2.x
> 2/ the main reason is all features without name will use the same
> repository name (local-0 or so). It means that features:listrepositories is
> not helpful at all. With a mandatory name, we have a clean repository by
> features.
> 3/ all projects (Camel, CXF, SMX, etc) define the name on the recent
> versions. For instance, the last version without name is Camel 2.6.0.
>
> That's why I changed it on trunk, as it makes sense for me.
>
> Regards
> JB
>
>
> On 11/19/2011 02:02 PM, Ioannis Canellos wrote:
>
>> I came across this one today:
>>
>>
>>
>> -<xs:attribute name="name" type="xs:string" />
>>> +<xs:attribute name="name" type="xs:string" use="required" />
>>> </xs:complexType>
>>>
>>>
>>
>> Though I don't mind setting things strict, this will render some of the
>> existing existing feature descriptors useless (I am refering to 3rd party
>> descriptors).
>> This sounds kinda heavy and I do not see a good reason for it (what I mean
>> is that in order to cover a trivial need we seriously break backwards
>> compatibility).
>> If we still have to do so, then we might need to bump the version of the
>> xsd.
>>
>>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>
--
Apache Karaf <http://karaf.apache.org/> Committer & PMC
OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> Committer &
Project Lead
blog <http://notizblog.nierbeck.de/>
Re: svn commit: r1201204 - in /karaf/trunk/features/core/src: main/java/org/apache/karaf/features/internal/
main/resources/org/apache/karaf/features/ test/java/org/apache/karaf/features/
test/resources/org/apache/karaf/features/
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Agree.
My action plan:
1/ reopen KARAF-53 and set the validation "as optional" with a warning
2/ open the Jira in the dependent projects (Camel, AMQ, etc) to add the
namespace in the features descriptor
3/ when we have a new version of the projects with the namespace, I will
reset the features validation as required
Regards
JB
On 11/23/2011 05:02 PM, Guillaume Nodet wrote:
> Well, not being able to install activemq and camel sounds like a problem to
> me, even on trunk. Until we have releases of the satble branches that
> reference the schema, i'd be inclined to support those older release. Even
> then, people may want to deploy old versions, and I don't really see any
> real valid reason to not allow them to do that. If the only real benefit
> is to put something in the column when using feature:list, it may not be
> worth it.
>
> On Wed, Nov 23, 2011 at 16:52, Jean-Baptiste Onofré<jb...@nanthrax.net> wrote:
>
>> Does it mean that I reopen KARAF-53 to just raise a warn in the features
>> validation method ?
>>
>> To be honest, I would prefer to leave the trunk with a "blocking"
>> validation and update the dependent projects.
>>
>> WDYT ?
>>
>> Regards
>> JB
>>
>> On 11/23/2011 04:40 PM, Guillaume Nodet wrote:
>>
>>> I don't think it's about disabling the xml validation, but it's about
>>> allowing old feature definition to work.
>>> Afaik, both Camel and ActiveMQ can't work with the current trunk, so I'd
>>> rather defer that change to 3.1, and make sure we have releases of stable
>>> versions that will work with 3.0 before doing anything.
>>>
>>> On Wed, Nov 23, 2011 at 16:23, Jean-Baptiste Onofré<jb...@nanthrax.net>
>>> wrote:
>>>
>>> Guillaume,
>>>>
>>>> I was too quick in my previous answer. The Camel issue is not the same,
>>>> the name is well defined, but it doesn't define the namespace.
>>>>
>>>> On trunk, the XML validation using the XSD is used for a long time now.
>>>>
>>>> I don't want to disable it on trunk, and I think that the name definition
>>>> is fine.
>>>>
>>>> WDYT ?
>>>>
>>>>
>>>> Regards
>>>> JB
>>>>
>>>> On 11/23/2011 09:44 AM, Guillaume Nodet wrote:
>>>>
>>>> Actually, I've just hit a problem where the latest camel stable release
>>>>> 2.8.3 can't be deployed anymore because it does not contain the
>>>>> namespace.
>>>>> I wonder if rejecting such features definition is a bit premature at
>>>>> this
>>>>> point.
>>>>>
>>>>> On Sat, Nov 19, 2011 at 18:11, Jean-Baptiste Onofré<jb...@nanthrax.net>
>>>>> wrote:
>>>>>
>>>>> Hi Ioannis,
>>>>>
>>>>>>
>>>>>> My comments:
>>>>>>
>>>>>> 1/ it's on trunk, I display just a warning on 2.2.x
>>>>>> 2/ the main reason is all features without name will use the same
>>>>>> repository name (local-0 or so). It means that
>>>>>> features:listrepositories
>>>>>> is
>>>>>> not helpful at all. With a mandatory name, we have a clean repository
>>>>>> by
>>>>>> features.
>>>>>> 3/ all projects (Camel, CXF, SMX, etc) define the name on the recent
>>>>>> versions. For instance, the last version without name is Camel 2.6.0.
>>>>>>
>>>>>> That's why I changed it on trunk, as it makes sense for me.
>>>>>>
>>>>>> Regards
>>>>>> JB
>>>>>>
>>>>>>
>>>>>> On 11/19/2011 02:02 PM, Ioannis Canellos wrote:
>>>>>>
>>>>>> I came across this one today:
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> -<xs:attribute name="name" type="xs:string" />
>>>>>>>
>>>>>>> +<xs:attribute name="name" type="xs:string" use="required" />
>>>>>>>> </xs:complexType>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Though I don't mind setting things strict, this will render some of
>>>>>>> the
>>>>>>> existing existing feature descriptors useless (I am refering to 3rd
>>>>>>> party
>>>>>>> descriptors).
>>>>>>> This sounds kinda heavy and I do not see a good reason for it (what I
>>>>>>> mean
>>>>>>> is that in order to cover a trivial need we seriously break backwards
>>>>>>> compatibility).
>>>>>>> If we still have to do so, then we might need to bump the version of
>>>>>>> the
>>>>>>> xsd.
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>>
>>>>>> Jean-Baptiste Onofré
>>>>>> jbonofre@apache.org
>>>>>> http://blog.nanthrax.net
>>>>>> Talend - http://www.talend.com
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>> Jean-Baptiste Onofré
>>>> jbonofre@apache.org
>>>> http://blog.nanthrax.net
>>>> Talend - http://www.talend.com
>>>>
>>>>
>>>
>>>
>>>
>> --
>> Jean-Baptiste Onofré
>> jbonofre@apache.org
>> http://blog.nanthrax.net
>> Talend - http://www.talend.com
>>
>
>
>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: svn commit: r1201204 - in /karaf/trunk/features/core/src:
main/java/org/apache/karaf/features/internal/ main/resources/org/apache/karaf/features/
test/java/org/apache/karaf/features/ test/resources/org/apache/karaf/features/
Posted by Guillaume Nodet <gn...@gmail.com>.
Well, not being able to install activemq and camel sounds like a problem to
me, even on trunk. Until we have releases of the satble branches that
reference the schema, i'd be inclined to support those older release. Even
then, people may want to deploy old versions, and I don't really see any
real valid reason to not allow them to do that. If the only real benefit
is to put something in the column when using feature:list, it may not be
worth it.
On Wed, Nov 23, 2011 at 16:52, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
> Does it mean that I reopen KARAF-53 to just raise a warn in the features
> validation method ?
>
> To be honest, I would prefer to leave the trunk with a "blocking"
> validation and update the dependent projects.
>
> WDYT ?
>
> Regards
> JB
>
> On 11/23/2011 04:40 PM, Guillaume Nodet wrote:
>
>> I don't think it's about disabling the xml validation, but it's about
>> allowing old feature definition to work.
>> Afaik, both Camel and ActiveMQ can't work with the current trunk, so I'd
>> rather defer that change to 3.1, and make sure we have releases of stable
>> versions that will work with 3.0 before doing anything.
>>
>> On Wed, Nov 23, 2011 at 16:23, Jean-Baptiste Onofré<jb...@nanthrax.net>
>> wrote:
>>
>> Guillaume,
>>>
>>> I was too quick in my previous answer. The Camel issue is not the same,
>>> the name is well defined, but it doesn't define the namespace.
>>>
>>> On trunk, the XML validation using the XSD is used for a long time now.
>>>
>>> I don't want to disable it on trunk, and I think that the name definition
>>> is fine.
>>>
>>> WDYT ?
>>>
>>>
>>> Regards
>>> JB
>>>
>>> On 11/23/2011 09:44 AM, Guillaume Nodet wrote:
>>>
>>> Actually, I've just hit a problem where the latest camel stable release
>>>> 2.8.3 can't be deployed anymore because it does not contain the
>>>> namespace.
>>>> I wonder if rejecting such features definition is a bit premature at
>>>> this
>>>> point.
>>>>
>>>> On Sat, Nov 19, 2011 at 18:11, Jean-Baptiste Onofré<jb...@nanthrax.net>
>>>> wrote:
>>>>
>>>> Hi Ioannis,
>>>>
>>>>>
>>>>> My comments:
>>>>>
>>>>> 1/ it's on trunk, I display just a warning on 2.2.x
>>>>> 2/ the main reason is all features without name will use the same
>>>>> repository name (local-0 or so). It means that
>>>>> features:listrepositories
>>>>> is
>>>>> not helpful at all. With a mandatory name, we have a clean repository
>>>>> by
>>>>> features.
>>>>> 3/ all projects (Camel, CXF, SMX, etc) define the name on the recent
>>>>> versions. For instance, the last version without name is Camel 2.6.0.
>>>>>
>>>>> That's why I changed it on trunk, as it makes sense for me.
>>>>>
>>>>> Regards
>>>>> JB
>>>>>
>>>>>
>>>>> On 11/19/2011 02:02 PM, Ioannis Canellos wrote:
>>>>>
>>>>> I came across this one today:
>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> -<xs:attribute name="name" type="xs:string" />
>>>>>>
>>>>>> +<xs:attribute name="name" type="xs:string" use="required" />
>>>>>>> </xs:complexType>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Though I don't mind setting things strict, this will render some of
>>>>>> the
>>>>>> existing existing feature descriptors useless (I am refering to 3rd
>>>>>> party
>>>>>> descriptors).
>>>>>> This sounds kinda heavy and I do not see a good reason for it (what I
>>>>>> mean
>>>>>> is that in order to cover a trivial need we seriously break backwards
>>>>>> compatibility).
>>>>>> If we still have to do so, then we might need to bump the version of
>>>>>> the
>>>>>> xsd.
>>>>>>
>>>>>>
>>>>>> --
>>>>>>
>>>>> Jean-Baptiste Onofré
>>>>> jbonofre@apache.org
>>>>> http://blog.nanthrax.net
>>>>> Talend - http://www.talend.com
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>> Jean-Baptiste Onofré
>>> jbonofre@apache.org
>>> http://blog.nanthrax.net
>>> Talend - http://www.talend.com
>>>
>>>
>>
>>
>>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>
--
------------------------
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com
Re: svn commit: r1201204 - in /karaf/trunk/features/core/src: main/java/org/apache/karaf/features/internal/
main/resources/org/apache/karaf/features/ test/java/org/apache/karaf/features/
test/resources/org/apache/karaf/features/
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Does it mean that I reopen KARAF-53 to just raise a warn in the features
validation method ?
To be honest, I would prefer to leave the trunk with a "blocking"
validation and update the dependent projects.
WDYT ?
Regards
JB
On 11/23/2011 04:40 PM, Guillaume Nodet wrote:
> I don't think it's about disabling the xml validation, but it's about
> allowing old feature definition to work.
> Afaik, both Camel and ActiveMQ can't work with the current trunk, so I'd
> rather defer that change to 3.1, and make sure we have releases of stable
> versions that will work with 3.0 before doing anything.
>
> On Wed, Nov 23, 2011 at 16:23, Jean-Baptiste Onofré<jb...@nanthrax.net> wrote:
>
>> Guillaume,
>>
>> I was too quick in my previous answer. The Camel issue is not the same,
>> the name is well defined, but it doesn't define the namespace.
>>
>> On trunk, the XML validation using the XSD is used for a long time now.
>>
>> I don't want to disable it on trunk, and I think that the name definition
>> is fine.
>>
>> WDYT ?
>>
>>
>> Regards
>> JB
>>
>> On 11/23/2011 09:44 AM, Guillaume Nodet wrote:
>>
>>> Actually, I've just hit a problem where the latest camel stable release
>>> 2.8.3 can't be deployed anymore because it does not contain the namespace.
>>> I wonder if rejecting such features definition is a bit premature at this
>>> point.
>>>
>>> On Sat, Nov 19, 2011 at 18:11, Jean-Baptiste Onofré<jb...@nanthrax.net>
>>> wrote:
>>>
>>> Hi Ioannis,
>>>>
>>>> My comments:
>>>>
>>>> 1/ it's on trunk, I display just a warning on 2.2.x
>>>> 2/ the main reason is all features without name will use the same
>>>> repository name (local-0 or so). It means that features:listrepositories
>>>> is
>>>> not helpful at all. With a mandatory name, we have a clean repository by
>>>> features.
>>>> 3/ all projects (Camel, CXF, SMX, etc) define the name on the recent
>>>> versions. For instance, the last version without name is Camel 2.6.0.
>>>>
>>>> That's why I changed it on trunk, as it makes sense for me.
>>>>
>>>> Regards
>>>> JB
>>>>
>>>>
>>>> On 11/19/2011 02:02 PM, Ioannis Canellos wrote:
>>>>
>>>> I came across this one today:
>>>>>
>>>>>
>>>>>
>>>>> -<xs:attribute name="name" type="xs:string" />
>>>>>
>>>>>> +<xs:attribute name="name" type="xs:string" use="required" />
>>>>>> </xs:complexType>
>>>>>>
>>>>>>
>>>>>>
>>>>> Though I don't mind setting things strict, this will render some of the
>>>>> existing existing feature descriptors useless (I am refering to 3rd
>>>>> party
>>>>> descriptors).
>>>>> This sounds kinda heavy and I do not see a good reason for it (what I
>>>>> mean
>>>>> is that in order to cover a trivial need we seriously break backwards
>>>>> compatibility).
>>>>> If we still have to do so, then we might need to bump the version of the
>>>>> xsd.
>>>>>
>>>>>
>>>>> --
>>>> Jean-Baptiste Onofré
>>>> jbonofre@apache.org
>>>> http://blog.nanthrax.net
>>>> Talend - http://www.talend.com
>>>>
>>>>
>>>
>>>
>>>
>> --
>> Jean-Baptiste Onofré
>> jbonofre@apache.org
>> http://blog.nanthrax.net
>> Talend - http://www.talend.com
>>
>
>
>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: svn commit: r1201204 - in /karaf/trunk/features/core/src: main/java/org/apache/karaf/features/internal/
main/resources/org/apache/karaf/features/ test/java/org/apache/karaf/features/
test/resources/org/apache/karaf/features/
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
I got your point Guillaume.
However, we don't speak about about the xs:attribute name required.
The XSD validation (blocker) is present on trunk since a long time.
I'm agree to just raise a warning during validation on trunk (as we do
on karaf-2.2.x) and postpone the XSD validation for 3.1.0.
In any case, I'm gonna fix the features of the "dependent" projects.
Regards
JB
On 11/23/2011 04:40 PM, Guillaume Nodet wrote:
> I don't think it's about disabling the xml validation, but it's about
> allowing old feature definition to work.
> Afaik, both Camel and ActiveMQ can't work with the current trunk, so I'd
> rather defer that change to 3.1, and make sure we have releases of stable
> versions that will work with 3.0 before doing anything.
>
> On Wed, Nov 23, 2011 at 16:23, Jean-Baptiste Onofré<jb...@nanthrax.net> wrote:
>
>> Guillaume,
>>
>> I was too quick in my previous answer. The Camel issue is not the same,
>> the name is well defined, but it doesn't define the namespace.
>>
>> On trunk, the XML validation using the XSD is used for a long time now.
>>
>> I don't want to disable it on trunk, and I think that the name definition
>> is fine.
>>
>> WDYT ?
>>
>>
>> Regards
>> JB
>>
>> On 11/23/2011 09:44 AM, Guillaume Nodet wrote:
>>
>>> Actually, I've just hit a problem where the latest camel stable release
>>> 2.8.3 can't be deployed anymore because it does not contain the namespace.
>>> I wonder if rejecting such features definition is a bit premature at this
>>> point.
>>>
>>> On Sat, Nov 19, 2011 at 18:11, Jean-Baptiste Onofré<jb...@nanthrax.net>
>>> wrote:
>>>
>>> Hi Ioannis,
>>>>
>>>> My comments:
>>>>
>>>> 1/ it's on trunk, I display just a warning on 2.2.x
>>>> 2/ the main reason is all features without name will use the same
>>>> repository name (local-0 or so). It means that features:listrepositories
>>>> is
>>>> not helpful at all. With a mandatory name, we have a clean repository by
>>>> features.
>>>> 3/ all projects (Camel, CXF, SMX, etc) define the name on the recent
>>>> versions. For instance, the last version without name is Camel 2.6.0.
>>>>
>>>> That's why I changed it on trunk, as it makes sense for me.
>>>>
>>>> Regards
>>>> JB
>>>>
>>>>
>>>> On 11/19/2011 02:02 PM, Ioannis Canellos wrote:
>>>>
>>>> I came across this one today:
>>>>>
>>>>>
>>>>>
>>>>> -<xs:attribute name="name" type="xs:string" />
>>>>>
>>>>>> +<xs:attribute name="name" type="xs:string" use="required" />
>>>>>> </xs:complexType>
>>>>>>
>>>>>>
>>>>>>
>>>>> Though I don't mind setting things strict, this will render some of the
>>>>> existing existing feature descriptors useless (I am refering to 3rd
>>>>> party
>>>>> descriptors).
>>>>> This sounds kinda heavy and I do not see a good reason for it (what I
>>>>> mean
>>>>> is that in order to cover a trivial need we seriously break backwards
>>>>> compatibility).
>>>>> If we still have to do so, then we might need to bump the version of the
>>>>> xsd.
>>>>>
>>>>>
>>>>> --
>>>> Jean-Baptiste Onofré
>>>> jbonofre@apache.org
>>>> http://blog.nanthrax.net
>>>> Talend - http://www.talend.com
>>>>
>>>>
>>>
>>>
>>>
>> --
>> Jean-Baptiste Onofré
>> jbonofre@apache.org
>> http://blog.nanthrax.net
>> Talend - http://www.talend.com
>>
>
>
>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: svn commit: r1201204 - in /karaf/trunk/features/core/src:
main/java/org/apache/karaf/features/internal/ main/resources/org/apache/karaf/features/
test/java/org/apache/karaf/features/ test/resources/org/apache/karaf/features/
Posted by Guillaume Nodet <gn...@gmail.com>.
I don't think it's about disabling the xml validation, but it's about
allowing old feature definition to work.
Afaik, both Camel and ActiveMQ can't work with the current trunk, so I'd
rather defer that change to 3.1, and make sure we have releases of stable
versions that will work with 3.0 before doing anything.
On Wed, Nov 23, 2011 at 16:23, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
> Guillaume,
>
> I was too quick in my previous answer. The Camel issue is not the same,
> the name is well defined, but it doesn't define the namespace.
>
> On trunk, the XML validation using the XSD is used for a long time now.
>
> I don't want to disable it on trunk, and I think that the name definition
> is fine.
>
> WDYT ?
>
>
> Regards
> JB
>
> On 11/23/2011 09:44 AM, Guillaume Nodet wrote:
>
>> Actually, I've just hit a problem where the latest camel stable release
>> 2.8.3 can't be deployed anymore because it does not contain the namespace.
>> I wonder if rejecting such features definition is a bit premature at this
>> point.
>>
>> On Sat, Nov 19, 2011 at 18:11, Jean-Baptiste Onofré<jb...@nanthrax.net>
>> wrote:
>>
>> Hi Ioannis,
>>>
>>> My comments:
>>>
>>> 1/ it's on trunk, I display just a warning on 2.2.x
>>> 2/ the main reason is all features without name will use the same
>>> repository name (local-0 or so). It means that features:listrepositories
>>> is
>>> not helpful at all. With a mandatory name, we have a clean repository by
>>> features.
>>> 3/ all projects (Camel, CXF, SMX, etc) define the name on the recent
>>> versions. For instance, the last version without name is Camel 2.6.0.
>>>
>>> That's why I changed it on trunk, as it makes sense for me.
>>>
>>> Regards
>>> JB
>>>
>>>
>>> On 11/19/2011 02:02 PM, Ioannis Canellos wrote:
>>>
>>> I came across this one today:
>>>>
>>>>
>>>>
>>>> -<xs:attribute name="name" type="xs:string" />
>>>>
>>>>> +<xs:attribute name="name" type="xs:string" use="required" />
>>>>> </xs:complexType>
>>>>>
>>>>>
>>>>>
>>>> Though I don't mind setting things strict, this will render some of the
>>>> existing existing feature descriptors useless (I am refering to 3rd
>>>> party
>>>> descriptors).
>>>> This sounds kinda heavy and I do not see a good reason for it (what I
>>>> mean
>>>> is that in order to cover a trivial need we seriously break backwards
>>>> compatibility).
>>>> If we still have to do so, then we might need to bump the version of the
>>>> xsd.
>>>>
>>>>
>>>> --
>>> Jean-Baptiste Onofré
>>> jbonofre@apache.org
>>> http://blog.nanthrax.net
>>> Talend - http://www.talend.com
>>>
>>>
>>
>>
>>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>
--
------------------------
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com
Re: svn commit: r1201204 - in /karaf/trunk/features/core/src: main/java/org/apache/karaf/features/internal/
main/resources/org/apache/karaf/features/ test/java/org/apache/karaf/features/
test/resources/org/apache/karaf/features/
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Guillaume,
I was too quick in my previous answer. The Camel issue is not the same,
the name is well defined, but it doesn't define the namespace.
On trunk, the XML validation using the XSD is used for a long time now.
I don't want to disable it on trunk, and I think that the name
definition is fine.
WDYT ?
Regards
JB
On 11/23/2011 09:44 AM, Guillaume Nodet wrote:
> Actually, I've just hit a problem where the latest camel stable release
> 2.8.3 can't be deployed anymore because it does not contain the namespace.
> I wonder if rejecting such features definition is a bit premature at this
> point.
>
> On Sat, Nov 19, 2011 at 18:11, Jean-Baptiste Onofré<jb...@nanthrax.net> wrote:
>
>> Hi Ioannis,
>>
>> My comments:
>>
>> 1/ it's on trunk, I display just a warning on 2.2.x
>> 2/ the main reason is all features without name will use the same
>> repository name (local-0 or so). It means that features:listrepositories is
>> not helpful at all. With a mandatory name, we have a clean repository by
>> features.
>> 3/ all projects (Camel, CXF, SMX, etc) define the name on the recent
>> versions. For instance, the last version without name is Camel 2.6.0.
>>
>> That's why I changed it on trunk, as it makes sense for me.
>>
>> Regards
>> JB
>>
>>
>> On 11/19/2011 02:02 PM, Ioannis Canellos wrote:
>>
>>> I came across this one today:
>>>
>>>
>>>
>>> -<xs:attribute name="name" type="xs:string" />
>>>> +<xs:attribute name="name" type="xs:string" use="required" />
>>>> </xs:complexType>
>>>>
>>>>
>>>
>>> Though I don't mind setting things strict, this will render some of the
>>> existing existing feature descriptors useless (I am refering to 3rd party
>>> descriptors).
>>> This sounds kinda heavy and I do not see a good reason for it (what I mean
>>> is that in order to cover a trivial need we seriously break backwards
>>> compatibility).
>>> If we still have to do so, then we might need to bump the version of the
>>> xsd.
>>>
>>>
>> --
>> Jean-Baptiste Onofré
>> jbonofre@apache.org
>> http://blog.nanthrax.net
>> Talend - http://www.talend.com
>>
>
>
>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: svn commit: r1201204 - in /karaf/trunk/features/core/src: main/java/org/apache/karaf/features/internal/
main/resources/org/apache/karaf/features/ test/java/org/apache/karaf/features/
test/resources/org/apache/karaf/features/
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi Guillaume
You're right about Camel features XML.
I'm gonna revert my change on Karaf trunk, but check the projects like
Camel, CXF, etc to be sure that the namespace is well defined.
Regards
JB
On 11/23/2011 09:44 AM, Guillaume Nodet wrote:
> Actually, I've just hit a problem where the latest camel stable release
> 2.8.3 can't be deployed anymore because it does not contain the namespace.
> I wonder if rejecting such features definition is a bit premature at this
> point.
>
> On Sat, Nov 19, 2011 at 18:11, Jean-Baptiste Onofré<jb...@nanthrax.net> wrote:
>
>> Hi Ioannis,
>>
>> My comments:
>>
>> 1/ it's on trunk, I display just a warning on 2.2.x
>> 2/ the main reason is all features without name will use the same
>> repository name (local-0 or so). It means that features:listrepositories is
>> not helpful at all. With a mandatory name, we have a clean repository by
>> features.
>> 3/ all projects (Camel, CXF, SMX, etc) define the name on the recent
>> versions. For instance, the last version without name is Camel 2.6.0.
>>
>> That's why I changed it on trunk, as it makes sense for me.
>>
>> Regards
>> JB
>>
>>
>> On 11/19/2011 02:02 PM, Ioannis Canellos wrote:
>>
>>> I came across this one today:
>>>
>>>
>>>
>>> -<xs:attribute name="name" type="xs:string" />
>>>> +<xs:attribute name="name" type="xs:string" use="required" />
>>>> </xs:complexType>
>>>>
>>>>
>>>
>>> Though I don't mind setting things strict, this will render some of the
>>> existing existing feature descriptors useless (I am refering to 3rd party
>>> descriptors).
>>> This sounds kinda heavy and I do not see a good reason for it (what I mean
>>> is that in order to cover a trivial need we seriously break backwards
>>> compatibility).
>>> If we still have to do so, then we might need to bump the version of the
>>> xsd.
>>>
>>>
>> --
>> Jean-Baptiste Onofré
>> jbonofre@apache.org
>> http://blog.nanthrax.net
>> Talend - http://www.talend.com
>>
>
>
>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: svn commit: r1201204 - in /karaf/trunk/features/core/src:
main/java/org/apache/karaf/features/internal/ main/resources/org/apache/karaf/features/
test/java/org/apache/karaf/features/ test/resources/org/apache/karaf/features/
Posted by Guillaume Nodet <gn...@gmail.com>.
Actually, I've just hit a problem where the latest camel stable release
2.8.3 can't be deployed anymore because it does not contain the namespace.
I wonder if rejecting such features definition is a bit premature at this
point.
On Sat, Nov 19, 2011 at 18:11, Jean-Baptiste Onofré <jb...@nanthrax.net> wrote:
> Hi Ioannis,
>
> My comments:
>
> 1/ it's on trunk, I display just a warning on 2.2.x
> 2/ the main reason is all features without name will use the same
> repository name (local-0 or so). It means that features:listrepositories is
> not helpful at all. With a mandatory name, we have a clean repository by
> features.
> 3/ all projects (Camel, CXF, SMX, etc) define the name on the recent
> versions. For instance, the last version without name is Camel 2.6.0.
>
> That's why I changed it on trunk, as it makes sense for me.
>
> Regards
> JB
>
>
> On 11/19/2011 02:02 PM, Ioannis Canellos wrote:
>
>> I came across this one today:
>>
>>
>>
>> -<xs:attribute name="name" type="xs:string" />
>>> +<xs:attribute name="name" type="xs:string" use="required" />
>>> </xs:complexType>
>>>
>>>
>>
>> Though I don't mind setting things strict, this will render some of the
>> existing existing feature descriptors useless (I am refering to 3rd party
>> descriptors).
>> This sounds kinda heavy and I do not see a good reason for it (what I mean
>> is that in order to cover a trivial need we seriously break backwards
>> compatibility).
>> If we still have to do so, then we might need to bump the version of the
>> xsd.
>>
>>
> --
> Jean-Baptiste Onofré
> jbonofre@apache.org
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>
--
------------------------
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com
Re: svn commit: r1201204 - in /karaf/trunk/features/core/src: main/java/org/apache/karaf/features/internal/
main/resources/org/apache/karaf/features/ test/java/org/apache/karaf/features/
test/resources/org/apache/karaf/features/
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi Ioannis,
My comments:
1/ it's on trunk, I display just a warning on 2.2.x
2/ the main reason is all features without name will use the same
repository name (local-0 or so). It means that features:listrepositories
is not helpful at all. With a mandatory name, we have a clean repository
by features.
3/ all projects (Camel, CXF, SMX, etc) define the name on the recent
versions. For instance, the last version without name is Camel 2.6.0.
That's why I changed it on trunk, as it makes sense for me.
Regards
JB
On 11/19/2011 02:02 PM, Ioannis Canellos wrote:
> I came across this one today:
>
>
>
>> -<xs:attribute name="name" type="xs:string" />
>> +<xs:attribute name="name" type="xs:string" use="required" />
>> </xs:complexType>
>>
>
>
> Though I don't mind setting things strict, this will render some of the
> existing existing feature descriptors useless (I am refering to 3rd party
> descriptors).
> This sounds kinda heavy and I do not see a good reason for it (what I mean
> is that in order to cover a trivial need we seriously break backwards
> compatibility).
> If we still have to do so, then we might need to bump the version of the
> xsd.
>
--
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com