You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2024/03/12 10:53:32 UTC
[PR] [improve][test] Don't configure Mockito spying for MultiBrokerTestZKBaseTest [pulsar]
lhotari opened a new pull request, #22250:
URL: https://github.com/apache/pulsar/pull/22250
Fixes #22239
### Motivation
The AdvertisedListenersMultiBrokerLeaderElectionTest test is flaky since it times out.
I provided the test with Async Profiler on Linux by adding this to pom.xml in `<test.additional.args>`
```
<test.additional.args>
-agentpath:/home/lari/tools/async-profiler-3.0-linux-x64/lib/libasyncProfiler.so=start,event=cpu,jfr,file=/tmp/profile${maven.build.timestamp}_${surefire.forkNumber}.jfr
```
and converting the `.jfr` file to `.html` with `java -jar tools/async-profiler-3.0-macos/lib/converter.jar jfr2flame profile2024-03-12T10:44:25Z_1.jfr output.html` and `java -jar tools/async-profiler-3.0-macos/lib/converter.jar jfr2flame --threads profile2024-03-12T10:44:25Z_1.jfr output_threads.html`.
### Modifications
- add `.spyNoneByDefault()` to `PulsarTestContext.Builder`
- use this in MultiBrokerTestZKBaseTest
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][test] Don't configure Mockito spying for MultiBrokerTestZKBaseTest [pulsar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #22250:
URL: https://github.com/apache/pulsar/pull/22250#issuecomment-1991744532
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/22250?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 73.64%. Comparing base [(`bbc6224`)](https://app.codecov.io/gh/apache/pulsar/commit/bbc62245c5ddba1de4b1e7cee4ab49334bc36277?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`f49fdca`)](https://app.codecov.io/gh/apache/pulsar/pull/22250?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 36 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/pulsar/pull/22250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #22250 +/- ##
============================================
+ Coverage 73.57% 73.64% +0.06%
+ Complexity 32624 32172 -452
============================================
Files 1877 1879 +2
Lines 139502 139793 +291
Branches 15299 15338 +39
============================================
+ Hits 102638 102944 +306
+ Misses 28908 28862 -46
- Partials 7956 7987 +31
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/22250/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/22250/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `26.59% <ø> (+2.00%)` | :arrow_up: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/22250/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.40% <ø> (+0.07%)` | :arrow_up: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/22250/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.89% <ø> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 82 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/22250/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][test] Don't configure Mockito spying for MultiBrokerTestZKBaseTest [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #22250:
URL: https://github.com/apache/pulsar/pull/22250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org