You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "jongyoul (via GitHub)" <gi...@apache.org> on 2026/08/19 11:07:49 UTC

[PR] [HOTFIX] Validate note access for interpreter bindings [zeppelin]

jongyoul opened a new pull request, #5431:
URL: https://github.com/apache/zeppelin/pull/5431

   ### What is this PR for?
   
   Ensure that interpreter binding operations follow the permissions of the associated note.
   
   - Reading interpreter bindings requires reader permission.
   - Updating interpreter bindings requires writer permission.
   - Requests without the required permission stop before returning binding data or applying changes.
   - Add regression tests for permitted and rejected read/write requests.
   
   ### What type of PR is it?
   
   Hot Fix
   
   ### Todos
   
   * [x] Add note permission checks for interpreter binding operations
   * [x] Add regression tests
   * [x] Run `NotebookServerTest`
   
   ### What is the Jira issue?
   
   N/A
   
   ### How should this be tested?
   
   ```bash
   mkdir -p spark/interpreter/target
   ./mvnw -pl spark/interpreter resources:resources@copy-interpreter-setting
   ./mvnw -pl zeppelin-server -Dtest=NotebookServerTest test
   ```
   
   Result: 25 tests run, 0 failures, 0 errors.
   
   ### Screenshots (if appropriate)
   
   N/A
   
   ### Questions:
   
   * Does the license files need to update? No.
   * Is there breaking changes for older versions? No API compatibility changes. Requests without the required note permission are now rejected as intended.
   * Does this needs documentation? No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HOTFIX] Validate note access for interpreter bindings [zeppelin]

Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul commented on PR #5431:
URL: https://github.com/apache/zeppelin/pull/5431#issuecomment-5353092050

   Merged into master (2593fc08).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [HOTFIX] Validate note access for interpreter bindings [zeppelin]

Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul merged PR #5431:
URL: https://github.com/apache/zeppelin/pull/5431


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org