You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "MonkeyCanCode (via GitHub)" <gi...@apache.org> on 2026/09/06 02:01:09 UTC

Re: [PR] [BugFix] Skip GCP resource detection when tracing is disabled (#5401) [polaris]

MonkeyCanCode commented on code in PR #5404:
URL: https://github.com/apache/polaris/pull/5404#discussion_r3942666210


##########
CHANGELOG.md:
##########
@@ -65,24 +42,14 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti
 
 ### Changes
 
-- A metastore failure during authentication now returns a fixed `Service unavailable` message
-  instead of naming the lookup that failed; the principal lookup previously returned `Unable to
-  fetch principal entity`. The failing lookup is still named in the server log at `ERROR`, which
-  operators can match to the client error through the request id, returned by default as
-  `X-Request-ID` and printed by the default log format as `requestId`.
-- `DROP_WITH_PURGE_ENABLED` now applies to Iceberg tables only. It previously also gated the
-  metadata purge that a view drop performs internally, so with its default of `false` and
-  `PURGE_VIEW_METADATA_ON_DROP` defaulting to `true`, dropping any view failed with HTTP 403 under
-  the default configuration. A view drop is now governed by `PURGE_VIEW_METADATA_ON_DROP` alone,
-  while the guard continues to protect a client-requested Iceberg table purge.
-
 ### Deprecations
 
 ### Fixes
 
+- Helm chart: when tracing is disabled (default), the `OTEL_JAVA_DISABLED_RESOURCE_PROVIDERS` environment variable is now set to `io.opentelemetry.contrib.gcp.resource.GCPResourceProvider`, preventing the OpenTelemetry GCP resource detector from blocking Polaris startup for ~135s in environments where `metadata.google.internal` resolves to a silently-dropping address (local Kubernetes, Docker, etc.).
 - Python CLI `catalogs create --type external` now validates `--storage-type` and `--default-base-location` up front, matching the behavior for internal catalogs and the flags' documented "(Required)" status. Previously, omitting either produced an opaque pydantic `ValidationError` at request-build time.

Review Comment:
   Please fix changes here as 2 of them are un-related to this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org