You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/12 15:18:58 UTC
[GitHub] [flink] pnowojski commented on a change in pull request #11071:
[FLINK-16019][runtime] fix ContinuousFileReaderOperator error handling
pnowojski commented on a change in pull request #11071: [FLINK-16019][runtime] fix ContinuousFileReaderOperator error handling
URL: https://github.com/apache/flink/pull/11071#discussion_r378316796
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
##########
@@ -380,10 +380,11 @@ public void processWatermark(Watermark mark) throws Exception {
public void dispose() throws Exception {
Exception e = null;
if (state != ReaderState.CLOSED) {
+ state = ReaderState.CLOSED;
Review comment:
I guess we could add a test simple test coverage for this `state = ReaderState.CLOSED`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services